This is an archive of the discontinued LLVM Phabricator instance.

Differential D156656

[InstCombine][NFC] Tests for folding icmp(constants[x])
Needs ReviewPublic

Authored by XChy on Jul 31 2023, 2:15 AM.

Details

Reviewers
nikic
goldstein.w.n
Summary

Tests for upcoming patch.
Issue

Diff Detail

Unit TestsFailed

TimeTest
60,040 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

XChy created this revision.Jul 31 2023, 2:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2023, 2:15 AM
Herald added a subscriber: arphaman. · View Herald Transcript
XChy requested review of this revision.Jul 31 2023, 2:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2023, 2:15 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
XChy added reviewers: nikic, goldstein.w.n.Jul 31 2023, 2:15 AM
XChy set the repository for this revision to rG LLVM Github Monorepo.
Herald added a subscriber: StephenFan. · View Herald TranscriptJul 31 2023, 2:15 AM
XChy added a child revision: D156657: [InstCombine] Fold icmp(constants[x]) when the range of x is given.Jul 31 2023, 2:30 AM
Harbormaster completed remote builds in B249133: Diff 545548.Jul 31 2023, 3:19 AM
XChy retitled this revision from [ValueTracking][NFC] Tests for folding icmp(constants[x]) to [InstCombine][NFC] Tests for folding icmp(constants[x]) .Jul 31 2023, 6:55 AM
XChy updated this revision to Diff 545636.Jul 31 2023, 6:58 AM

Extend foldCmpLoadFromIndexedGlobal and use load-cmp.ll as test file.

XChy updated this revision to Diff 545660.Jul 31 2023, 7:49 AM

Update tests

XChy updated this revision to Diff 545669.Jul 31 2023, 7:58 AM
Harbormaster completed remote builds in B249225: Diff 545669.Jul 31 2023, 9:16 AM
XChy updated this revision to Diff 546117.Aug 1 2023, 10:12 AM
Harbormaster completed remote builds in B249530: Diff 546117.Aug 1 2023, 12:02 PM

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
119 lines

Diff 545548

llvm/test/Transforms/InstCombine/load-cmp-index.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
; RUN: opt -passes=instcombine -S < %s | FileCheck %s
@CG = constant [4 x i32] [i32 1, i32 2, i32 3, i32 4]
define i1 @cmp_load_constant_array0(i64 %x){
; CHECK-LABEL: define i1 @cmp_load_constant_array0
; CHECK-SAME: (i64 [[X:%.*]]) {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[COND:%.*]] = icmp ult i64 [[X]], 2
; CHECK-NEXT: br i1 [[COND]], label [[CASE1:%.*]], label [[CASE2:%.*]]
; CHECK: case2:
; CHECK-NEXT: ret i1 false
; CHECK: case1:
; CHECK-NEXT: [[ISOK_PTR:%.*]] = getelementptr inbounds i32, ptr @CG, i64 [[X]]
; CHECK-NEXT: [[ISOK:%.*]] = load i32, ptr [[ISOK_PTR]], align 4
; CHECK-NEXT: [[COND_INFERRED:%.*]] = icmp ult i32 [[ISOK]], 3
; CHECK-NEXT: ret i1 [[COND_INFERRED]]
;
entry:
%cond = icmp ult i64 %x, 2
br i1 %cond, label %case1, label %case2
case2:
ret i1 0
case1:
%isOK_ptr = getelementptr inbounds i32, ptr @CG, i64 %x
%isOK = load i32, ptr %isOK_ptr
%cond_inferred = icmp ult i32 %isOK, 3
ret i1 %cond_inferred
}
define i1 @cmp_load_constant_array1(i64 %x){
; CHECK-LABEL: define i1 @cmp_load_constant_array1
; CHECK-SAME: (i64 [[X:%.*]]) {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[COND:%.*]] = icmp ult i64 [[X]], 2
; CHECK-NEXT: br i1 [[COND]], label [[CASE1:%.*]], label [[CASE2:%.*]]
; CHECK: case2:
; CHECK-NEXT: ret i1 false
; CHECK: case1:
; CHECK-NEXT: [[ISOK_PTR:%.*]] = getelementptr inbounds i32, ptr @CG, i64 [[X]]
; CHECK-NEXT: [[ISOK:%.*]] = load i32, ptr [[ISOK_PTR]], align 4
; CHECK-NEXT: [[COND_INFERRED:%.*]] = icmp ugt i32 [[ISOK]], 10
; CHECK-NEXT: ret i1 [[COND_INFERRED]]
;
entry:
%cond = icmp ult i64 %x, 2
br i1 %cond, label %case1, label %case2
case2:
ret i1 0
case1:
%isOK_ptr = getelementptr inbounds i32, ptr @CG, i64 %x
%isOK = load i32, ptr %isOK_ptr
%cond_inferred = icmp ugt i32 %isOK, 10
ret i1 %cond_inferred
}
define i1 @cmp_load_constant_array_fail0(i64 %x) {
; CHECK-LABEL: define i1 @cmp_load_constant_array_fail0
; CHECK-SAME: (i64 [[X:%.*]]) {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[COND:%.*]] = icmp ult i64 [[X]], 6
; CHECK-NEXT: br i1 [[COND]], label [[CASE1:%.*]], label [[CASE2:%.*]]
; CHECK: case2:
; CHECK-NEXT: ret i1 false
; CHECK: case1:
; CHECK-NEXT: [[ISOK_PTR:%.*]] = getelementptr inbounds i32, ptr @CG, i64 [[X]]
; CHECK-NEXT: [[ISOK:%.*]] = load i32, ptr [[ISOK_PTR]], align 4
; CHECK-NEXT: [[COND_INFERRED:%.*]] = icmp ult i32 [[ISOK]], 5
; CHECK-NEXT: ret i1 [[COND_INFERRED]]
;
entry:
%cond = icmp ult i64 %x, 6
br i1 %cond, label %case1, label %case2
case2:
ret i1 0
case1:
%isOK_ptr = getelementptr inbounds i32, ptr @CG, i64 %x
%isOK = load i32, ptr %isOK_ptr
%cond_inferred = icmp ult i32 %isOK, 5
ret i1 %cond_inferred
}
define i1 @cmp_load_constant_array_fail1(i64 %x){
; CHECK-LABEL: define i1 @cmp_load_constant_array_fail1
; CHECK-SAME: (i64 [[X:%.*]]) {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[TMP0:%.*]] = add i64 [[X]], -1
; CHECK-NEXT: [[COND3:%.*]] = icmp ult i64 [[TMP0]], 2
; CHECK-NEXT: br i1 [[COND3]], label [[CASE1:%.*]], label [[CASE2:%.*]]
; CHECK: case2:
; CHECK-NEXT: ret i1 false
; CHECK: case1:
; CHECK-NEXT: [[ISOK_PTR:%.*]] = getelementptr inbounds i32, ptr @CG, i64 [[X]]
; CHECK-NEXT: [[ISOK:%.*]] = load i32, ptr [[ISOK_PTR]], align 4
; CHECK-NEXT: [[COND_INFERRED:%.*]] = icmp ugt i32 [[ISOK]], 1
; CHECK-NEXT: ret i1 [[COND_INFERRED]]
;
entry:
%cond1 = icmp ult i64 %x, 3
%cond2 = icmp ugt i64 %x, 0
%cond3 = and i1 %cond1,%cond2
br i1 %cond3, label %case1, label %case2
case2:
ret i1 0
case1:
%isOK_ptr = getelementptr inbounds i32, ptr @CG, i64 %x
%isOK = load i32, ptr %isOK_ptr
%cond_inferred = icmp ugt i32 %isOK, 1
ret i1 %cond_inferred
}