This is an archive of the discontinued LLVM Phabricator instance.

Differential D15664

Teaches clang about Exynos-M1
ClosedPublic

Authored by MinSeongKIM on Dec 19 2015, 12:13 AM.

Details

Reviewers
rengolin
t.p.northover
aemerson
christof
Commits
rG50d9c156ddca: [AArch64] Teaches clang about Samsung Exynos-M1
rC256829: [AArch64] Teaches clang about Samsung Exynos-M1
rL256829: [AArch64] Teaches clang about Samsung Exynos-M1
Summary

Adds support for the new Exynos-M1 ARMv8-A core.

Diff Detail

Event Timeline

MinSeongKIM updated this revision to Diff 43299.Dec 19 2015, 12:13 AM
MinSeongKIM retitled this revision from to TEMP2.
MinSeongKIM updated this object.
MinSeongKIM changed the visibility from "Public (No Login Required)" to "MinSeongKIM (MinSeong Kim)".
MinSeongKIM changed the edit policy from "All Users" to "MinSeongKIM (MinSeong Kim)".
MinSeongKIM retitled this revision from TEMP2 to Teaches clang about Exynos-M1.Dec 21 2015, 3:29 AM
MinSeongKIM updated this object.
MinSeongKIM added reviewers: aemerson, rengolin, christof.
MinSeongKIM changed the visibility from "MinSeongKIM (MinSeong Kim)" to "Public (No Login Required)".
MinSeongKIM changed the edit policy from "MinSeongKIM (MinSeong Kim)" to "All Users".
MinSeongKIM added a subscriber: cfe-commits.
MinSeongKIM updated this revision to Diff 43354.Dec 21 2015, 3:32 AM

Code rewritten

Herald added a subscriber: aemerson. · View Herald TranscriptDec 21 2015, 3:32 AM
christof edited edge metadata.Dec 21 2015, 6:55 AM

LGTM. But since this is my first review, I would like somebody else to sign off on this as well.

rengolin accepted this revision.Dec 21 2015, 8:39 AM
rengolin edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2015, 8:39 AM
t.p.northover accepted this revision.Dec 21 2015, 9:24 AM
t.p.northover added a reviewer: t.p.northover.
t.p.northover added a subscriber: t.p.northover.

Looks fine to me too. Thanks!

Tim.

Closed by commit rL256829: [AArch64] Teaches clang about Samsung Exynos-M1 (authored by MinSeongKIM). · Explain WhyJan 5 2016, 4:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Basic/
3 lines
Driver/
2 lines

Diff 43299

lib/Basic/Targets.cpp

Context not available.
.Cases("cortex-a53", "cortex-a57", "cortex-a72", "cortex-a35", true) .Cases("cortex-a53", "cortex-a57", "cortex-a72",
"cortex-a35", "exynos-m1", true)
Context not available.

lib/Driver/Tools.cpp

Context not available.
CPU == "cortex-a72" || CPU == "cortex-a35") { CPU == "cortex-a72" || CPU == "cortex-a35" || CPU == "exynos-m1") {
Context not available.