This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Improve foldOpIntoPhi() to use isImpliedCondition tests
ClosedPublic

Authored by kitaisreal on Jul 30 2023, 8:04 AM.

Diff Detail

Unit TestsFailed

Event Timeline

kitaisreal created this revision.Jul 30 2023, 8:04 AM
kitaisreal requested review of this revision.Jul 30 2023, 8:04 AM

Updated tests.

Updated tests.

nikic added inline comments.Jul 31 2023, 11:28 AM
llvm/test/Transforms/InstCombine/phi.ll
1703

Please run these tests through -passes=instnamer to get rid of the unnamed variables.

1778

This is really sub_is_not_zero.

1876

I think you can omit the _2, _3, _4 variants of this test. They're already checked for _eq, and we don't need to repeat all variants every time.

2034

sub_is_not_zero

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2023, 2:16 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.