This is an archive of the discontinued LLVM Phabricator instance.

Differential D156619

[InstCombine] Improve foldOpIntoPhi() to use isImpliedCondition tests
ClosedPublic

Authored by kitaisreal on Jul 30 2023, 8:04 AM.

Details

Reviewers
nikic
goldstein.w.n
Commits
rG2c4e1df9a14c: [InstCombine] Improve foldOpIntoPhi() to use isImpliedCondition tests
Summary

Precommit tests for D156620.

Diff Detail

Event Timeline

kitaisreal created this revision.Jul 30 2023, 8:04 AM
Herald added a subscriber: StephenFan. · View Herald TranscriptJul 30 2023, 8:04 AM
kitaisreal requested review of this revision.Jul 30 2023, 8:04 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptJul 30 2023, 8:04 AM
kitaisreal added a child revision: D156620: [InstCombine] Improve foldOpIntoPhi() to use isImpliedCondition.Jul 30 2023, 8:14 AM
kitaisreal edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B249054: Diff 545443.Jul 30 2023, 8:52 AM
kitaisreal updated this revision to Diff 545460.Jul 30 2023, 11:43 AM

Updated tests.

Harbormaster completed remote builds in B249069: Diff 545460.Jul 30 2023, 12:34 PM
kitaisreal updated this revision to Diff 545725.Jul 31 2023, 10:01 AM

Updated tests.

nikic added inline comments.Jul 31 2023, 11:28 AM
llvm/test/Transforms/InstCombine/phi.ll
1703

Please run these tests through -passes=instnamer to get rid of the unnamed variables.

1778

This is really sub_is_not_zero.

1876

I think you can omit the _2, _3, _4 variants of this test. They're already checked for _eq, and we don't need to repeat all variants every time.

2034

sub_is_not_zero

Harbormaster completed remote builds in B249262: Diff 545725.Jul 31 2023, 11:53 AM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2023, 2:16 AM
This revision was landed with ongoing or failed builds.
Closed by commit rG2c4e1df9a14c: [InstCombine] Improve foldOpIntoPhi() to use isImpliedCondition tests (authored by kitaisreal). · Explain Why
This revision was automatically updated to reflect the committed changes.
kitaisreal added a commit: rG2c4e1df9a14c: [InstCombine] Improve foldOpIntoPhi() to use isImpliedCondition tests.

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
665 lines

Diff 545970

llvm/test/Transforms/InstCombine/phi.ll

Show First 20 Lines • Show All 1,660 Lines • ▼ Show 20 Linesif.then:
br label %if.end br label %if.end
if.end: if.end:
%x = phi i32 [ 0, %if.then ], [ %j, %entry ] %x = phi i32 [ 0, %if.then ], [ %j, %entry ]
%y = phi i32 [ %i, %if.then ], [ 0, %entry ] %y = phi i32 [ %i, %if.then ], [ 0, %entry ]
%add = sub i32 %y, %x %add = sub i32 %y, %x
ret i32 %add ret i32 %add
} }
define i1 @cmp_eq_phi_node_can_fold_1(ptr %C) {
; CHECK-LABEL: @cmp_eq_phi_node_can_fold_1(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = zext i8 [[TMP1]] to i32
; CHECK-NEXT: [[TMP3:%.*]] = add nsw i32 [[TMP2]], -48
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[TMP3]], 0
; CHECK-NEXT: br i1 [[TMP4]], label [[SUB_IS_ZERO:%.*]], label [[JOIN:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 1
; CHECK-NEXT: [[TMP6:%.*]] = load i8, ptr [[TMP5]], align 1
; CHECK-NEXT: [[TMP7:%.*]] = zext i8 [[TMP6]] to i32
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: [[TMP8:%.*]] = phi i32 [ [[TMP3]], [[TMP0:%.*]] ], [ [[TMP7]], [[SUB_IS_ZERO]] ]
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[TMP8]], 0
; CHECK-NEXT: ret i1 [[CMP]]
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %sub_is_zero, label %join
sub_is_zero:
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
br label %join
join:
%8 = phi i32 [ %3, %0 ], [ %7, %sub_is_zero ]
%cmp = icmp eq i32 %8, 0
ret i1 %cmp
}
nikicUnsubmitted
Not Done
ReplyInline Actions

Please run these tests through -passes=instnamer to get rid of the unnamed variables.

nikic: Please run these tests through `-passes=instnamer` to get rid of the unnamed variables.
define i1 @cmp_eq_phi_node_can_fold_2(ptr %C) {
; CHECK-LABEL: @cmp_eq_phi_node_can_fold_2(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = zext i8 [[TMP1]] to i32
; CHECK-NEXT: [[TMP3:%.*]] = add nsw i32 [[TMP2]], -48
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[TMP3]], 0
; CHECK-NEXT: br i1 [[TMP4]], label [[SUB_IS_ZERO:%.*]], label [[JOIN:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 1
; CHECK-NEXT: [[TMP6:%.*]] = load i8, ptr [[TMP5]], align 1
; CHECK-NEXT: [[TMP7:%.*]] = zext i8 [[TMP6]] to i32
; CHECK-NEXT: [[TMP8:%.*]] = add nsw i32 [[TMP7]], -49
; CHECK-NEXT: [[TMP9:%.*]] = icmp eq i32 [[TMP8]], 0
; CHECK-NEXT: br i1 [[TMP9]], label [[SUB_IS_ZERO1:%.*]], label [[JOIN]]
; CHECK: sub_is_zero1:
; CHECK-NEXT: [[TMP10:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 2
; CHECK-NEXT: [[TMP11:%.*]] = load i8, ptr [[TMP10]], align 1
; CHECK-NEXT: [[TMP12:%.*]] = zext i8 [[TMP11]] to i32
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: [[TMP13:%.*]] = phi i32 [ [[TMP3]], [[TMP0:%.*]] ], [ [[TMP8]], [[SUB_IS_ZERO]] ], [ [[TMP12]], [[SUB_IS_ZERO1]] ]
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[TMP13]], 0
; CHECK-NEXT: ret i1 [[CMP]]
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %sub_is_zero, label %join
sub_is_zero:
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
%8 = sub nsw i32 %7, 49
%9 = icmp eq i32 %8, 0
br i1 %9, label %sub_is_zero1, label %join
sub_is_zero1:
%10 = getelementptr inbounds i8, ptr %C, i64 2
%11 = load i8, ptr %10, align 1
%12 = zext i8 %11 to i32
br label %join
join:
%13 = phi i32 [ %3, %0 ], [ %8, %sub_is_zero ], [ %12, %sub_is_zero1 ]
%cmp = icmp eq i32 %13, 0
ret i1 %cmp
}
define i1 @cmp_eq_phi_node_can_fold_3(ptr %C) {
; CHECK-LABEL: @cmp_eq_phi_node_can_fold_3(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = zext i8 [[TMP1]] to i32
; CHECK-NEXT: [[TMP3:%.*]] = add nsw i32 [[TMP2]], -48
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[TMP3]], 0
; CHECK-NEXT: br i1 [[TMP4]], label [[JOIN:%.*]], label [[SUB_IS_ZERO:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 1
; CHECK-NEXT: [[TMP6:%.*]] = load i8, ptr [[TMP5]], align 1
; CHECK-NEXT: [[TMP7:%.*]] = zext i8 [[TMP6]] to i32
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: [[TMP8:%.*]] = phi i32 [ [[TMP3]], [[TMP0:%.*]] ], [ [[TMP7]], [[SUB_IS_ZERO]] ]
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[TMP8]], 0
; CHECK-NEXT: ret i1 [[CMP]]
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %join, label %sub_is_zero
sub_is_zero:
nikicUnsubmitted
Not Done
ReplyInline Actions

This is really sub_is_not_zero.

nikic: This is really sub_is_not_zero.
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
br label %join
join:
%8 = phi i32 [ %3, %0 ], [ %7, %sub_is_zero ]
%cmp = icmp eq i32 %8, 0
ret i1 %cmp
}
define i1 @cmp_eq_phi_node_can_fold_4(ptr %C) {
; CHECK-LABEL: @cmp_eq_phi_node_can_fold_4(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = zext i8 [[TMP1]] to i32
; CHECK-NEXT: [[TMP3:%.*]] = add nsw i32 [[TMP2]], -48
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[TMP3]], 0
; CHECK-NEXT: br i1 [[TMP4]], label [[JOIN:%.*]], label [[SUB_IS_ZERO:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 1
; CHECK-NEXT: [[TMP6:%.*]] = load i8, ptr [[TMP5]], align 1
; CHECK-NEXT: [[TMP7:%.*]] = zext i8 [[TMP6]] to i32
; CHECK-NEXT: [[TMP8:%.*]] = add nsw i32 [[TMP7]], -49
; CHECK-NEXT: [[TMP9:%.*]] = icmp eq i32 [[TMP8]], 0
; CHECK-NEXT: br i1 [[TMP9]], label [[JOIN]], label [[SUB_IS_ZERO1:%.*]]
; CHECK: sub_is_zero1:
; CHECK-NEXT: [[TMP10:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 2
; CHECK-NEXT: [[TMP11:%.*]] = load i8, ptr [[TMP10]], align 1
; CHECK-NEXT: [[TMP12:%.*]] = zext i8 [[TMP11]] to i32
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: [[TMP13:%.*]] = phi i32 [ [[TMP3]], [[TMP0:%.*]] ], [ [[TMP8]], [[SUB_IS_ZERO]] ], [ [[TMP12]], [[SUB_IS_ZERO1]] ]
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[TMP13]], 0
; CHECK-NEXT: ret i1 [[CMP]]
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %join, label %sub_is_zero
sub_is_zero:
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
%8 = sub nsw i32 %7, 49
%9 = icmp eq i32 %8, 0
br i1 %9, label %join, label %sub_is_zero1
sub_is_zero1:
%10 = getelementptr inbounds i8, ptr %C, i64 2
%11 = load i8, ptr %10, align 1
%12 = zext i8 %11 to i32
br label %join
join:
%13 = phi i32 [ %3, %0 ], [ %8, %sub_is_zero ], [ %12, %sub_is_zero1 ]
%cmp = icmp eq i32 %13, 0
ret i1 %cmp
}
define i1 @cmp_ne_phi_node_can_fold_1(ptr %C) {
; CHECK-LABEL: @cmp_ne_phi_node_can_fold_1(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = zext i8 [[TMP1]] to i32
; CHECK-NEXT: [[TMP3:%.*]] = add nsw i32 [[TMP2]], -48
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[TMP3]], 0
; CHECK-NEXT: br i1 [[TMP4]], label [[SUB_IS_ZERO:%.*]], label [[JOIN:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 1
; CHECK-NEXT: [[TMP6:%.*]] = load i8, ptr [[TMP5]], align 1
; CHECK-NEXT: [[TMP7:%.*]] = zext i8 [[TMP6]] to i32
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: [[TMP8:%.*]] = phi i32 [ [[TMP3]], [[TMP0:%.*]] ], [ [[TMP7]], [[SUB_IS_ZERO]] ]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[TMP8]], 0
; CHECK-NEXT: ret i1 [[CMP]]
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %sub_is_zero, label %join
sub_is_zero:
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
br label %join
join:
%8 = phi i32 [ %3, %0 ], [ %7, %sub_is_zero ]
%cmp = icmp ne i32 %8, 0
ret i1 %cmp
}
define i1 @cmp_ne_phi_node_can_fold_2(ptr %C) {
nikicUnsubmitted
Not Done
ReplyInline Actions

I think you can omit the _2, _3, _4 variants of this test. They're already checked for _eq, and we don't need to repeat all variants every time.

nikic: I think you can omit the _2, _3, _4 variants of this test. They're already checked for _eq, and…
; CHECK-LABEL: @cmp_ne_phi_node_can_fold_2(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = zext i8 [[TMP1]] to i32
; CHECK-NEXT: [[TMP3:%.*]] = add nsw i32 [[TMP2]], -48
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[TMP3]], 0
; CHECK-NEXT: br i1 [[TMP4]], label [[SUB_IS_ZERO:%.*]], label [[JOIN:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 1
; CHECK-NEXT: [[TMP6:%.*]] = load i8, ptr [[TMP5]], align 1
; CHECK-NEXT: [[TMP7:%.*]] = zext i8 [[TMP6]] to i32
; CHECK-NEXT: [[TMP8:%.*]] = add nsw i32 [[TMP7]], -49
; CHECK-NEXT: [[TMP9:%.*]] = icmp eq i32 [[TMP8]], 0
; CHECK-NEXT: br i1 [[TMP9]], label [[SUB_IS_ZERO1:%.*]], label [[JOIN]]
; CHECK: sub_is_zero1:
; CHECK-NEXT: [[TMP10:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 2
; CHECK-NEXT: [[TMP11:%.*]] = load i8, ptr [[TMP10]], align 1
; CHECK-NEXT: [[TMP12:%.*]] = zext i8 [[TMP11]] to i32
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: [[TMP13:%.*]] = phi i32 [ [[TMP3]], [[TMP0:%.*]] ], [ [[TMP8]], [[SUB_IS_ZERO]] ], [ [[TMP12]], [[SUB_IS_ZERO1]] ]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[TMP13]], 0
; CHECK-NEXT: ret i1 [[CMP]]
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %sub_is_zero, label %join
sub_is_zero: ; preds = %0
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
%8 = sub nsw i32 %7, 49
%9 = icmp eq i32 %8, 0
br i1 %9, label %sub_is_zero1, label %join
sub_is_zero1:
%10 = getelementptr inbounds i8, ptr %C, i64 2
%11 = load i8, ptr %10, align 1
%12 = zext i8 %11 to i32
br label %join
join:
%13 = phi i32 [ %3, %0 ], [ %8, %sub_is_zero ], [ %12, %sub_is_zero1 ]
%cmp = icmp ne i32 %13, 0
ret i1 %cmp
}
define i1 @cmp_ne_phi_node_can_fold_3(ptr %C) {
; CHECK-LABEL: @cmp_ne_phi_node_can_fold_3(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = zext i8 [[TMP1]] to i32
; CHECK-NEXT: [[TMP3:%.*]] = add nsw i32 [[TMP2]], -48
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[TMP3]], 0
; CHECK-NEXT: br i1 [[TMP4]], label [[JOIN:%.*]], label [[SUB_IS_ZERO:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 1
; CHECK-NEXT: [[TMP6:%.*]] = load i8, ptr [[TMP5]], align 1
; CHECK-NEXT: [[TMP7:%.*]] = zext i8 [[TMP6]] to i32
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: [[TMP8:%.*]] = phi i32 [ [[TMP3]], [[TMP0:%.*]] ], [ [[TMP7]], [[SUB_IS_ZERO]] ]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[TMP8]], 0
; CHECK-NEXT: ret i1 [[CMP]]
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %join, label %sub_is_zero
sub_is_zero:
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
br label %join
join:
%8 = phi i32 [ %3, %0 ], [ %7, %sub_is_zero ]
%cmp = icmp ne i32 %8, 0
ret i1 %cmp
}
define i1 @cmp_ne_phi_node_can_fold_4(ptr %C) {
; CHECK-LABEL: @cmp_ne_phi_node_can_fold_4(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = zext i8 [[TMP1]] to i32
; CHECK-NEXT: [[TMP3:%.*]] = add nsw i32 [[TMP2]], -48
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[TMP3]], 0
; CHECK-NEXT: br i1 [[TMP4]], label [[JOIN:%.*]], label [[SUB_IS_ZERO:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 1
; CHECK-NEXT: [[TMP6:%.*]] = load i8, ptr [[TMP5]], align 1
; CHECK-NEXT: [[TMP7:%.*]] = zext i8 [[TMP6]] to i32
; CHECK-NEXT: [[TMP8:%.*]] = add nsw i32 [[TMP7]], -49
; CHECK-NEXT: [[TMP9:%.*]] = icmp eq i32 [[TMP8]], 0
; CHECK-NEXT: br i1 [[TMP9]], label [[JOIN]], label [[SUB_IS_ZERO1:%.*]]
; CHECK: sub_is_zero1:
; CHECK-NEXT: [[TMP10:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 2
; CHECK-NEXT: [[TMP11:%.*]] = load i8, ptr [[TMP10]], align 1
; CHECK-NEXT: [[TMP12:%.*]] = zext i8 [[TMP11]] to i32
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: [[TMP13:%.*]] = phi i32 [ [[TMP3]], [[TMP0:%.*]] ], [ [[TMP8]], [[SUB_IS_ZERO]] ], [ [[TMP12]], [[SUB_IS_ZERO1]] ]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[TMP13]], 0
; CHECK-NEXT: ret i1 [[CMP]]
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %join, label %sub_is_zero
sub_is_zero: ; preds = %0
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
%8 = sub nsw i32 %7, 49
%9 = icmp eq i32 %8, 0
br i1 %9, label %join, label %sub_is_zero1
sub_is_zero1:
%10 = getelementptr inbounds i8, ptr %C, i64 2
%11 = load i8, ptr %10, align 1
%12 = zext i8 %11 to i32
br label %join
join:
%13 = phi i32 [ %3, %0 ], [ %8, %sub_is_zero ], [ %12, %sub_is_zero1 ]
%cmp = icmp ne i32 %13, 0
ret i1 %cmp
}
define i1 @cmp_sgt_phi_node_can_fold_1(ptr %C) {
; CHECK-LABEL: @cmp_sgt_phi_node_can_fold_1(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = zext i8 [[TMP1]] to i32
; CHECK-NEXT: [[TMP3:%.*]] = add nsw i32 [[TMP2]], -48
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[TMP3]], 0
; CHECK-NEXT: br i1 [[TMP4]], label [[JOIN:%.*]], label [[SUB_IS_ZERO:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 1
; CHECK-NEXT: [[TMP6:%.*]] = load i8, ptr [[TMP5]], align 1
; CHECK-NEXT: [[TMP7:%.*]] = zext i8 [[TMP6]] to i32
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: [[TMP8:%.*]] = phi i32 [ [[TMP3]], [[TMP0:%.*]] ], [ [[TMP7]], [[SUB_IS_ZERO]] ]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[TMP8]], 0
; CHECK-NEXT: ret i1 [[CMP]]
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %join, label %sub_is_zero
sub_is_zero:
nikicUnsubmitted
Not Done
ReplyInline Actions

sub_is_not_zero

nikic: sub_is_not_zero
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
br label %join
join:
%8 = phi i32 [ %3, %0 ], [ %7, %sub_is_zero ]
%cmp = icmp sgt i32 %8, 0
ret i1 %cmp
}
define i1 @cmp_sgt_phi_node_can_fold_2(ptr %C) {
; CHECK-LABEL: @cmp_sgt_phi_node_can_fold_2(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = zext i8 [[TMP1]] to i32
; CHECK-NEXT: [[TMP3:%.*]] = add nsw i32 [[TMP2]], -48
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[TMP3]], 0
; CHECK-NEXT: br i1 [[TMP4]], label [[JOIN:%.*]], label [[SUB_IS_ZERO:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 1
; CHECK-NEXT: [[TMP6:%.*]] = load i8, ptr [[TMP5]], align 1
; CHECK-NEXT: [[TMP7:%.*]] = zext i8 [[TMP6]] to i32
; CHECK-NEXT: [[TMP8:%.*]] = add nsw i32 [[TMP7]], -49
; CHECK-NEXT: [[TMP9:%.*]] = icmp eq i32 [[TMP8]], 0
; CHECK-NEXT: br i1 [[TMP9]], label [[JOIN]], label [[SUB_IS_ZERO1:%.*]]
; CHECK: sub_is_zero1:
; CHECK-NEXT: [[TMP10:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 2
; CHECK-NEXT: [[TMP11:%.*]] = load i8, ptr [[TMP10]], align 1
; CHECK-NEXT: [[TMP12:%.*]] = zext i8 [[TMP11]] to i32
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: [[TMP13:%.*]] = phi i32 [ [[TMP3]], [[TMP0:%.*]] ], [ [[TMP8]], [[SUB_IS_ZERO]] ], [ [[TMP12]], [[SUB_IS_ZERO1]] ]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[TMP13]], 0
; CHECK-NEXT: ret i1 [[CMP]]
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %join, label %sub_is_zero
sub_is_zero:
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
%8 = sub nsw i32 %7, 49
%9 = icmp eq i32 %8, 0
br i1 %9, label %join, label %sub_is_zero1
sub_is_zero1:
%10 = getelementptr inbounds i8, ptr %C, i64 2
%11 = load i8, ptr %10, align 1
%12 = zext i8 %11 to i32
br label %join
join:
%13 = phi i32 [ %3, %0 ], [ %8, %sub_is_zero ], [ %12, %sub_is_zero1 ]
%cmp = icmp sgt i32 %13, 0
ret i1 %cmp
}
define i1 @cmp_sgt_phi_node_cant_fold_1(ptr %C) {
; CHECK-LABEL: @cmp_sgt_phi_node_cant_fold_1(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = zext i8 [[TMP1]] to i32
; CHECK-NEXT: [[TMP3:%.*]] = add nsw i32 [[TMP2]], -48
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[TMP3]], 0
; CHECK-NEXT: br i1 [[TMP4]], label [[SUB_IS_ZERO:%.*]], label [[JOIN:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 1
; CHECK-NEXT: [[TMP6:%.*]] = load i8, ptr [[TMP5]], align 1
; CHECK-NEXT: [[TMP7:%.*]] = zext i8 [[TMP6]] to i32
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: [[TMP8:%.*]] = phi i32 [ [[TMP3]], [[TMP0:%.*]] ], [ [[TMP7]], [[SUB_IS_ZERO]] ]
; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i32 [[TMP8]], 0
; CHECK-NEXT: ret i1 [[CMP]]
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %sub_is_zero, label %join
sub_is_zero:
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
br label %join
join:
%8 = phi i32 [ %3, %0 ], [ %7, %sub_is_zero ]
%cmp = icmp sgt i32 %8, 0
ret i1 %cmp
}
define i1 @cmp_sgt_phi_node_cant_fold_2(ptr %C) {
; CHECK-LABEL: @cmp_sgt_phi_node_cant_fold_2(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = zext i8 [[TMP1]] to i32
; CHECK-NEXT: [[TMP3:%.*]] = add nsw i32 [[TMP2]], -48
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[TMP3]], 0
; CHECK-NEXT: br i1 [[TMP4]], label [[SUB_IS_ZERO:%.*]], label [[JOIN:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 1
; CHECK-NEXT: [[TMP6:%.*]] = load i8, ptr [[TMP5]], align 1
; CHECK-NEXT: [[TMP7:%.*]] = zext i8 [[TMP6]] to i32
; CHECK-NEXT: [[TMP8:%.*]] = add nsw i32 [[TMP7]], -49
; CHECK-NEXT: [[TMP9:%.*]] = icmp eq i32 [[TMP8]], 0
; CHECK-NEXT: br i1 [[TMP9]], label [[SUB_IS_ZERO1:%.*]], label [[JOIN]]
; CHECK: sub_is_zero1:
; CHECK-NEXT: [[TMP10:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 2
; CHECK-NEXT: [[TMP11:%.*]] = load i8, ptr [[TMP10]], align 1
; CHECK-NEXT: [[TMP12:%.*]] = zext i8 [[TMP11]] to i32
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: [[TMP13:%.*]] = phi i32 [ [[TMP3]], [[TMP0:%.*]] ], [ [[TMP8]], [[SUB_IS_ZERO]] ], [ [[TMP12]], [[SUB_IS_ZERO1]] ]
; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i32 [[TMP13]], 0
; CHECK-NEXT: ret i1 [[CMP]]
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %sub_is_zero, label %join
sub_is_zero:
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
%8 = sub nsw i32 %7, 49
%9 = icmp eq i32 %8, 0
br i1 %9, label %sub_is_zero1, label %join
sub_is_zero1:
%10 = getelementptr inbounds i8, ptr %C, i64 2
%11 = load i8, ptr %10, align 1
%12 = zext i8 %11 to i32
br label %join
join:
%13 = phi i32 [ %3, %0 ], [ %8, %sub_is_zero ], [ %12, %sub_is_zero1 ]
%cmp = icmp sgt i32 %13, 0
ret i1 %cmp
}
define i1 @cmp_slt_phi_node_can_fold_1(ptr %C) {
; CHECK-LABEL: @cmp_slt_phi_node_can_fold_1(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = icmp eq i8 [[TMP1]], 48
; CHECK-NEXT: br i1 [[TMP2]], label [[JOIN:%.*]], label [[SUB_IS_ZERO:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: ret i1 false
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %join, label %sub_is_zero
sub_is_zero:
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
br label %join
join:
%8 = phi i32 [ %3, %0 ], [ %7, %sub_is_zero ]
%cmp = icmp slt i32 %8, 0
ret i1 %cmp
}
define i1 @cmp_slt_phi_node_can_fold_2(ptr %C) {
; CHECK-LABEL: @cmp_slt_phi_node_can_fold_2(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = icmp eq i8 [[TMP1]], 48
; CHECK-NEXT: br i1 [[TMP2]], label [[JOIN:%.*]], label [[SUB_IS_ZERO:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: [[TMP3:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 1
; CHECK-NEXT: [[TMP4:%.*]] = load i8, ptr [[TMP3]], align 1
; CHECK-NEXT: [[TMP5:%.*]] = icmp eq i8 [[TMP4]], 49
; CHECK-NEXT: br i1 [[TMP5]], label [[JOIN]], label [[SUB_IS_ZERO1:%.*]]
; CHECK: sub_is_zero1:
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: ret i1 false
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %join, label %sub_is_zero
sub_is_zero:
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
%8 = sub nsw i32 %7, 49
%9 = icmp eq i32 %8, 0
br i1 %9, label %join, label %sub_is_zero1
sub_is_zero1:
%10 = getelementptr inbounds i8, ptr %C, i64 2
%11 = load i8, ptr %10, align 1
%12 = zext i8 %11 to i32
br label %join
join:
%13 = phi i32 [ %3, %0 ], [ %8, %sub_is_zero ], [ %12, %sub_is_zero1 ]
%cmp = icmp slt i32 %13, 0
ret i1 %cmp
}
define i1 @cmp_slt_phi_node_cant_fold_1(ptr %C) {
; CHECK-LABEL: @cmp_slt_phi_node_cant_fold_1(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = zext i8 [[TMP1]] to i32
; CHECK-NEXT: [[TMP3:%.*]] = add nsw i32 [[TMP2]], -48
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[TMP3]], 0
; CHECK-NEXT: br i1 [[TMP4]], label [[SUB_IS_ZERO:%.*]], label [[JOIN:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 1
; CHECK-NEXT: [[TMP6:%.*]] = load i8, ptr [[TMP5]], align 1
; CHECK-NEXT: [[TMP7:%.*]] = zext i8 [[TMP6]] to i32
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: [[TMP8:%.*]] = phi i32 [ [[TMP3]], [[TMP0:%.*]] ], [ [[TMP7]], [[SUB_IS_ZERO]] ]
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i32 [[TMP8]], 0
; CHECK-NEXT: ret i1 [[CMP]]
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %sub_is_zero, label %join
sub_is_zero:
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
br label %join
join:
%8 = phi i32 [ %3, %0 ], [ %7, %sub_is_zero ]
%cmp = icmp slt i32 %8, 0
ret i1 %cmp
}
define i1 @cmp_slt_phi_node_cant_fold_2(ptr %C) {
; CHECK-LABEL: @cmp_slt_phi_node_cant_fold_2(
; CHECK-NEXT: [[TMP1:%.*]] = load i8, ptr [[C:%.*]], align 1
; CHECK-NEXT: [[TMP2:%.*]] = zext i8 [[TMP1]] to i32
; CHECK-NEXT: [[TMP3:%.*]] = add nsw i32 [[TMP2]], -48
; CHECK-NEXT: [[TMP4:%.*]] = icmp eq i32 [[TMP3]], 0
; CHECK-NEXT: br i1 [[TMP4]], label [[SUB_IS_ZERO:%.*]], label [[JOIN:%.*]]
; CHECK: sub_is_zero:
; CHECK-NEXT: [[TMP5:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 1
; CHECK-NEXT: [[TMP6:%.*]] = load i8, ptr [[TMP5]], align 1
; CHECK-NEXT: [[TMP7:%.*]] = zext i8 [[TMP6]] to i32
; CHECK-NEXT: [[TMP8:%.*]] = add nsw i32 [[TMP7]], -49
; CHECK-NEXT: [[TMP9:%.*]] = icmp eq i32 [[TMP8]], 0
; CHECK-NEXT: br i1 [[TMP9]], label [[SUB_IS_ZERO1:%.*]], label [[JOIN]]
; CHECK: sub_is_zero1:
; CHECK-NEXT: [[TMP10:%.*]] = getelementptr inbounds i8, ptr [[C]], i64 2
; CHECK-NEXT: [[TMP11:%.*]] = load i8, ptr [[TMP10]], align 1
; CHECK-NEXT: [[TMP12:%.*]] = zext i8 [[TMP11]] to i32
; CHECK-NEXT: br label [[JOIN]]
; CHECK: join:
; CHECK-NEXT: [[TMP13:%.*]] = phi i32 [ [[TMP3]], [[TMP0:%.*]] ], [ [[TMP8]], [[SUB_IS_ZERO]] ], [ [[TMP12]], [[SUB_IS_ZERO1]] ]
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i32 [[TMP13]], 0
; CHECK-NEXT: ret i1 [[CMP]]
;
%1 = load i8, ptr %C, align 1
%2 = zext i8 %1 to i32
%3 = sub nsw i32 %2, 48
%4 = icmp eq i32 %3, 0
br i1 %4, label %sub_is_zero, label %join
sub_is_zero:
%5 = getelementptr inbounds i8, ptr %C, i64 1
%6 = load i8, ptr %5, align 1
%7 = zext i8 %6 to i32
%8 = sub nsw i32 %7, 49
%9 = icmp eq i32 %8, 0
br i1 %9, label %sub_is_zero1, label %join
sub_is_zero1:
%10 = getelementptr inbounds i8, ptr %C, i64 2
%11 = load i8, ptr %10, align 1
%12 = zext i8 %11 to i32
br label %join
join:
%13 = phi i32 [ %3, %0 ], [ %8, %sub_is_zero ], [ %12, %sub_is_zero1 ]
%cmp = icmp slt i32 %13, 0
ret i1 %cmp
}