[lldb] Fix test TestBSDArchives.py properly

[kusmour]

Summary

The previous patch D156367 introduced a test debugging thin archive with one of the linked object file missing. It actually failed on green dragon build bots. I put up a speculative fix (https://github.com/llvm/llvm-project/commit/4520cc066b2ffe5ac261e3aca887cba3f113b1ff) that only fixed the symptom of it.

The actual root cause was that the timestamps were set to 0 when creating the thin archive
Makefile command

llvm-ar -rcsDT libfoo-thin.a a.o b.o

Where the flag "[D] - use zero for timestamps and uids/gids (default)" according to the llvm-ar help
Use "[U] - use actual timestamps and uids/gids" fixed the timestamp

Now the test is actually getting error from missing object file linked to the thin archive instead of the mismatched timestamp.
This means removing one of the object file a.o should only result in failure breaking at a(); breaking at b() should work just fine.

Test Plan:

All 4 test cases passed

▶ ./bin/llvm-lit -vv ../llvm-project/lldb/test/API/functionalities/archives/TestBSDArchives.py
llvm-lit: /Users/wanyi/local/llvm-project/lldb/test/API/lit.cfg.py:173: warning: Could not set a default per-test timeout. Requires the Python psutil module but it could not be found. Try installing it via pip or via your operating system's package manager.
-- Testing: 1 tests, 1 workers --
PASS: lldb-api :: functionalities/archives/TestBSDArchives.py (1 of 1)

Testing Time: 8.07s
  Passed: 1

1 warning(s) in tests

[bulbazord]

Makes sense to me. Thanks for looking into this!

lldb/test/API/functionalities/archives/Makefile

 # This tests whether lldb can load a thin archive
 libbar.a: c.o
   $(eval LLVM_AR := $(LLVM_TOOLS_DIR)/llvm-ar)
   $(eval LLVM_ARFLAGS := -rcsDT)
   $(LLVM_AR) $(LLVM_ARFLAGS) $@ $^
 
 libfoo-thin.a: a.o b.o
   $(eval LLVM_AR := $(LLVM_TOOLS_DIR)/llvm-ar)
-  $(eval LLVM_ARFLAGS := -rcsDT)
+  $(eval LLVM_ARFLAGS := -rcsUT)
   $(LLVM_AR) $(LLVM_ARFLAGS) $@ $^
 
 include Makefile.rules

lldb/test/API/functionalities/archives/TestBSDArchives.py

def test_frame_var_errors_when_thin_archive_malformed(self):
             self, "a", bkpt_module=exe
         )
         error_strings = [
             '"a.o" object from the "',
             "libfoo.a\" archive: either the .o file doesn't exist in the archive or the modification time (0x",
             ") of the .o file doesn't match",
         ]
         self.check_frame_variable_errors(thread, error_strings)
         
+        # Break at b() should succeed
+        (target, process, thread, bkpt) = lldbutil.run_to_name_breakpoint(
+            self, "b", bkpt_module=exe
+        )
+        self.expect(
+            "thread list",
+            STOPPED_DUE_TO_BREAKPOINT,
+            substrs=["stopped", "stop reason = breakpoint"],
+        )
+        self.expect(
+            "frame variable", VARIABLES_DISPLAYED_CORRECTLY, substrs=["(int) arg = 2"]
+        )
+
+
     @skipIfRemote
     @skipUnlessDarwin
     def test_frame_var_errors_when_mtime_mistmatch_for_object_in_archive(self):
         """
         Break inside a() and modify the modification time for "a.o" within
         libfoo.a to make sure we can't load the debug information and
         report an appropriate error when doing 'frame variable'.
         """