This is an archive of the discontinued LLVM Phabricator instance.

Fix mapping of @llvm.arm.ssat/usat intrinsics to ssat/usat instructions for Thumb2
ClosedPublic

Authored by weimingz on Dec 18 2015, 1:49 PM.

Details

Summary

r250697 fixed the mapping for ARM mode. We have to do the same for Thumb2 otherwise the same llvm.arm.ssat() will generate different saturating amount for ARM and Thumb.

r250697: http://reviews.llvm.org/rL250697

Diff Detail

Repository
rL LLVM

Event Timeline

weimingz updated this revision to Diff 43263.Dec 18 2015, 1:49 PM
weimingz retitled this revision from to Fix mapping of @llvm.arm.ssat/usat intrinsics to ssat/usat instructions for Thumb2.
weimingz updated this object.
weimingz added a reviewer: rmaprath.
weimingz set the repository for this revision to rL LLVM.
weimingz added a subscriber: llvm-commits.
weimingz updated this object.Dec 18 2015, 2:07 PM
rmaprath edited edge metadata.Dec 19 2015, 12:44 AM

Hi Weiming,

Can you update the related out-of-range tests as well? as in http://reviews.llvm.org/rL250697?

LGTM otherwise.

weimingz updated this revision to Diff 43311.Dec 19 2015, 1:47 PM
weimingz edited edge metadata.

Hi Asiri,

Sure.

rmaprath accepted this revision.Dec 19 2015, 5:46 PM
rmaprath edited edge metadata.

Looks like you've missed usat-lower.ll and usat-upper.ll updates? Please update them before commit. LGTM.

This revision is now accepted and ready to land.Dec 19 2015, 5:46 PM
weimingz updated this revision to Diff 43318.Dec 19 2015, 10:42 PM
weimingz edited edge metadata.

Update tests for usat

weimingz closed this revision.Dec 19 2015, 10:44 PM