This is an archive of the discontinued LLVM Phabricator instance.

Differential D156521

[tests] precommit tests for D156499
ClosedPublic

Authored by Allen on Jul 28 2023, 4:13 AM.

Details

Reviewers
goldstein.w.n
nikic
Commits
rGb9a8bec05c31: [tests] precommit tests for D156499

Diff Detail

Unit TestsFailed

TimeTest
60,050 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

Allen created this revision.Jul 28 2023, 4:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2023, 4:13 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
Allen requested review of this revision.Jul 28 2023, 4:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2023, 4:13 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Allen mentioned this in D156499: [InstCombine] Fold abs of known sign operand when source is sub.Jul 28 2023, 4:19 AM
Allen added a child revision: D156499: [InstCombine] Fold abs of known sign operand when source is sub.
Harbormaster completed remote builds in B248804: Diff 545094.Jul 28 2023, 4:50 AM
Allen updated this revision to Diff 546680.Aug 2 2023, 8:28 PM

Add 2 new tests

Harbormaster completed remote builds in B249939: Diff 546680.Aug 2 2023, 9:48 PM
Allen updated this revision to Diff 547634.Aug 6 2023, 8:43 PM

Add 2 new tests according https://reviews.llvm.org/D156499#inline-1520465

This revision was not accepted when it landed; it landed in state Needs Review.Aug 6 2023, 9:00 PM
This revision was landed with ongoing or failed builds.
Closed by commit rGb9a8bec05c31: [tests] precommit tests for D156499 (authored by Allen). · Explain Why
This revision was automatically updated to reflect the committed changes.
Allen added a commit: rGb9a8bec05c31: [tests] precommit tests for D156499.
Harbormaster completed remote builds in B250669: Diff 547634.Aug 6 2023, 9:28 PM

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
110 lines

Diff 546680

llvm/test/Transforms/InstCombine/abs-intrinsic.ll

Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines
%0 = call i32 @llvm.abs.i32(i32 %sub, i1 true) %0 = call i32 @llvm.abs.i32(i32 %sub, i1 true)
br label %cond.end br label %cond.end
cond.end: cond.end:
%r = phi i32 [ %0, %cond.true ], [ 0, %entry ] %r = phi i32 [ %0, %cond.true ], [ 0, %entry ]
ret i32 %r ret i32 %r
} }
; https://alive2.llvm.org/ce/z/VSumU5
define i32 @sub_abs_sge(i32 %x, i32 %y) {
; CHECK-LABEL: @sub_abs_sge(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP_NOT:%.*]] = icmp slt i32 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: br i1 [[CMP_NOT]], label [[COND_END:%.*]], label [[COND_TRUE:%.*]]
; CHECK: cond.true:
; CHECK-NEXT: [[SUB:%.*]] = sub nsw i32 [[X]], [[Y]]
; CHECK-NEXT: br label [[COND_END]]
; CHECK: cond.end:
; CHECK-NEXT: [[R:%.*]] = phi i32 [ [[SUB]], [[COND_TRUE]] ], [ 0, [[ENTRY:%.*]] ]
; CHECK-NEXT: ret i32 [[R]]
;
entry:
%cmp = icmp sge i32 %x, %y
br i1 %cmp, label %cond.true, label %cond.end
cond.true:
%sub = sub nsw i32 %x, %y
%0 = call i32 @llvm.abs.i32(i32 %sub, i1 true)
br label %cond.end
cond.end:
%r = phi i32 [ %0, %cond.true ], [ 0, %entry ]
ret i32 %r
}
define i32 @sub_abs_lt(i32 %x, i32 %y) { define i32 @sub_abs_lt(i32 %x, i32 %y) {
; CHECK-LABEL: @sub_abs_lt( ; CHECK-LABEL: @sub_abs_lt(
; CHECK-NEXT: entry: ; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i32 [[X:%.*]], [[Y:%.*]] ; CHECK-NEXT: [[CMP:%.*]] = icmp slt i32 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: br i1 [[CMP]], label [[COND_TRUE:%.*]], label [[COND_END:%.*]] ; CHECK-NEXT: br i1 [[CMP]], label [[COND_TRUE:%.*]], label [[COND_END:%.*]]
; CHECK: cond.true: ; CHECK: cond.true:
; CHECK-NEXT: [[SUB_NEG:%.*]] = sub i32 [[Y]], [[X]] ; CHECK-NEXT: [[SUB_NEG:%.*]] = sub i32 [[Y]], [[X]]
; CHECK-NEXT: br label [[COND_END]] ; CHECK-NEXT: br label [[COND_END]]
Show All 10 Lines
%0 = call i32 @llvm.abs.i32(i32 %sub, i1 true) %0 = call i32 @llvm.abs.i32(i32 %sub, i1 true)
br label %cond.end br label %cond.end
cond.end: cond.end:
%r = phi i32 [ %0, %cond.true ], [ 0, %entry ] %r = phi i32 [ %0, %cond.true ], [ 0, %entry ]
ret i32 %r ret i32 %r
} }
; https://alive2.llvm.org/ce/z/9wQo6G
define i32 @sub_abs_sle(i32 %x, i32 %y) {
; CHECK-LABEL: @sub_abs_sle(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP_NOT:%.*]] = icmp sgt i32 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: br i1 [[CMP_NOT]], label [[COND_END:%.*]], label [[COND_TRUE:%.*]]
; CHECK: cond.true:
; CHECK-NEXT: [[SUB:%.*]] = sub nsw i32 [[X]], [[Y]]
; CHECK-NEXT: [[TMP0:%.*]] = call i32 @llvm.abs.i32(i32 [[SUB]], i1 true)
; CHECK-NEXT: br label [[COND_END]]
; CHECK: cond.end:
; CHECK-NEXT: [[R:%.*]] = phi i32 [ [[TMP0]], [[COND_TRUE]] ], [ 0, [[ENTRY:%.*]] ]
; CHECK-NEXT: ret i32 [[R]]
;
entry:
%cmp = icmp sle i32 %x, %y
br i1 %cmp, label %cond.true, label %cond.end
cond.true:
%sub = sub nsw i32 %x, %y
%0 = call i32 @llvm.abs.i32(i32 %sub, i1 true)
br label %cond.end
cond.end:
%r = phi i32 [ %0, %cond.true ], [ 0, %entry ]
ret i32 %r
}
; https://alive2.llvm.org/ce/z/xlpSO0
define i8 @src_sub_abs_sleF(i8 %x, i8 %y) {
; CHECK-LABEL: @src_sub_abs_sleF(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP_NOT:%.*]] = icmp sgt i8 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: br i1 [[CMP_NOT]], label [[COND_END:%.*]], label [[COND_TRUE:%.*]]
; CHECK: cond.true:
; CHECK-NEXT: [[SUB:%.*]] = sub nsw i8 [[X]], [[Y]]
; CHECK-NEXT: [[TMP0:%.*]] = call i8 @llvm.abs.i8(i8 [[SUB]], i1 false)
; CHECK-NEXT: br label [[COND_END]]
; CHECK: cond.end:
; CHECK-NEXT: [[R:%.*]] = phi i8 [ [[TMP0]], [[COND_TRUE]] ], [ 0, [[ENTRY:%.*]] ]
; CHECK-NEXT: ret i8 [[R]]
;
entry:
%cmp = icmp sle i8 %x, %y
br i1 %cmp, label %cond.true, label %cond.end
cond.true:
%sub = sub nsw i8 %x, %y
%0 = call i8 @llvm.abs.i8(i8 %sub, i1 false)
br label %cond.end
cond.end:
%r = phi i8 [ %0, %cond.true ], [ 0, %entry ]
ret i8 %r
}
define i8 @sub_abs_sleT(i8 %x, i8 %y) {
; CHECK-LABEL: @sub_abs_sleT(
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP_NOT:%.*]] = icmp sgt i8 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: br i1 [[CMP_NOT]], label [[COND_END:%.*]], label [[COND_TRUE:%.*]]
; CHECK: cond.true:
; CHECK-NEXT: [[SUB:%.*]] = sub nsw i8 [[X]], [[Y]]
; CHECK-NEXT: [[TMP0:%.*]] = call i8 @llvm.abs.i8(i8 [[SUB]], i1 true)
; CHECK-NEXT: br label [[COND_END]]
; CHECK: cond.end:
; CHECK-NEXT: [[R:%.*]] = phi i8 [ [[TMP0]], [[COND_TRUE]] ], [ 0, [[ENTRY:%.*]] ]
; CHECK-NEXT: ret i8 [[R]]
;
entry:
%cmp = icmp sle i8 %x, %y
br i1 %cmp, label %cond.true, label %cond.end
cond.true:
%sub = sub nsw i8 %x, %y
%0 = call i8 @llvm.abs.i8(i8 %sub, i1 true)
br label %cond.end
cond.end:
%r = phi i8 [ %0, %cond.true ], [ 0, %entry ]
ret i8 %r
}
define i32 @sub_abs_lt_min_not_poison(i32 %x, i32 %y) { define i32 @sub_abs_lt_min_not_poison(i32 %x, i32 %y) {
; CHECK-LABEL: @sub_abs_lt_min_not_poison( ; CHECK-LABEL: @sub_abs_lt_min_not_poison(
; CHECK-NEXT: entry: ; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i32 [[X:%.*]], [[Y:%.*]] ; CHECK-NEXT: [[CMP:%.*]] = icmp slt i32 [[X:%.*]], [[Y:%.*]]
; CHECK-NEXT: br i1 [[CMP]], label [[COND_TRUE:%.*]], label [[COND_END:%.*]] ; CHECK-NEXT: br i1 [[CMP]], label [[COND_TRUE:%.*]], label [[COND_END:%.*]]
; CHECK: cond.true: ; CHECK: cond.true:
; CHECK-NEXT: [[SUB_NEG:%.*]] = sub i32 [[Y]], [[X]] ; CHECK-NEXT: [[SUB_NEG:%.*]] = sub i32 [[Y]], [[X]]
; CHECK-NEXT: br label [[COND_END]] ; CHECK-NEXT: br label [[COND_END]]
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines