[libc] Fix printf g conversion with high precision

[michaelrj]

Summary

The number of trailing zeroes was being calculated incorrectly. It was
assuming that it could add all of the implicit leading zeroes in the
final block, not accounting for the number of digits actually reqested
by the precision.

libc/src/stdio/printf_core/float_dec_converter.h

LIBC_INLINE int convert_float_dec_auto_typed(Writer *writer,
   auto int_to_str = *IntegerToString::dec(digits, buf);
 
   int implicit_leading_zeroes = BLOCK_SIZE - int_to_str.size();
 
   // if the last block is also the first block, then ignore leading zeroes.
   if (digits_checked == 0) {
     last_block_size = int_to_str.size();
     implicit_leading_zeroes = 0;
-  } else {
-    // If the block is not the maximum size, that means it has leading
-    // zeroes, and zeroes are not nines.
-    if (implicit_leading_zeroes > 0) {
-      trailing_nines = 0;
-    }
-
-    // But leading zeroes are zeroes (that could be trailing).
-    trailing_zeroes += implicit_leading_zeroes;
   }
 
   int digits_requested = (exp_precision + 1) - digits_checked;
 
   int digits_to_check = digits_requested - implicit_leading_zeroes;
   if (digits_to_check < 0) {
     digits_to_check = 0;
   }
 
+  // If the block is not the maximum size, that means it has leading
+  // zeroes, and zeroes are not nines.
+  if (implicit_leading_zeroes > 0) {
+    trailing_nines = 0;
+  }
+
+  // But leading zeroes are zeroes (that could be trailing). We take the
+  // minimum of the leading zeroes and digits requested because if there are
+  // more requested digits than leading zeroes we shouldn't count those.
+  trailing_zeroes +=
+      (implicit_leading_zeroes > digits_requested ? digits_requested
+                                                  : implicit_leading_zeroes);
+
   // Check the upper digits of this block.
   for (int i = 0; i < digits_to_check; ++i) {
     if (int_to_str[i] == '9') {
       ++trailing_nines;
       trailing_zeroes = 0;
     } else if (int_to_str[i] == '0') {
       ++trailing_zeroes;
       trailing_nines = 0;
if (static_cast<int>(init_precision) > base_10_exp && base_10_exp >= -4) {
     FormatSection new_conv = to_conv;
     const size_t conv_precision = init_precision - (base_10_exp + 1);
 
     if ((to_conv.flags & FormatFlags::ALTERNATE_FORM) != 0) {
       new_conv.precision = conv_precision;
     } else {
       // If alt form isn't set, then we need to determine the number of trailing
       // zeroes and set the precision such that they are removed.
+
+      /*
+      Here's a diagram of an example:
+
+      printf("%.15g", 22.25);
+
+                            +--- init_precision = 15
+                            |
+                            +-------------------+
+                            |                   |
+                            |  ++--- trimmed_precision = 2
+                            |  ||               |
+                            22.250000000000000000
+                            ||   |              |
+                            ++   +--------------+
+                             |   |
+       base_10_exp + 1 = 2 --+   +--- trailing_zeroes = 11
+      */
       int trimmed_precision =
           digits_checked - (base_10_exp + 1) - trailing_zeroes;
       if (trimmed_precision < 0) {
         trimmed_precision = 0;
       }
       new_conv.precision =
           (static_cast<size_t>(trimmed_precision) > conv_precision)
               ? conv_precision

libc/test/src/stdio/sprintf_test.cpp

*/
   ASSERT_STREQ_LEN(written, buff, "9999");
 
   written = __llvm_libc::sprintf(buff, "%.3g", 9999.0);
   ASSERT_STREQ_LEN(written, buff, "1e+04");
 
   written = __llvm_libc::sprintf(buff, "%.3g", 1256.0);
   ASSERT_STREQ_LEN(written, buff, "1.26e+03");
 
+  // Found through large scale testing.
+  written = __llvm_libc::sprintf(buff, "%.15g", 22.25);
+  ASSERT_STREQ_LEN(written, buff, "22.25");
+
   // Subnormal Precision Tests
 
   written = __llvm_libc::sprintf(buff, "%.310g", 0x1.0p-1022);
   ASSERT_STREQ_LEN(
       written, buff,
       "2."
       "225073858507201383090232717332404064219215980462331830553327416887204434"
       "813918195854283159012511020564067339731035811005152434161553460108856012"