This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Tests for D156026 (Contracting x^2 + 2*x*y + y^2 to (x + y)^2 (integer))
ClosedPublic

Authored by rainerzufalldererste on Jul 26 2023, 10:09 AM.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2023, 10:09 AM
rainerzufalldererste requested review of this revision.Jul 26 2023, 10:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2023, 10:09 AM
nikic added a comment.Jul 27 2023, 2:02 AM

Not sure if this is what you intended, but since there's been no further response to the other Revision, I'll presume that this is the correct cause of action.

This is right. Can you please rebase https://reviews.llvm.org/D156026 on top of this patch now? It will then only show test diffs relative to this patch.

Any ideas, what these failed UnitTests are about? Adding a bunch of tests to one particular file shouldn't break random other things imo. Or am I missing something?
Or are CodeGen/error-stmt-in-non-affine-region.ll, CodeGen/large-numbers-in-boundary-context.ll or SemaTemplate/instantiate-function-1.mm somehow related to this change?

nikic added a comment.Jul 30 2023, 5:18 AM

Sometimes there are pre-existing failures on the master branch. You can generally ignore any failures that aren't obviously related to your change.

rainerzufalldererste edited the summary of this revision. (Show Details)

Adding more tests for different parameter orders

Just noticed that I accidentally removed the FIXME comments, but since this isn't intended to be committed directly, I guess it's not that big of a deal. Otherwise, please let me know.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 9 2023, 5:13 AM
This revision was automatically updated to reflect the committed changes.