Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Not sure if this is what you intended, but since there's been no further response to the other Revision, I'll presume that this is the correct cause of action.
This is right. Can you please rebase https://reviews.llvm.org/D156026 on top of this patch now? It will then only show test diffs relative to this patch.
Any ideas, what these failed UnitTests are about? Adding a bunch of tests to one particular file shouldn't break random other things imo. Or am I missing something?
Or are CodeGen/error-stmt-in-non-affine-region.ll, CodeGen/large-numbers-in-boundary-context.ll or SemaTemplate/instantiate-function-1.mm somehow related to this change?
Sometimes there are pre-existing failures on the master branch. You can generally ignore any failures that aren't obviously related to your change.
Just noticed that I accidentally removed the FIXME comments, but since this isn't intended to be committed directly, I guess it's not that big of a deal. Otherwise, please let me know.