This is an archive of the discontinued LLVM Phabricator instance.

[Headers][doc] Add misc non-AVX2 intrinsic descriptions
ClosedPublic

Authored by probinson on Jul 20 2023, 9:36 AM.

Details

Summary

Adds descriptions for adxintrin.h, bmi2intrin.h, clflushoptintrin.h,
rdseedintrin.h, and xsavecintrin.h.
Revises clzerointrin.h, the description had some errors.

Diff Detail

Event Timeline

probinson created this revision.Jul 20 2023, 9:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2023, 9:36 AM
probinson requested review of this revision.Jul 20 2023, 9:36 AM
pengfei added inline comments.Jul 20 2023, 6:43 PM
clang/lib/Headers/rdseedintrin.h
56

32

84

64

clang/lib/Headers/xsavecintrin.h
34

It's not mask but mask AND XINUSE[62:0]. The bit[1] also relies on MXCSR ≠ 1F80H. I think we can simply use __p.Header.XSTATE_BV[62:0] := INIT_FUNCTION(mask[62:0])

65

ditto.

probinson updated this revision to Diff 543075.Jul 21 2023, 2:38 PM
probinson marked 4 inline comments as done.

Address review comments.

clang/lib/Headers/rdseedintrin.h
56

Oops. Fixed.

84

Oops. Fixed.

clang/lib/Headers/xsavecintrin.h
34

Okay.

pengfei accepted this revision.Jul 21 2023, 5:58 PM
This revision is now accepted and ready to land.Jul 21 2023, 5:58 PM
This revision was landed with ongoing or failed builds.Jul 24 2023, 10:51 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2023, 10:51 AM