This is an archive of the discontinued LLVM Phabricator instance.

Differential D155853

[ConstraintElim] Add test cases from PR63896. NFC.
ClosedPublic

Authored by dtcxzyw on Jul 20 2023, 9:06 AM.

Details

Reviewers
nikic
fhahn
Commits
rGde0d27c1a417: [ConstraintElim] Add test cases from PR63896. NFC.
Summary

This patch adds some test cases from https://github.com/llvm/llvm-project/issues/63896.

Diff Detail

Event Timeline

dtcxzyw created this revision.Jul 20 2023, 9:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2023, 9:06 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
dtcxzyw requested review of this revision.Jul 20 2023, 9:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2023, 9:06 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
dtcxzyw updated this revision to Diff 542561.Jul 20 2023, 9:22 AM

Fix a typo

dtcxzyw mentioned this in D155412: [ConstraintElim] Add facts implied by MinMaxIntrinsic.Jul 20 2023, 9:46 AM
dtcxzyw added a child revision: D155412: [ConstraintElim] Add facts implied by MinMaxIntrinsic.
Harbormaster completed remote builds in B246945: Diff 542561.Jul 20 2023, 1:15 PM
dtcxzyw updated this revision to Diff 542977.Jul 21 2023, 10:09 AM

Address comments

Harbormaster completed remote builds in B247264: Diff 542977.Jul 21 2023, 3:33 PM
fhahn accepted this revision.Jul 22 2023, 11:22 AM

LGTM, thanks!

This revision is now accepted and ready to land.Jul 22 2023, 11:22 AM
This revision was landed with ongoing or failed builds.Jul 23 2023, 10:58 PM
Closed by commit rGde0d27c1a417: [ConstraintElim] Add test cases from PR63896. NFC. (authored by dtcxzyw). · Explain Why
This revision was automatically updated to reflect the committed changes.
dtcxzyw added a commit: rGde0d27c1a417: [ConstraintElim] Add test cases from PR63896. NFC..

Revision Contents

PathSize
llvm/
test/
Transforms/
ConstraintElimination/
364 lines

Diff 543384

llvm/test/Transforms/ConstraintElimination/minmax.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
; RUN: opt -passes=constraint-elimination -S %s | FileCheck %s
; Test from PR63896
define i1 @umax_ugt(i32 %x, i32 %y) {
; CHECK-LABEL: define i1 @umax_ugt
; CHECK-SAME: (i32 [[X:%.*]], i32 [[Y:%.*]]) {
; CHECK-NEXT: [[MAX:%.*]] = call i32 @llvm.umax.i32(i32 [[X]], i32 1)
; CHECK-NEXT: [[CMP:%.*]] = icmp ugt i32 [[Y]], [[MAX]]
; CHECK-NEXT: br i1 [[CMP]], label [[IF:%.*]], label [[END:%.*]]
; CHECK: if:
; CHECK-NEXT: [[CMP2:%.*]] = icmp ugt i32 [[Y]], [[X]]
; CHECK-NEXT: [[CMP3:%.*]] = icmp uge i32 [[Y]], [[X]]
; CHECK-NEXT: [[RET:%.*]] = xor i1 [[CMP2]], [[CMP3]]
; CHECK-NEXT: ret i1 [[RET]]
; CHECK: end:
; CHECK-NEXT: ret i1 false
;
%max = call i32 @llvm.umax.i32(i32 %x, i32 1)
%cmp = icmp ugt i32 %y, %max
br i1 %cmp, label %if, label %end
if:
%cmp2 = icmp ugt i32 %y, %x
%cmp3 = icmp uge i32 %y, %x
%ret = xor i1 %cmp2, %cmp3
ret i1 %ret
end:
ret i1 false
}
define i1 @umax_uge(i32 %x, i32 %y) {
; CHECK-LABEL: define i1 @umax_uge
; CHECK-SAME: (i32 [[X:%.*]], i32 [[Y:%.*]]) {
; CHECK-NEXT: [[MAX:%.*]] = call i32 @llvm.umax.i32(i32 [[X]], i32 1)
; CHECK-NEXT: [[CMP:%.*]] = icmp uge i32 [[Y]], [[MAX]]
; CHECK-NEXT: br i1 [[CMP]], label [[IF:%.*]], label [[END:%.*]]
; CHECK: if:
; CHECK-NEXT: [[CMP2:%.*]] = icmp ugt i32 [[Y]], [[X]]
; CHECK-NEXT: [[CMP3:%.*]] = icmp uge i32 [[Y]], [[X]]
; CHECK-NEXT: [[RET:%.*]] = xor i1 [[CMP2]], [[CMP3]]
; CHECK-NEXT: ret i1 [[RET]]
; CHECK: end:
; CHECK-NEXT: ret i1 false
;
%max = call i32 @llvm.umax.i32(i32 %x, i32 1)
%cmp = icmp uge i32 %y, %max
br i1 %cmp, label %if, label %end
if:
%cmp2 = icmp ugt i32 %y, %x
%cmp3 = icmp uge i32 %y, %x
%ret = xor i1 %cmp2, %cmp3
ret i1 %ret
end:
ret i1 false
}
define i1 @umin_ult(i32 %x, i32 %y) {
; CHECK-LABEL: define i1 @umin_ult
; CHECK-SAME: (i32 [[X:%.*]], i32 [[Y:%.*]]) {
; CHECK-NEXT: [[MIN:%.*]] = call i32 @llvm.umin.i32(i32 [[X]], i32 1)
; CHECK-NEXT: [[CMP:%.*]] = icmp ult i32 [[Y]], [[MIN]]
; CHECK-NEXT: br i1 [[CMP]], label [[IF:%.*]], label [[END:%.*]]
; CHECK: if:
; CHECK-NEXT: [[CMP2:%.*]] = icmp ult i32 [[Y]], [[X]]
; CHECK-NEXT: [[CMP3:%.*]] = icmp ule i32 [[Y]], [[X]]
; CHECK-NEXT: [[RET:%.*]] = xor i1 [[CMP2]], [[CMP3]]
; CHECK-NEXT: ret i1 [[RET]]
; CHECK: end:
; CHECK-NEXT: ret i1 false
;
%min = call i32 @llvm.umin.i32(i32 %x, i32 1)
%cmp = icmp ult i32 %y, %min
br i1 %cmp, label %if, label %end
if:
%cmp2 = icmp ult i32 %y, %x
%cmp3 = icmp ule i32 %y, %x
%ret = xor i1 %cmp2, %cmp3
ret i1 %ret
end:
ret i1 false
}
define i1 @umin_ule(i32 %x, i32 %y) {
; CHECK-LABEL: define i1 @umin_ule
; CHECK-SAME: (i32 [[X:%.*]], i32 [[Y:%.*]]) {
; CHECK-NEXT: [[MIN:%.*]] = call i32 @llvm.umin.i32(i32 [[X]], i32 1)
; CHECK-NEXT: [[CMP:%.*]] = icmp ule i32 [[Y]], [[MIN]]
; CHECK-NEXT: br i1 [[CMP]], label [[IF:%.*]], label [[END:%.*]]
; CHECK: if:
; CHECK-NEXT: [[CMP2:%.*]] = icmp ult i32 [[Y]], [[X]]
; CHECK-NEXT: [[CMP3:%.*]] = icmp ule i32 [[Y]], [[X]]
; CHECK-NEXT: [[RET:%.*]] = xor i1 [[CMP2]], [[CMP3]]
; CHECK-NEXT: ret i1 [[RET]]
; CHECK: end:
; CHECK-NEXT: ret i1 false
;
%min = call i32 @llvm.umin.i32(i32 %x, i32 1)
%cmp = icmp ule i32 %y, %min
br i1 %cmp, label %if, label %end
if:
%cmp2 = icmp ult i32 %y, %x
%cmp3 = icmp ule i32 %y, %x
%ret = xor i1 %cmp2, %cmp3
ret i1 %ret
end:
ret i1 false
}
define i1 @smax_sgt(i32 %x, i32 %y) {
; CHECK-LABEL: define i1 @smax_sgt
; CHECK-SAME: (i32 [[X:%.*]], i32 [[Y:%.*]]) {
; CHECK-NEXT: [[MAX:%.*]] = call i32 @llvm.smax.i32(i32 [[X]], i32 1)
; CHECK-NEXT: [[CMP:%.*]] = icmp sgt i32 [[Y]], [[MAX]]
; CHECK-NEXT: br i1 [[CMP]], label [[IF:%.*]], label [[END:%.*]]
; CHECK: if:
; CHECK-NEXT: [[CMP2:%.*]] = icmp sgt i32 [[Y]], [[X]]
; CHECK-NEXT: [[CMP3:%.*]] = icmp sge i32 [[Y]], [[X]]
; CHECK-NEXT: [[RET:%.*]] = xor i1 [[CMP2]], [[CMP3]]
; CHECK-NEXT: ret i1 [[RET]]
; CHECK: end:
; CHECK-NEXT: ret i1 false
;
%max = call i32 @llvm.smax.i32(i32 %x, i32 1)
%cmp = icmp sgt i32 %y, %max
br i1 %cmp, label %if, label %end
if:
%cmp2 = icmp sgt i32 %y, %x
%cmp3 = icmp sge i32 %y, %x
%ret = xor i1 %cmp2, %cmp3
ret i1 %ret
end:
ret i1 false
}
define i1 @smax_sge(i32 %x, i32 %y) {
; CHECK-LABEL: define i1 @smax_sge
; CHECK-SAME: (i32 [[X:%.*]], i32 [[Y:%.*]]) {
; CHECK-NEXT: [[MAX:%.*]] = call i32 @llvm.smax.i32(i32 [[X]], i32 1)
; CHECK-NEXT: [[CMP:%.*]] = icmp sge i32 [[Y]], [[MAX]]
; CHECK-NEXT: br i1 [[CMP]], label [[IF:%.*]], label [[END:%.*]]
; CHECK: if:
; CHECK-NEXT: [[CMP2:%.*]] = icmp sgt i32 [[Y]], [[X]]
; CHECK-NEXT: [[CMP3:%.*]] = icmp sge i32 [[Y]], [[X]]
; CHECK-NEXT: [[RET:%.*]] = xor i1 [[CMP2]], [[CMP3]]
; CHECK-NEXT: ret i1 [[RET]]
; CHECK: end:
; CHECK-NEXT: ret i1 false
;
%max = call i32 @llvm.smax.i32(i32 %x, i32 1)
%cmp = icmp sge i32 %y, %max
br i1 %cmp, label %if, label %end
if:
%cmp2 = icmp sgt i32 %y, %x
%cmp3 = icmp sge i32 %y, %x
%ret = xor i1 %cmp2, %cmp3
ret i1 %ret
end:
ret i1 false
}
define i1 @smin_slt(i32 %x, i32 %y) {
; CHECK-LABEL: define i1 @smin_slt
; CHECK-SAME: (i32 [[X:%.*]], i32 [[Y:%.*]]) {
; CHECK-NEXT: [[MIN:%.*]] = call i32 @llvm.smin.i32(i32 [[X]], i32 1)
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i32 [[Y]], [[MIN]]
; CHECK-NEXT: br i1 [[CMP]], label [[IF:%.*]], label [[END:%.*]]
; CHECK: if:
; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i32 [[Y]], [[X]]
; CHECK-NEXT: [[CMP3:%.*]] = icmp sle i32 [[Y]], [[X]]
; CHECK-NEXT: [[RET:%.*]] = xor i1 [[CMP2]], [[CMP3]]
; CHECK-NEXT: ret i1 [[RET]]
; CHECK: end:
; CHECK-NEXT: ret i1 false
;
%min = call i32 @llvm.smin.i32(i32 %x, i32 1)
%cmp = icmp slt i32 %y, %min
br i1 %cmp, label %if, label %end
if:
%cmp2 = icmp slt i32 %y, %x
%cmp3 = icmp sle i32 %y, %x
%ret = xor i1 %cmp2, %cmp3
ret i1 %ret
end:
ret i1 false
}
define i1 @smin_sle(i32 %x, i32 %y) {
; CHECK-LABEL: define i1 @smin_sle
; CHECK-SAME: (i32 [[X:%.*]], i32 [[Y:%.*]]) {
; CHECK-NEXT: [[MIN:%.*]] = call i32 @llvm.smin.i32(i32 [[X]], i32 1)
; CHECK-NEXT: [[CMP:%.*]] = icmp sle i32 [[Y]], [[MIN]]
; CHECK-NEXT: br i1 [[CMP]], label [[IF:%.*]], label [[END:%.*]]
; CHECK: if:
; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i32 [[Y]], [[X]]
; CHECK-NEXT: [[CMP3:%.*]] = icmp sle i32 [[Y]], [[X]]
; CHECK-NEXT: [[RET:%.*]] = xor i1 [[CMP2]], [[CMP3]]
; CHECK-NEXT: ret i1 [[RET]]
; CHECK: end:
; CHECK-NEXT: ret i1 false
;
%min = call i32 @llvm.smin.i32(i32 %x, i32 1)
%cmp = icmp sle i32 %y, %min
br i1 %cmp, label %if, label %end
if:
%cmp2 = icmp slt i32 %y, %x
%cmp3 = icmp sle i32 %y, %x
%ret = xor i1 %cmp2, %cmp3
ret i1 %ret
end:
ret i1 false
}
define i1 @umax_uge_ugt_with_add_nuw(i32 %x, i32 %y) {
; CHECK-LABEL: define i1 @umax_uge_ugt_with_add_nuw
; CHECK-SAME: (i32 [[X:%.*]], i32 [[Y:%.*]]) {
; CHECK-NEXT: [[MAX:%.*]] = call i32 @llvm.umax.i32(i32 [[X]], i32 1)
; CHECK-NEXT: [[SUM:%.*]] = add nuw i32 [[MAX]], 1
; CHECK-NEXT: [[CMP:%.*]] = icmp uge i32 [[Y]], [[SUM]]
; CHECK-NEXT: br i1 [[CMP]], label [[IF:%.*]], label [[END:%.*]]
; CHECK: if:
; CHECK-NEXT: [[CMP2:%.*]] = icmp ugt i32 [[Y]], [[X]]
; CHECK-NEXT: ret i1 [[CMP2]]
; CHECK: end:
; CHECK-NEXT: ret i1 false
;
%max = call i32 @llvm.umax.i32(i32 %x, i32 1)
%sum = add nuw i32 %max, 1
%cmp = icmp uge i32 %y, %sum
br i1 %cmp, label %if, label %end
if:
%cmp2 = icmp ugt i32 %y, %x
ret i1 %cmp2
end:
ret i1 false
}
define i1 @smin_ule_mixed(i32 %x, i32 %y) {
; CHECK-LABEL: define i1 @smin_ule_mixed
; CHECK-SAME: (i32 [[X:%.*]], i32 [[Y:%.*]]) {
; CHECK-NEXT: [[MIN:%.*]] = call i32 @llvm.smin.i32(i32 [[X]], i32 1)
; CHECK-NEXT: [[CMP:%.*]] = icmp ule i32 [[Y]], [[MIN]]
; CHECK-NEXT: br i1 [[CMP]], label [[IF:%.*]], label [[END:%.*]]
; CHECK: if:
; CHECK-NEXT: [[CMP2:%.*]] = icmp slt i32 [[Y]], [[X]]
; CHECK-NEXT: [[CMP3:%.*]] = icmp sle i32 [[Y]], [[X]]
; CHECK-NEXT: [[CMP4:%.*]] = icmp ult i32 [[Y]], [[X]]
; CHECK-NEXT: [[CMP5:%.*]] = icmp ule i32 [[Y]], [[X]]
; CHECK-NEXT: [[XOR1:%.*]] = xor i1 [[CMP2]], [[CMP3]]
; CHECK-NEXT: [[XOR2:%.*]] = xor i1 [[CMP4]], [[CMP5]]
; CHECK-NEXT: [[RET:%.*]] = xor i1 [[XOR1]], [[XOR2]]
; CHECK-NEXT: ret i1 [[RET]]
; CHECK: end:
; CHECK-NEXT: ret i1 false
;
%min = call i32 @llvm.smin.i32(i32 %x, i32 1)
%cmp = icmp ule i32 %y, %min
br i1 %cmp, label %if, label %end
if:
%cmp2 = icmp slt i32 %y, %x
%cmp3 = icmp sle i32 %y, %x
%cmp4 = icmp ult i32 %y, %x
%cmp5 = icmp ule i32 %y, %x
%xor1 = xor i1 %cmp2, %cmp3
%xor2 = xor i1 %cmp4, %cmp5
%ret = xor i1 %xor1, %xor2
ret i1 %ret
end:
ret i1 false
}
define i1 @umax_ugt_ugt_both(i32 %x, i32 %y, i32 %z) {
; CHECK-LABEL: define i1 @umax_ugt_ugt_both
; CHECK-SAME: (i32 [[X:%.*]], i32 [[Y:%.*]], i32 [[Z:%.*]]) {
; CHECK-NEXT: [[MAX:%.*]] = call i32 @llvm.umax.i32(i32 [[X]], i32 [[Y]])
; CHECK-NEXT: [[CMP:%.*]] = icmp ugt i32 [[Z]], [[MAX]]
; CHECK-NEXT: br i1 [[CMP]], label [[IF:%.*]], label [[END:%.*]]
; CHECK: if:
; CHECK-NEXT: [[CMP2:%.*]] = icmp ugt i32 [[Z]], [[X]]
; CHECK-NEXT: [[CMP3:%.*]] = icmp ugt i32 [[Z]], [[Y]]
; CHECK-NEXT: [[AND:%.*]] = xor i1 [[CMP2]], [[CMP3]]
; CHECK-NEXT: ret i1 [[AND]]
; CHECK: end:
; CHECK-NEXT: ret i1 false
;
%max = call i32 @llvm.umax.i32(i32 %x, i32 %y)
%cmp = icmp ugt i32 %z, %max
br i1 %cmp, label %if, label %end
if:
%cmp2 = icmp ugt i32 %z, %x
%cmp3 = icmp ugt i32 %z, %y
%and = xor i1 %cmp2, %cmp3
ret i1 %and
end:
ret i1 false
}
define i1 @smin_branchless(i32 %x, i32 %y) {
; CHECK-LABEL: define i1 @smin_branchless
; CHECK-SAME: (i32 [[X:%.*]], i32 [[Y:%.*]]) {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[MIN:%.*]] = call i32 @llvm.smin.i32(i32 [[X]], i32 [[Y]])
; CHECK-NEXT: [[CMP1:%.*]] = icmp sle i32 [[MIN]], [[X]]
; CHECK-NEXT: [[CMP2:%.*]] = icmp sgt i32 [[MIN]], [[X]]
; CHECK-NEXT: [[RET:%.*]] = xor i1 [[CMP1]], [[CMP2]]
; CHECK-NEXT: ret i1 [[RET]]
;
entry:
%min = call i32 @llvm.smin.i32(i32 %x, i32 %y)
%cmp1 = icmp sle i32 %min, %x
%cmp2 = icmp sgt i32 %min, %x
%ret = xor i1 %cmp1, %cmp2
ret i1 %ret
}
define i32 @simplify_smax(i32 %x, i32 %y, i32 %z) {
; CHECK-LABEL: define i32 @simplify_smax
; CHECK-SAME: (i32 [[X:%.*]], i32 [[Y:%.*]], i32 [[Z:%.*]]) {
; CHECK-NEXT: entry:
; CHECK-NEXT: [[CMP:%.*]] = icmp slt i32 [[X]], [[Y]]
; CHECK-NEXT: br i1 [[CMP]], label [[IF:%.*]], label [[END:%.*]]
; CHECK: if:
; CHECK-NEXT: [[MAX1:%.*]] = call i32 @llvm.smax.i32(i32 [[X]], i32 [[Z]])
; CHECK-NEXT: [[MAX2:%.*]] = call i32 @llvm.smax.i32(i32 [[Y]], i32 [[MAX1]])
; CHECK-NEXT: ret i32 [[MAX2]]
; CHECK: end:
; CHECK-NEXT: ret i32 0
;
entry:
%cmp = icmp slt i32 %x, %y
br i1 %cmp, label %if, label %end
if:
%max1 = call i32 @llvm.smax.i32(i32 %x, i32 %z)
%max2 = call i32 @llvm.smax.i32(i32 %y, i32 %max1)
ret i32 %max2
end:
ret i32 0
}
declare i32 @llvm.smin.i32(i32, i32)
declare i32 @llvm.smax.i32(i32, i32)
declare i32 @llvm.umin.i32(i32, i32)
declare i32 @llvm.umax.i32(i32, i32)