This is an archive of the discontinued LLVM Phabricator instance.

Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.
ClosedPublic

Authored by AMP999 on Jul 20 2023, 4:23 AM.

Details

Reviewers
NoQ
ziqingluo-90
Group Reviewers
Restricted Project
Commits
rG82b94a9f7be9: Fix the linting problems in UnsafeBufferUsage.cpp
Summary

clang/utils/ci/run-buildbot check-format command in remote build process caused my last differential, https://reviews.llvm.org/D155714, to fail (https://buildkite.com/llvm-project/clang-ci/builds/355) and when I checked the logs I found out that the problem doesn't reside in my change. So I fixed the linting problem in the clang/lib/Analysis/UnsafeBufferUsage.cpp file which is to remove some extra white spaces.

Diff Detail

Event Timeline

AMP999 created this revision.Jul 20 2023, 4:23 AM
Herald added a project: Restricted Project. · View Herald Transcript
AMP999 requested review of this revision.Jul 20 2023, 4:23 AM
AMP999 retitled this revision from Fix the linting problems which caused `clang/utils/ci/run-buildbot check-format` to return 1. to Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1..Jul 20 2023, 4:24 AM
AMP999 edited the summary of this revision. (Show Details)
AMP999 edited the summary of this revision. (Show Details)
AMP999 updated this revision to Diff 542972.Jul 21 2023, 9:41 AM
ziqingluo-90 accepted this revision.Jul 24 2023, 6:35 PM

Thanks for cleaning the trailing whites.

This revision is now accepted and ready to land.Jul 24 2023, 6:35 PM

You're welcome!
I don't have permission to commit so I'll send my Name and Email:
Name: Amirreza Ashouri
Email: ar.ashouri999@gmail.com

BTW my Email in one of my previous patches is inserted incorrectly. I appreciate if you could possibly fix that for me.
my Email in this 0fd4175907b40fe63131482c162d7e0f76000521 commit, is inserted google.com instead of gmail.com .
Thank You!

Hi @ziqingluo-90 !
I don't have commit privileges, could you commit this for me?

This revision was landed with ongoing or failed builds.Aug 1 2023, 4:18 PM
This revision was automatically updated to reflect the committed changes.

Hi @AMP999

I have committed this patch on behalf of you.
Unfortunately, I cannot amend an old commit for you as it will cause rewriting a bunch of the history.
I made a correction message along with the commit.

NoQ added a comment.Aug 1 2023, 4:42 PM

Looks like rG910450a28ba9c has independently addressed both issues. But at least we had a chance to deal with the injustice!