Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

AMP999 (Amirreza Ashouri)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 29 2023, 7:10 AM (12 w, 5 d)

Recent Activity

Mon, Sep 25

AMP999 added a comment to D157776: [libc++] Eliminate extra allocations from `std::move(oss).str()`.

Migrated to https://github.com/llvm/llvm-project/pull/67294 .

Mon, Sep 25, 1:29 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Sep 8

AMP999 updated the diff for D157776: [libc++] Eliminate extra allocations from `std::move(oss).str()`.

The extension is removed.

Fri, Sep 8, 7:25 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Aug 28

AMP999 added a comment to D157776: [libc++] Eliminate extra allocations from `std::move(oss).str()`.

@philnik gentle ping!

Mon, Aug 28, 2:19 PM · Restricted Project, Restricted Project, Restricted Project

Aug 19 2023

AMP999 added inline comments to D150831: [libc++] Implement ranges::ends_with.
Aug 19 2023, 7:16 AM · Restricted Project, Restricted Project

Aug 18 2023

AMP999 updated the diff for D157776: [libc++] Eliminate extra allocations from `std::move(oss).str()`.

Addressed review comments, removed string(string&&, pos, n, alloc) constructor from C++20 mode again.

Aug 18 2023, 8:53 AM · Restricted Project, Restricted Project, Restricted Project

Aug 14 2023

AMP999 added a comment to D157776: [libc++] Eliminate extra allocations from `std::move(oss).str()`.

I appreciate it if someone helps me with the test failures. I'm not sure why the "Apple back-deployment" targets are all failing.

Aug 14 2023, 9:26 AM · Restricted Project, Restricted Project, Restricted Project

Aug 13 2023

AMP999 updated the diff for D157776: [libc++] Eliminate extra allocations from `std::move(oss).str()`.
Aug 13 2023, 12:18 PM · Restricted Project, Restricted Project, Restricted Project
AMP999 added inline comments to D157776: [libc++] Eliminate extra allocations from `std::move(oss).str()`.
Aug 13 2023, 11:29 AM · Restricted Project, Restricted Project, Restricted Project
AMP999 updated the diff for D157776: [libc++] Eliminate extra allocations from `std::move(oss).str()`.

Add @pfusik 's change.

Aug 13 2023, 8:59 AM · Restricted Project, Restricted Project, Restricted Project

Aug 12 2023

AMP999 added inline comments to D157776: [libc++] Eliminate extra allocations from `std::move(oss).str()`.
Aug 12 2023, 9:44 AM · Restricted Project, Restricted Project, Restricted Project
AMP999 requested review of D157776: [libc++] Eliminate extra allocations from `std::move(oss).str()`.
Aug 12 2023, 5:01 AM · Restricted Project, Restricted Project, Restricted Project

Aug 2 2023

AMP999 added a comment to D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1..

Thank You @ziqingluo-90!

Aug 2 2023, 12:13 AM · Restricted Project, Restricted Project

Aug 1 2023

AMP999 added a comment to D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1..

Hi @ziqingluo-90 !
I don't have commit privileges, could you commit this for me?

Aug 1 2023, 12:04 PM · Restricted Project, Restricted Project

Jul 26 2023

AMP999 added a comment to D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`.

Any chance you can provide some more details about why the problem is a bug in Clang (Slack seems to require signing up in order to see what's behind the link)?

Sure, I just filed this as a GitHub issue in the following link: https://github.com/llvm/llvm-project/issues/64124

Jul 26 2023, 4:31 AM · Restricted Project, Restricted Project

Jul 25 2023

AMP999 updated subscribers of D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1..

BTW my Email in one of my previous patches is inserted incorrectly. I appreciate if you could possibly fix that for me.
my Email in this 0fd4175907b40fe63131482c162d7e0f76000521 commit, is inserted google.com instead of gmail.com .
Thank You!

Jul 25 2023, 4:19 AM · Restricted Project, Restricted Project

Jul 24 2023

AMP999 added a comment to D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1..

You're welcome!
I don't have permission to commit so I'll send my Name and Email:
Name: Amirreza Ashouri
Email: ar.ashouri999@gmail.com

Jul 24 2023, 11:15 PM · Restricted Project, Restricted Project
AMP999 added a comment to D151625: [clang] Add `clang::equality_operator_compares_members_lexicographically`.

This attribute is trying to work around an issue with operator== instantiation, but according to https://cpplang.slack.com/archives/C6K47F8TT/p1689107603335019?thread_ts=1689107603.335019&cid=C6K47F8TT the problem is actually a bug in Clang. Shouldn't the Clang bug be fixed instead, so that this attribute won't be needed?

Jul 24 2023, 9:58 AM · Restricted Project, Restricted Project

Jul 21 2023

AMP999 updated the diff for D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1..
Jul 21 2023, 9:41 AM · Restricted Project, Restricted Project
AMP999 added a comment to D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='..

By the way I don't have permissions to commit so I'll send you my name and email:
Name: Amirreza Ashouri
Email: ar.ashouri999@gmail.com

Jul 21 2023, 7:34 AM · Restricted Project, Restricted Project
AMP999 added a comment to D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='..

I appreciate if you take a look at another patch I sent to address the ci build failure when calling clang/utils/ci/run-buildbot check-format caused by some extra white spaces.
https://reviews.llvm.org/D155814

Jul 21 2023, 7:30 AM · Restricted Project, Restricted Project
AMP999 updated the diff for D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='..

An entry added to clang/docs/ReleaseNotes.rst
Thank You for the review!

Jul 21 2023, 7:25 AM · Restricted Project, Restricted Project

Jul 20 2023

AMP999 updated the summary of D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1..
Jul 20 2023, 4:25 AM · Restricted Project, Restricted Project
AMP999 retitled D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1. from Fix the linting problems which caused `clang/utils/ci/run-buildbot check-format` to return 1. to Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1..
Jul 20 2023, 4:24 AM · Restricted Project, Restricted Project
AMP999 requested review of D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1..
Jul 20 2023, 4:23 AM · Restricted Project, Restricted Project

Jul 19 2023

AMP999 updated the diff for D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='..

Revised the formatting of the change.

Jul 19 2023, 4:33 PM · Restricted Project, Restricted Project
AMP999 updated the diff for D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='..
Jul 19 2023, 11:48 AM · Restricted Project, Restricted Project
AMP999 requested review of D155714: [clang] Fix diagnostics for defaulted, implicitly deleted 'operator=='..
Jul 19 2023, 8:13 AM · Restricted Project, Restricted Project

Jul 12 2023

AMP999 added a comment to D154776: IFSStub destructor should be virtual.

Mistakes happen!
Although it was important for me, but don't worry, no problem!
Thank you for committing the patch on behalf of me!

Jul 12 2023, 1:26 AM · Restricted Project, Restricted Project, Restricted Project

Jul 10 2023

AMP999 added a comment to D154776: IFSStub destructor should be virtual.

You're Welcome Haowei!
Since I don't have permission to commit I'll send you my name and Email
Name: Amirreza Ashouri
Email: ar.ashouri999@gmail.com
Thank You!

Jul 10 2023, 11:49 AM · Restricted Project, Restricted Project, Restricted Project
AMP999 changed the edit policy for D154776: IFSStub destructor should be virtual.
Jul 10 2023, 11:09 AM · Restricted Project, Restricted Project, Restricted Project

Jul 8 2023

AMP999 requested review of D154776: IFSStub destructor should be virtual.
Jul 8 2023, 2:45 PM · Restricted Project, Restricted Project, Restricted Project

Jul 2 2023

AMP999 added a comment to D154296: Fix typo "__is_parititioned_impl" to "__is_partitioned_impl".

You're Welcome!
I appreciate if you do. Thank You
Name: Amirreza Ashouri
Email: ar.ashouri999@gmail.com

Jul 2 2023, 6:29 AM · Restricted Project, Restricted Project, Restricted Project
AMP999 updated the summary of D154296: Fix typo "__is_parititioned_impl" to "__is_partitioned_impl".
Jul 2 2023, 1:26 AM · Restricted Project, Restricted Project, Restricted Project
AMP999 requested review of D154296: Fix typo "__is_parititioned_impl" to "__is_partitioned_impl".
Jul 2 2023, 1:12 AM · Restricted Project, Restricted Project, Restricted Project

Jun 30 2023

AMP999 added a comment to D154252: correct misspelled _LIBCPP___TYPE_TRAITS_IS_EQUAILITY_COMPARABLE_H to _LIBCPP___TYPE_TRAITS_IS_EQUALITY_COMPARABLE_H.

Yes. I don't have commit access.
Name: Amirreza Ashouri
Email: ar.ashouri999@gmail.com
Thank You

Jun 30 2023, 1:14 PM · Restricted Project, Restricted Project, Restricted Project
AMP999 updated the diff for D154252: correct misspelled _LIBCPP___TYPE_TRAITS_IS_EQUAILITY_COMPARABLE_H to _LIBCPP___TYPE_TRAITS_IS_EQUALITY_COMPARABLE_H.

there was a misspelling on the last line too

Jun 30 2023, 12:56 PM · Restricted Project, Restricted Project, Restricted Project
AMP999 requested review of D154252: correct misspelled _LIBCPP___TYPE_TRAITS_IS_EQUAILITY_COMPARABLE_H to _LIBCPP___TYPE_TRAITS_IS_EQUALITY_COMPARABLE_H.
Jun 30 2023, 12:49 PM · Restricted Project, Restricted Project, Restricted Project