This is an archive of the discontinued LLVM Phabricator instance.

Add namespace support to add_new_check.py
ClosedPublic

Authored by congliu on Dec 16 2015, 6:42 AM.

Diff Detail

Event Timeline

congliu updated this revision to Diff 43003.Dec 16 2015, 6:42 AM
congliu retitled this revision from to Add namespace support to add_new_check.py.
congliu updated this object.
congliu added a reviewer: alexfh.
congliu added a subscriber: cfe-commits.
alexfh added inline comments.Dec 16 2015, 6:44 AM
clang-tidy/add_new_check.py
99

Thinking about this once again, let's replace namespace with module for consistency.

103

nit: Please remove the extra space after module,

congliu updated this revision to Diff 43007.Dec 16 2015, 6:53 AM

Replaced namespace with module;
Removed extra space after module at line 103

congliu marked 2 inline comments as done.Dec 16 2015, 6:57 AM

Replace namespace with module -- Done.
Remove extra space after module -- Done.

alexfh accepted this revision.Dec 16 2015, 6:59 AM
alexfh edited edge metadata.

Looks good. Thank you!

I'll commit the patch for you.

This revision is now accepted and ready to land.Dec 16 2015, 6:59 AM
This revision was automatically updated to reflect the committed changes.