Page MenuHomePhabricator

congliu (Cong Liu)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 16 2015, 5:19 AM (243 w, 14 h)

Recent Activity

Sep 13 2019

congliu added a comment to D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field.

Could someone commit this for me? I failed to commit this change...

Sep 13 2019, 11:36 AM · Restricted Project, Restricted Project, Restricted Project

Sep 12 2019

congliu updated the diff for D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field.

Addressed Haojian's comment.

Sep 12 2019, 1:17 PM · Restricted Project, Restricted Project, Restricted Project

Sep 10 2019

congliu updated the diff for D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field.

Addressed Haojian's comments.

Sep 10 2019, 11:27 AM · Restricted Project, Restricted Project, Restricted Project

Sep 6 2019

congliu added inline comments to D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field.
Sep 6 2019, 2:42 PM · Restricted Project, Restricted Project, Restricted Project
congliu updated the diff for D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field.

Addressed Haojian's comments.

  • Do not warn when there is reference to the proto variable between its declaration and the loop body.
  • Exclude const methods.
  • Update tests.
Sep 6 2019, 2:39 PM · Restricted Project, Restricted Project, Restricted Project

Sep 4 2019

congliu updated the diff for D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field.

Uploaded the correct diff...

Sep 4 2019, 2:10 PM · Restricted Project, Restricted Project, Restricted Project
congliu added a comment to D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field.

I'm not sure this is the correct approach.
I'd think the check instead should be parametrized, so this patch should become just extending the config.

Sep 4 2019, 1:43 PM · Restricted Project, Restricted Project, Restricted Project
congliu updated the diff for D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field.

Updated option descriptions.

Sep 4 2019, 1:37 PM · Restricted Project, Restricted Project, Restricted Project
congliu updated the summary of D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field.
Sep 4 2019, 1:16 PM · Restricted Project, Restricted Project, Restricted Project

Sep 3 2019

congliu created D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field.
Sep 3 2019, 4:41 PM · Restricted Project, Restricted Project, Restricted Project

Jun 24 2016

congliu committed rL273660: Remove ignoringImplicit from clang-tidy..
Remove ignoringImplicit from clang-tidy.
Jun 24 2016, 2:46 AM
congliu committed rL273659: IgnoringImplicit matcher..
IgnoringImplicit matcher.
Jun 24 2016, 2:45 AM
congliu retitled D21677: Add ignoringImplicit matcher from to Add ignoringImplicit matcher.
Jun 24 2016, 2:29 AM

Jun 20 2016

congliu committed rL273160: Revert "[LoopIdiom] Don't remove dead operands manually".
Revert "[LoopIdiom] Don't remove dead operands manually"
Jun 20 2016, 8:29 AM
congliu committed rL273150: Add -fsyntax-only to Driver/opencl.cl test..
Add -fsyntax-only to Driver/opencl.cl test.
Jun 20 2016, 4:32 AM

Feb 18 2016

congliu updated the diff for D17375: Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp..
  • Address review comment.
Feb 18 2016, 5:20 AM
congliu retitled D17375: Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp. from to Add parentheses around arithmetic in operand of '|' in llvm-dwp.cpp..
Feb 18 2016, 5:10 AM

Feb 11 2016

congliu closed D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss..

Closed by commit rL260532: Merge branch 'arcpatch-D16922' (authored by congliu)

Feb 11 2016, 8:30 AM
congliu committed rL260532: Merge branch 'arcpatch-D16922'.
Merge branch 'arcpatch-D16922'
Feb 11 2016, 8:07 AM

Feb 10 2016

congliu updated the diff for D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss..
  • Allowed warnings but disallowed fix for template instantiations.
  • Updated tests.
Feb 10 2016, 8:37 AM
congliu added a comment to D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss..

The strategy has changed. Now this check does not ignore template in instantiation, instead, it generate a single warning for some instantiation and ignore others, so that fix is able to apply.
We do this to walk around the function copied from ASTMatchFinder, since it's incorrect for some tricky situation. And make sense to analyse overriding only when there is fully instantiation of the primary template.

Feb 10 2016, 6:15 AM
congliu updated the diff for D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss..
  • Generate a single warning for multiple template instantiations.
Feb 10 2016, 6:05 AM

Feb 9 2016

congliu updated the diff for D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss..
  • Disallowed matches for method in template instantiations. Updated test.
Feb 9 2016, 5:30 AM

Feb 5 2016

congliu added inline comments to D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss..
Feb 5 2016, 9:58 AM
congliu updated the diff for D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss..
  • Added test cases of macro and template.
Feb 5 2016, 9:54 AM
congliu retitled D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss. from to [clang-tidy] Added check-fixes for misc-virtual-near-miss..
Feb 5 2016, 5:56 AM

Feb 3 2016

congliu accepted D16854: [clang-tidy] Fix a crash issue on misc-virtual-near-miss check..

LGTM. Thanks!

Feb 3 2016, 7:58 AM

Jan 28 2016

congliu updated the diff for D16587: Fixed function params comparison. Updated docs and tests..
  • Fixed a nit in test file.
Jan 28 2016, 11:56 PM
congliu updated the diff for D16587: Fixed function params comparison. Updated docs and tests..
  • Fixed bugs introduced by getCanonicalDecl. Has errs log.
  • Cleared up logs.
  • Added mathcers for static method and overloaded operator.
  • Change key type of map from string to pointer to imporve performance.
  • Change implementation of checkOverrideByDerivedMethod.
Jan 28 2016, 11:53 PM

Jan 26 2016

congliu retitled D16587: Fixed function params comparison. Updated docs and tests. from to Fixed function params comparison. Updated docs and tests..
Jan 26 2016, 9:26 AM

Jan 25 2016

congliu added inline comments to D16536: Fix crashing on user-defined conversion..
Jan 25 2016, 9:20 AM
congliu updated the diff for D16536: Fix crashing on user-defined conversion..
  • Address the comment and clean up the code.
Jan 25 2016, 9:20 AM
congliu retitled D16536: Fix crashing on user-defined conversion. from to Fix crashing on user-defined conversion..
Jan 25 2016, 8:36 AM

Jan 15 2016

congliu added a comment to D16179: [clang-tidy] Handle decayed types and other improvements in VirtualNearMiss check..
  • Ignore qualifiers.

I don't think we should ignore qualifiers. Please see my inline comment for line 52 of the test file.

Jan 15 2016, 3:34 PM

Jan 12 2016

congliu updated the diff for D15823: Support virtual-near-miss check..
  • Removed braces; corrected comments; updated test.
Jan 12 2016, 12:24 PM
congliu added a comment to D15823: Support virtual-near-miss check..
Jan 12 2016, 12:24 PM

Jan 8 2016

congliu added inline comments to D15823: Support virtual-near-miss check..
Jan 8 2016, 7:18 AM
congliu updated the diff for D15823: Support virtual-near-miss check..
  • Completed [class.virtual] p7 covarient check. Updated test.
  • Corrected implement of checkParamType.
  • Clean up.
  • Corrected typos. Changed some methods to free-standing. Changed warning message. Updated tests.
  • Finished correcting cpp. Updated doc.
Jan 8 2016, 7:18 AM

Jan 7 2016

congliu updated the diff for D15823: Support virtual-near-miss check..
  • Corrected naming styles; Used clang-format; Add doc to .h
  • Removed useless parentheses, braces around one-line ifs.
  • Added doc; Corrected style and typos for test.
  • Implemented c++ [class.virtual]p7. But has bug.
  • Support ambiguity checking.
  • Completed virtual covarient check. Updated test.
Jan 7 2016, 1:51 AM

Jan 4 2016

congliu added inline comments to D15823: Support virtual-near-miss check..
Jan 4 2016, 4:12 AM

Dec 31 2015

congliu added inline comments to D15823: Support virtual-near-miss check..
Dec 31 2015, 6:32 AM

Dec 30 2015

congliu retitled D15823: Support virtual-near-miss check. from to Support virtual-near-miss check..
Dec 30 2015, 4:22 AM

Dec 16 2015

congliu added a comment to D15571: Add namespace support to add_new_check.py.

Replace namespace with module -- Done.
Remove extra space after module -- Done.

Dec 16 2015, 6:57 AM
congliu updated the diff for D15571: Add namespace support to add_new_check.py.

Replaced namespace with module;
Removed extra space after module at line 103

Dec 16 2015, 6:53 AM
congliu retitled D15571: Add namespace support to add_new_check.py from to Add namespace support to add_new_check.py.
Dec 16 2015, 6:42 AM
congliu added a reviewer for D15569: Add namespace support to add_new_check.py: klimek.
Dec 16 2015, 6:36 AM
congliu retitled D15569: Add namespace support to add_new_check.py from to Add namespace support to add_new_check.py.
Dec 16 2015, 6:31 AM