This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Fold icmp or sub chain ((x1 - y1) | (x2 - y2)) == 0
ClosedPublic

Authored by kitaisreal on Jul 19 2023, 6:55 AM.

Diff Detail

Event Timeline

kitaisreal created this revision.Jul 19 2023, 6:55 AM
kitaisreal requested review of this revision.Jul 19 2023, 6:55 AM
This revision is now accepted and ready to land.Jul 19 2023, 10:27 AM

It seems that there is some issue with build here and in https://reviews.llvm.org/D155703.
How can I validate that pull request is safe to merge ?

nikic added a comment.Jul 21 2023, 1:59 AM

It seems that there is some issue with build here and in https://reviews.llvm.org/D155703.
How can I validate that pull request is safe to merge ?

You could rebase the patches to trigger a new run. The failure is unrelated to your change though (main was broken at the time of the run). Just running check-llvm locally is generally enough for these kinds of changes.

Updated formatting.

I rebased patch and updated formatting.
@goldstein.w.n could you please reapprove revision ?

I rebased patch and updated formatting.
@goldstein.w.n could you please reapprove revision ?

LGTM Again.

kitaisreal set the repository for this revision to rG LLVM Github Monorepo.Jul 25 2023, 7:47 AM

Re-upload the same patch with mentioning correct repository LLVM Github Monorepo.