[scudo] Fix memtag tests.

[cferris]

Summary

A few memtag tests were using EXPECT_DEBUG_DEATH which executes the
statement unless NDEBUG is set. This meant the statement would
cause an abort, but the EXPECT_DEATH part was not done. Change these
to simply EXPECT_DEATH, these tests already verify that SCUDO_DEBUG
is set before checking for DEATH.

compiler-rt/lib/scudo/standalone/tests/memtag_test.cpp

for (u64 Top = 0; Top < 0x100; ++Top)
     Tags = Tags | (1u << extractTag(Addr | (Top << 56)));
   EXPECT_EQ(0xffffull, Tags);
 }
 
 TEST_F(MemtagDeathTest, AddFixedTag) {
   for (uptr Tag = 0; Tag < 0x10; ++Tag)
     EXPECT_EQ(Tag, extractTag(addFixedTag(Addr, Tag)));
   if (SCUDO_DEBUG) {
-    EXPECT_DEBUG_DEATH(addFixedTag(Addr, 16), "");
-    EXPECT_DEBUG_DEATH(addFixedTag(~Addr, 0), "");
+    EXPECT_DEATH(addFixedTag(Addr, 16), "");
+    EXPECT_DEATH(addFixedTag(~Addr, 0), "");
   }
 }
 
 TEST_F(MemtagTest, UntagPointer) {
   uptr UnTagMask = untagPointer(~uptr(0));
   for (u64 Top = 0; Top < 0x100; ++Top) {
     uptr Ptr = (Addr | (Top << 56)) & UnTagMask;
     EXPECT_EQ(addFixedTag(Ptr, 0), untagPointer(Ptr));
for (uptr i = 0; i < 1000; ++i)
       EXPECT_NE(j, extractTag(selectRandomTag(Addr, 1ull << j)));
   }
 }
 
 TEST_F(MemtagDeathTest, SKIP_NO_DEBUG(LoadStoreTagUnaligned)) {
   for (uptr P = Addr; P < Addr + 4 * archMemoryTagGranuleSize(); ++P) {
     if (P % archMemoryTagGranuleSize() == 0)
       continue;
-    EXPECT_DEBUG_DEATH(loadTag(P), "");
-    EXPECT_DEBUG_DEATH(storeTag(P), "");
+    EXPECT_DEATH(loadTag(P), "");
+    EXPECT_DEATH(storeTag(P), "");
   }
 }
 
 TEST_F(MemtagTest, LoadStoreTag) {
   uptr Base = Addr + 0x100;
   uptr Tagged = addFixedTag(Base, 7);
   storeTag(Tagged);
 
   EXPECT_EQ(Base - archMemoryTagGranuleSize(),
             loadTag(Base - archMemoryTagGranuleSize()));
   EXPECT_EQ(Tagged, loadTag(Base));
   EXPECT_EQ(Base + archMemoryTagGranuleSize(),
             loadTag(Base + archMemoryTagGranuleSize()));
 }
 
 TEST_F(MemtagDeathTest, SKIP_NO_DEBUG(StoreTagsUnaligned)) {
   for (uptr P = Addr; P < Addr + 4 * archMemoryTagGranuleSize(); ++P) {
     uptr Tagged = addFixedTag(P, 5);
     if (Tagged % archMemoryTagGranuleSize() == 0)
       continue;
-    EXPECT_DEBUG_DEATH(storeTags(Tagged, Tagged), "");
+    EXPECT_DEATH(storeTags(Tagged, Tagged), "");
   }
 }
 
 TEST_F(MemtagTest, StoreTags) {
   const uptr MaxTaggedSize = 4 * archMemoryTagGranuleSize();
   for (uptr Size = 0; Size <= MaxTaggedSize; ++Size) {
     uptr NoTagBegin = Addr + archMemoryTagGranuleSize();
     uptr NoTagEnd = NoTagBegin + Size;