This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Implement P2614R2 (Deprecate numeric_limits::has_denorm)
ClosedPublic

Authored by philnik on Jul 16 2023, 3:40 PM.

Details

Diff Detail

Event Timeline

philnik created this revision.Jul 16 2023, 3:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 16 2023, 3:40 PM
philnik requested review of this revision.Jul 16 2023, 3:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 16 2023, 3:40 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik updated this revision to Diff 541090.Jul 17 2023, 9:33 AM

Try to fix CI

Thanks for working on this!

libcxx/include/limits
45–46

This should be updated too.

libcxx/test/std/depr/depr.numeric.imits.has.denorm/deprecated.verify.cpp
20

I would add tests that denorm_min does not trigger an deprecated diagnostic. Just to make sure this can be used without triggering a deprecated message. Based on the wording change for denorm_min that is intended.

philnik updated this revision to Diff 557290.Sep 25 2023, 12:36 AM
philnik marked 2 inline comments as done.

Address comments

ldionne accepted this revision.Oct 5 2023, 8:48 AM
ldionne added a subscriber: ldionne.

LGTM with nit. Feel free to fix and commit as-is, the CI failure has been fixed separately and it's probably not worth spending CI cycles for this again (if it rebases cleanly).

libcxx/docs/Status/Cxx23Papers.csv
120
This revision is now accepted and ready to land.Oct 5 2023, 8:48 AM
This revision was landed with ongoing or failed builds.Oct 6 2023, 2:31 AM
This revision was automatically updated to reflect the committed changes.
philnik marked an inline comment as done.