Details
Details
- Reviewers
ldionne - Group Reviewers
Restricted Project - Commits
- rG0d7947b08c00: [libc++] Implement P2614R2 (Deprecate numeric_limits::has_denorm)
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Time | Test | |
---|---|---|
270 ms | libcxx-ci - FreeBSD 13 amd64 > llvm-libunwind-shared-cfg-in.llvm-libunwind-shared-cfg-in::forceunwind.pass.cpp Exit Code: 254
Command Output (stdout):
|
Event Timeline
Comment Actions
Thanks for working on this!
libcxx/include/limits | ||
---|---|---|
45–46 | This should be updated too. | |
libcxx/test/std/depr/depr.numeric.imits.has.denorm/deprecated.verify.cpp | ||
20 | I would add tests that denorm_min does not trigger an deprecated diagnostic. Just to make sure this can be used without triggering a deprecated message. Based on the wording change for denorm_min that is intended. |
Comment Actions
LGTM with nit. Feel free to fix and commit as-is, the CI failure has been fixed separately and it's probably not worth spending CI cycles for this again (if it rebases cleanly).
libcxx/docs/Status/Cxx23Papers.csv | ||
---|---|---|
120 |