This is an archive of the discontinued LLVM Phabricator instance.

Differential D155030

[lldb][NFCI] Avoid construction of temporary std::strings in RegisterValue
ClosedPublic

Authored by bulbazord on Jul 11 2023, 4:45 PM.

Details

Reviewers
JDevlieghere
mib
jingham
Commits
rG1b29a848ffa2: [lldb][NFCI] Avoid construction of temporary std::strings in RegisterValue

Diff Detail

Event Timeline

bulbazord created this revision.Jul 11 2023, 4:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2023, 4:46 PM
bulbazord requested review of this revision.Jul 11 2023, 4:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2023, 4:46 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B244642: Diff 539340.Jul 11 2023, 4:49 PM
JDevlieghere accepted this revision.Jul 17 2023, 11:42 AM

LGTM

This revision is now accepted and ready to land.Jul 17 2023, 11:42 AM
Closed by commit rG1b29a848ffa2: [lldb][NFCI] Avoid construction of temporary std::strings in RegisterValue (authored by bulbazord). · Explain WhyJul 17 2023, 12:55 PM
This revision was automatically updated to reflect the committed changes.
bulbazord added a commit: rG1b29a848ffa2: [lldb][NFCI] Avoid construction of temporary std::strings in RegisterValue.

Revision Contents

PathSize
lldb/
source/
Utility/
10 lines

Diff 541194

lldb/source/Utility/RegisterValue.cpp

Show First 20 Lines • Show All 336 Lines • ▼ Show 20 LinesStatus RegisterValue::SetValueFromString(const RegisterInfo *reg_info,
case eEncodingUint: case eEncodingUint:
if (byte_size > sizeof(uint64_t)) { if (byte_size > sizeof(uint64_t)) {
error.SetErrorStringWithFormat( error.SetErrorStringWithFormat(
"unsupported unsigned integer byte size: %u", byte_size); "unsupported unsigned integer byte size: %u", byte_size);
break; break;
} }
if (value_str.getAsInteger(0, uval64)) { if (value_str.getAsInteger(0, uval64)) {
error.SetErrorStringWithFormat( error.SetErrorStringWithFormatv(
"'%s' is not a valid unsigned integer string value", "'{0}' is not a valid unsigned integer string value", value_str);
value_str.str().c_str());
break; break;
} }
if (!UInt64ValueIsValidForByteSize(uval64, byte_size)) { if (!UInt64ValueIsValidForByteSize(uval64, byte_size)) {
error.SetErrorStringWithFormat( error.SetErrorStringWithFormat(
"value 0x%" PRIx64 "value 0x%" PRIx64
" is too large to fit in a %u byte unsigned integer value", " is too large to fit in a %u byte unsigned integer value",
uval64, byte_size); uval64, byte_size);
Show All 10 LinesStatus RegisterValue::SetValueFromString(const RegisterInfo *reg_info,
case eEncodingSint: case eEncodingSint:
if (byte_size > sizeof(long long)) { if (byte_size > sizeof(long long)) {
error.SetErrorStringWithFormat("unsupported signed integer byte size: %u", error.SetErrorStringWithFormat("unsupported signed integer byte size: %u",
byte_size); byte_size);
break; break;
} }
if (value_str.getAsInteger(0, ival64)) { if (value_str.getAsInteger(0, ival64)) {
error.SetErrorStringWithFormat( error.SetErrorStringWithFormatv(
"'%s' is not a valid signed integer string value", "'{0}' is not a valid signed integer string value", value_str);
value_str.str().c_str());
break; break;
} }
if (!SInt64ValueIsValidForByteSize(ival64, byte_size)) { if (!SInt64ValueIsValidForByteSize(ival64, byte_size)) {
error.SetErrorStringWithFormat( error.SetErrorStringWithFormat(
"value 0x%" PRIx64 "value 0x%" PRIx64
" is too large to fit in a %u byte signed integer value", " is too large to fit in a %u byte signed integer value",
ival64, byte_size); ival64, byte_size);
▲ Show 20 Lines • Show All 461 Lines • Show Last 20 Lines