[clang-format] BraceWrapping.BeforeElse is incorrect for BS_Linux

[ksuther]

Summary

The BraceWrapping of the Linux style is incorrect. This appeared in r248802 when the custom BraceWrapping options were added.

This is what r248801 looked like:

clang-format -style="{BasedOnStyle: google, BreakBeforeBraces: Linux}" ~/Desktop/format.m
void main()
{

if (blah) {
  stuff();
} else {
  more();
}

}

This is what r248802 (and trunk) looks like:

clang-format -style="{BasedOnStyle: google, BreakBeforeBraces: Linux}" ~/Desktop/format.m
void main()
{

if (blah) {
  stuff();
}
else {
  more();
}

}

The behavior before r248802 is correct based on the documentation:

BS_Linux (in configuration: Linux) Like Attach, but break before braces on function, namespace and class definitions.

I changed BraceWrapping.BeforeElse to false for Linux and added and else statement to the Linux brace test.

[djasper]

Submitted as r255484 and r255485.

lib/Format/Format.cpp

   FormatStyle Expanded = Style;
   Expanded.BraceWrapping = {false, false, false, false, false, false,
                             false, false, false, false, false};
   switch (Style.BreakBeforeBraces) {
   case FormatStyle::BS_Linux:
     Expanded.BraceWrapping.AfterClass = true;
     Expanded.BraceWrapping.AfterFunction = true;
     Expanded.BraceWrapping.AfterNamespace = true;
-    Expanded.BraceWrapping.BeforeElse = true;
+    Expanded.BraceWrapping.BeforeElse = false;
     break;
   case FormatStyle::BS_Mozilla:
     Expanded.BraceWrapping.AfterClass = true;
     Expanded.BraceWrapping.AfterEnum = true;
     Expanded.BraceWrapping.AfterFunction = true;
     Expanded.BraceWrapping.AfterStruct = true;
     Expanded.BraceWrapping.AfterUnion = true;
     break;

unittests/Format/FormatTest.cpp

                "{\n"
                "class A\n"
                "{\n"
                "  void f()\n"
                "  {\n"
                "    if (true) {\n"
                "      a();\n"
                "      b();\n"
+               "    } else {\n"
+               "      c();\n"
                "    }\n"
                "  }\n"
                "  void g() { return; }\n"
                "};\n"
                "struct B {\n"
                "  int x;\n"
                "};\n"
                "}\n",