Page MenuHomePhabricator

ksuther (Kent Sutherland)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 31 2015, 12:51 AM (207 w, 5 d)

Recent Activity

Jun 28 2018

ksuther added a comment to D17700: [clang-format] Proposal for changes to Objective-C block formatting.

My fork of spacecommander has a version of clang-format with the option. It's a couple of years old at this point, but it has been running without any issues.

Jun 28 2018, 7:17 AM
Myrronth awarded D17700: [clang-format] Proposal for changes to Objective-C block formatting a Like token.
Jun 28 2018, 6:48 AM

Feb 1 2018

ksuther added a comment to D17700: [clang-format] Proposal for changes to Objective-C block formatting.

It seems to have been. I've been using a modified version of clang-format with this change applied (as well as http://reviews.llvm.org/D17922) since I submitted this.

Feb 1 2018, 10:45 AM
dcasadevall awarded D17700: [clang-format] Proposal for changes to Objective-C block formatting a Like token.
Feb 1 2018, 10:23 AM

Sep 26 2016

ksuther updated the diff for D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types.

Added a unit test.

Sep 26 2016, 3:24 PM

Aug 22 2016

ksuther updated the diff for D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types.

This was accepted a few months ago but it got buried and was never committed. The diff has been updated so that it can be committed cleanly.

Aug 22 2016, 4:41 PM

Mar 25 2016

k06a awarded D17700: [clang-format] Proposal for changes to Objective-C block formatting a Like token.
Mar 25 2016, 12:19 AM

Mar 6 2016

ksuther retitled D17922: [clang-format] Don't add a space before Obj-C selector methods that are also clang-format keywords from to [clang-format] Don't add a space before Obj-C selector methods that are also clang-format keywords.
Mar 6 2016, 8:30 PM
ksuther added a comment to D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types.

Thank you! I don't have commit access, so could this be committed by someone who does?

Mar 6 2016, 8:05 PM
ksuther updated the diff for D17700: [clang-format] Proposal for changes to Objective-C block formatting.

Thanks for the comments. I've made some changes that eliminates reverting r236598 and instead makes the behavior part of IndentNestedBlocks. That allows the Google Obj-C code style (https://google.github.io/styleguide/objcguide.xml#Blocks) to still work by default. The issue with a parameter between block parameters has also been fixed (as part of AllowNewlineBeforeBlockParameter).

Mar 6 2016, 8:03 PM

Feb 28 2016

ksuther retitled D17700: [clang-format] Proposal for changes to Objective-C block formatting from to [clang-format] Proposal for changes to Objective-C block formatting.
Feb 28 2016, 5:27 PM
ksuther added a comment to D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types.

This patch got buried, giving it a bump to see if anyone can take a look at it.

Feb 28 2016, 4:36 PM

Dec 18 2015

ksuther retitled D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types from Don't allow newline after uppercase Obj-C block return types to [clang-format] Don't allow newline after uppercase Obj-C block return types.
Dec 18 2015, 8:15 AM
ksuther retitled D15643: [clang-format] Don't allow newline after uppercase Obj-C block return types from to Don't allow newline after uppercase Obj-C block return types.
Dec 18 2015, 8:14 AM

Dec 13 2015

ksuther retitled D15485: [clang-format] BraceWrapping.BeforeElse is incorrect for BS_Linux from to [clang-format] BraceWrapping.BeforeElse is incorrect for BS_Linux.
Dec 13 2015, 7:47 PM

Oct 10 2015

ksuther added a comment to D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key.

This patch is still awaiting a commit. Sorry to repeatedly post about this, just don't want it to get lost.

Oct 10 2015, 1:18 PM

Oct 6 2015

ksuther added a comment to D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key.

Do I need to do anything else about this and D12489, or do they eventually get committed by someone else? Thanks!

Oct 6 2015, 6:58 PM

Sep 22 2015

ksuther added a comment to D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key.

I do not.

Sep 22 2015, 7:58 AM
ksuther added a comment to D12489: [clang-format] Fixed missing space between Obj-C for/in and a typecast.

I don't, this and http://reviews.llvm.org/D12489 are my first patch submissions.

Sep 22 2015, 7:57 AM

Sep 17 2015

ksuther added inline comments to D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key.
Sep 17 2015, 11:20 AM
ksuther added a comment to D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key.

Adding another comment in hopes of getting some visibility on this. Do I need to add other people as reviewers?

Sep 17 2015, 8:18 AM
ksuther added a comment to D12489: [clang-format] Fixed missing space between Obj-C for/in and a typecast.

Adding another comment in hopes of getting some visibility on this. Do I need to add other people as reviewers?

Sep 17 2015, 8:18 AM

Sep 3 2015

ksuther updated the diff for D12489: [clang-format] Fixed missing space between Obj-C for/in and a typecast.

Added two tests: One of a for/in loop with a cast, and one without.

Sep 3 2015, 9:11 AM

Aug 31 2015

ksuther updated D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key.
Aug 31 2015, 1:17 PM
ksuther retitled D12501: [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key from to [clang-format] Obj-C dictionary literals: Fixed typecast getting put on a separate line from the key.
Aug 31 2015, 1:16 PM
ksuther added a reviewer for D12489: [clang-format] Fixed missing space between Obj-C for/in and a typecast: djasper.

This is my first commit and I'm trying to figure out the system, hope I'm doing this right.

Aug 31 2015, 1:09 PM
ksuther updated subscribers of D12489: [clang-format] Fixed missing space between Obj-C for/in and a typecast.
Aug 31 2015, 10:08 AM
ksuther retitled D12489: [clang-format] Fixed missing space between Obj-C for/in and a typecast from to [clang-format] Fixed missing space between Obj-C for/in and a typecast.
Aug 31 2015, 1:07 AM