This is an archive of the discontinued LLVM Phabricator instance.

Differential D154810

[LoongArch][NFC] Add tests for (X & -256) == 256 -> (X >> 8) == 1
ClosedPublic

Authored by hev on Jul 9 2023, 7:28 PM.

Details

Reviewers
SixWeining
xen0n
Commits
rG0cceea90bf59: [LoongArch][NFC] Add tests for (X & -256) == 256 -> (X >> 8) == 1
Summary

Add tests for (X & -256) == 256 -> (X >> 8) == 1.

Signed-off-by: WANG Rui <wangrui@loongson.cn>

Diff Detail

Unit TestsFailed

TimeTest
3,790 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases/Linux::auto_memory_profile_test.cpp

Event Timeline

hev created this revision.Jul 9 2023, 7:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2023, 7:28 PM
Herald added a subscriber: asbirlea. · View Herald Transcript
hev requested review of this revision.Jul 9 2023, 7:28 PM
Herald added a subscriber: llvm-commits. · View Herald TranscriptJul 9 2023, 7:28 PM
hev added a child revision: D154811: [LoongArch] Implement isLegalICmpImmediate.Jul 9 2023, 7:30 PM
Harbormaster completed remote builds in B244036: Diff 538494.Jul 9 2023, 8:50 PM
hev updated this revision to Diff 538534.Jul 10 2023, 1:03 AM

Add LA64 to test file.

Harbormaster completed remote builds in B244064: Diff 538534.Jul 10 2023, 1:47 AM
xen0n accepted this revision.Jul 10 2023, 6:09 AM

Add NFC somewhere in the title or summary? And is it better to add the case into test/CodeGen/LoongArch/ir-instruction/icmp.ll since we already stuff several icmp-related tests there?

This revision is now accepted and ready to land.Jul 10 2023, 6:09 AM
SixWeining accepted this revision.Jul 24 2023, 2:39 AM
SixWeining retitled this revision from [LoongArch] Add tests for (X & -256) == 256 -> (X >> 8) == 1 to [LoongArch][NFC] Add tests for (X & -256) == 256 -> (X >> 8) == 1.
Closed by commit rG0cceea90bf59: [LoongArch][NFC] Add tests for (X & -256) == 256 -> (X >> 8) == 1 (authored by hev, committed by SixWeining). · Explain WhyJul 24 2023, 2:43 AM
This revision was automatically updated to reflect the committed changes.
SixWeining added a commit: rG0cceea90bf59: [LoongArch][NFC] Add tests for (X & -256) == 256 -> (X >> 8) == 1.

Revision Contents

PathSize
llvm/
test/
CodeGen/
LoongArch/
18 lines

Diff 538494

llvm/test/CodeGen/LoongArch/legalicmpimm.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc --mtriple=loongarch64 < %s | FileCheck %s
define i32 @icmpimm(i32 %x) {
; CHECK-LABEL: icmpimm:
; CHECK: # %bb.0:
; CHECK-NEXT: lu12i.w $a1, -1
; CHECK-NEXT: lu32i.d $a1, 0
; CHECK-NEXT: and $a0, $a0, $a1
; CHECK-NEXT: lu12i.w $a1, 1
; CHECK-NEXT: xor $a0, $a0, $a1
; CHECK-NEXT: sltui $a0, $a0, 1
; CHECK-NEXT: ret
%1 = and i32 %x, -4096
%2 = icmp eq i32 %1, 4096
%3 = zext i1 %2 to i32
ret i32 %3
}