This is an archive of the discontinued LLVM Phabricator instance.

[IR] Remove terminatepad
ClosedPublic

Authored by majnemer on Dec 12 2015, 1:02 PM.

Details

Summary

It turns out that terminatepad gives little benefit over a cleanuppad
which calls the termination function. This is not sufficient to
implement fully generic filters but MSVC doesn't support them which
makes terminatepad a little over-designed.

Depends on D15478.

Diff Detail

Event Timeline

majnemer updated this revision to Diff 42642.Dec 12 2015, 1:02 PM
majnemer retitled this revision from to [IR] Remove terminatepad.
majnemer updated this object.
majnemer added a subscriber: llvm-commits.
JosephTremoulet accepted this revision.Dec 12 2015, 7:06 PM
JosephTremoulet edited edge metadata.

LGTM!

lib/Analysis/EHPersonalities.cpp
60

s/funclets/a funclet/

This revision is now accepted and ready to land.Dec 12 2015, 7:06 PM
rnk accepted this revision.Dec 14 2015, 9:49 AM
rnk edited edge metadata.

lgtm

Yep, let's do it.

This revision was automatically updated to reflect the committed changes.
test/Feature/exception.ll