runCmd should print the command before running it in case of crashes

[jingham]

Summary

runCmd (and expect which uses runCmd) run the command, and when that completes, prints the command that was run and the result. That's problematic when the command crashes, since then you don't see what command was run. It's better to print the command to run, then run it, then print the results.

This shouldn't change how the logs look normally, since runCmd captures the command result in an SBCommandResultObject and then prints it back out. So there shouldn't be any output from lldb while the command is running. The only time you should be able to see the difference is if the command crashes, and in that case the difference is you WILL see the command run.

[JDevlieghere]

Makes sense. LGTM.

[mib]

Yep, LGTM!

[bulbazord]

Oh I really like this. Thanks!

lldb/packages/Python/lldbsuite/test/lldbtest.py

def runCmd(self, cmd, msg=None, check=True, trace=False, inHistory=False):
         trace = True if traceAlways else trace
 
         if cmd.startswith("target create "):
             cmd = cmd.replace("target create ", "file ")
 
         running = cmd.startswith("run") or cmd.startswith("process launch")
 
         for i in range(self.maxLaunchCount if running else 1):
-            self.ci.HandleCommand(cmd, self.res, inHistory)
-
             with recording(self, trace) as sbuf:
                 print("runCmd:", cmd, file=sbuf)
                 if not check:
                     print("check of return status not required", file=sbuf)
+
+            self.ci.HandleCommand(cmd, self.res, inHistory)
+
+            with recording(self, trace) as sbuf:
                 if self.res.Succeeded():
                     print("output:", self.res.GetOutput(), file=sbuf)
                 else:
                     print("runCmd failed!", file=sbuf)
                     print(self.res.GetError(), file=sbuf)
 
             if self.res.Succeeded():
                 break