This is an archive of the discontinued LLVM Phabricator instance.

[lldb][AArch64] Fix flakiness in TestSVEThreadedDynamic
ClosedPublic

Authored by DavidSpickett on Jul 7 2023, 4:54 AM.

Details

Summary

This test runs to a breakpoint on thread 0. Thread 0 then starts
thread 2 and 3, which both have breakpoints in them.

In https://lab.llvm.org/buildbot/#/builders/96/builds/41674
I think that we managed to do the first check on thread 2 before
thread 3 had started. Therefore "thread continue 3" failed.

So wait for all three to startup before we check their status.

I considered putting a timeout on the while like the wait_for... methods,
but the test itself already has a global timeout. Plus, I'd rather
not be tuning a timeout per piece of hardware this runs on.

99% of the time we will already have 3 threads when the check is done.

Diff Detail

Event Timeline

DavidSpickett created this revision.Jul 7 2023, 4:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2023, 4:54 AM
DavidSpickett requested review of this revision.Jul 7 2023, 4:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2023, 4:54 AM

My brain says this is not a good way to ensure a state, but I couldn't think of anything that wouldn't have its own race conditions.

omjavaid accepted this revision.Jul 14 2023, 2:05 AM

Sounds ok to me. We can always fix it if starts to cause trouble.

This revision is now accepted and ready to land.Jul 14 2023, 2:05 AM