This is an archive of the discontinued LLVM Phabricator instance.

Differential D154668

[lldb] Support Compact C Type Format (CTF) section
ClosedPublic

Authored by JDevlieghere on Jul 6 2023, 4:53 PM.

Details

Reviewers
bulbazord
Commits
rGe5aa4cff4323: [lldb] Support Compact C Type Format (CTF) section
Summary

Support Compact C Type Format (CTF) section for D154862.

Diff Detail

Event Timeline

JDevlieghere created this revision.Jul 6 2023, 4:53 PM
JDevlieghere created this object with visibility "JDevlieghere (Jonas Devlieghere)".
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2023, 4:53 PM
JDevlieghere requested review of this revision.Jul 6 2023, 4:53 PM
JDevlieghere added a child revision: D154862: [lldb] Support Compact C Type Format (CTF).Jul 10 2023, 9:43 AM
JDevlieghere edited the summary of this revision. (Show Details)
JDevlieghere changed the visibility from "JDevlieghere (Jonas Devlieghere)" to "Public (No Login Required)".
Herald added subscribers: MaskRay, emaste. · View Herald TranscriptJul 10 2023, 9:43 AM
bulbazord accepted this revision.Jul 13 2023, 11:12 AM
This revision is now accepted and ready to land.Jul 13 2023, 11:12 AM
This revision was landed with ongoing or failed builds.Jul 13 2023, 11:31 AM
Closed by commit rGe5aa4cff4323: [lldb] Support Compact C Type Format (CTF) section (authored by JDevlieghere). · Explain Why
This revision was automatically updated to reflect the committed changes.
JDevlieghere added a commit: rGe5aa4cff4323: [lldb] Support Compact C Type Format (CTF) section.
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2023, 11:31 AM

Revision Contents

PathSize
lldb/
include/
lldb/
1 line
source/
Core/
3 lines
Plugins/
ObjectFile/
ELF/
1 line
Mach-O/
4 lines
Symbol/
1 line

Diff 540131

lldb/include/lldb/lldb-enumerations.h

Show First 20 Lines • Show All 732 Lines • ▼ Show 20 Linesenum SectionType {
eSectionTypeDWARFDebugInfoDwo, eSectionTypeDWARFDebugInfoDwo,
eSectionTypeDWARFDebugStrDwo, eSectionTypeDWARFDebugStrDwo,
eSectionTypeDWARFDebugStrOffsetsDwo, eSectionTypeDWARFDebugStrOffsetsDwo,
eSectionTypeDWARFDebugTypesDwo, eSectionTypeDWARFDebugTypesDwo,
eSectionTypeDWARFDebugRngListsDwo, eSectionTypeDWARFDebugRngListsDwo,
eSectionTypeDWARFDebugLocDwo, eSectionTypeDWARFDebugLocDwo,
eSectionTypeDWARFDebugLocListsDwo, eSectionTypeDWARFDebugLocListsDwo,
eSectionTypeDWARFDebugTuIndex, eSectionTypeDWARFDebugTuIndex,
eSectionTypeCTF,
}; };
FLAGS_ENUM(EmulateInstructionOptions){ FLAGS_ENUM(EmulateInstructionOptions){
eEmulateInstructionOptionNone = (0u), eEmulateInstructionOptionNone = (0u),
eEmulateInstructionOptionAutoAdvancePC = (1u << 0), eEmulateInstructionOptionAutoAdvancePC = (1u << 0),
eEmulateInstructionOptionIgnoreConditions = (1u << 1)}; eEmulateInstructionOptionIgnoreConditions = (1u << 1)};
FLAGS_ENUM(FunctionNameType){ FLAGS_ENUM(FunctionNameType){
▲ Show 20 Lines • Show All 539 Lines • Show Last 20 Lines

lldb/source/Core/Section.cpp

Show First 20 Lines • Show All 139 Lines • ▼ Show 20 Linesconst char *Section::GetTypeAsCString() const {
case eSectionTypeCompactUnwind: case eSectionTypeCompactUnwind:
return "compact-unwind"; return "compact-unwind";
case eSectionTypeGoSymtab: case eSectionTypeGoSymtab:
return "go-symtab"; return "go-symtab";
case eSectionTypeAbsoluteAddress: case eSectionTypeAbsoluteAddress:
return "absolute"; return "absolute";
case eSectionTypeDWARFGNUDebugAltLink: case eSectionTypeDWARFGNUDebugAltLink:
return "dwarf-gnu-debugaltlink"; return "dwarf-gnu-debugaltlink";
case eSectionTypeCTF:
return "ctf";
case eSectionTypeOther: case eSectionTypeOther:
return "regular"; return "regular";
} }
return "unknown"; return "unknown";
} }
Section::Section(const ModuleSP &module_sp, ObjectFile *obj_file, Section::Section(const ModuleSP &module_sp, ObjectFile *obj_file,
user_id_t sect_id, ConstString name, user_id_t sect_id, ConstString name,
▲ Show 20 Lines • Show All 291 Lines • ▼ Show 20 Linesbool Section::ContainsOnlyDebugInfo() const {
case eSectionTypeDWARFDebugTypes: case eSectionTypeDWARFDebugTypes:
case eSectionTypeDWARFDebugTypesDwo: case eSectionTypeDWARFDebugTypesDwo:
case eSectionTypeDWARFDebugNames: case eSectionTypeDWARFDebugNames:
case eSectionTypeDWARFAppleNames: case eSectionTypeDWARFAppleNames:
case eSectionTypeDWARFAppleTypes: case eSectionTypeDWARFAppleTypes:
case eSectionTypeDWARFAppleNamespaces: case eSectionTypeDWARFAppleNamespaces:
case eSectionTypeDWARFAppleObjC: case eSectionTypeDWARFAppleObjC:
case eSectionTypeDWARFGNUDebugAltLink: case eSectionTypeDWARFGNUDebugAltLink:
case eSectionTypeCTF:
return true; return true;
} }
return false; return false;
} }
#pragma mark SectionList #pragma mark SectionList
▲ Show 20 Lines • Show All 246 Lines • Show Last 20 Lines

lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

Show First 20 Lines • Show All 1,667 Lines • ▼ Show 20 Lines return llvm::StringSwitch<SectionType>(Name)
.Case("types", eSectionTypeDWARFDebugTypes) .Case("types", eSectionTypeDWARFDebugTypes)
.Case("types.dwo", eSectionTypeDWARFDebugTypesDwo) .Case("types.dwo", eSectionTypeDWARFDebugTypesDwo)
.Default(eSectionTypeOther); .Default(eSectionTypeOther);
} }
return llvm::StringSwitch<SectionType>(Name) return llvm::StringSwitch<SectionType>(Name)
.Case(".ARM.exidx", eSectionTypeARMexidx) .Case(".ARM.exidx", eSectionTypeARMexidx)
.Case(".ARM.extab", eSectionTypeARMextab) .Case(".ARM.extab", eSectionTypeARMextab)
.Cases(".bss", ".tbss", eSectionTypeZeroFill) .Cases(".bss", ".tbss", eSectionTypeZeroFill)
.Case(".ctf", eSectionTypeDebug)
.Cases(".data", ".tdata", eSectionTypeData) .Cases(".data", ".tdata", eSectionTypeData)
.Case(".eh_frame", eSectionTypeEHFrame) .Case(".eh_frame", eSectionTypeEHFrame)
.Case(".gnu_debugaltlink", eSectionTypeDWARFGNUDebugAltLink) .Case(".gnu_debugaltlink", eSectionTypeDWARFGNUDebugAltLink)
.Case(".gosymtab", eSectionTypeGoSymtab) .Case(".gosymtab", eSectionTypeGoSymtab)
.Case(".text", eSectionTypeCode) .Case(".text", eSectionTypeCode)
.Default(eSectionTypeOther); .Default(eSectionTypeOther);
} }
▲ Show 20 Lines • Show All 1,899 Lines • Show Last 20 Lines

lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,196 Lines • ▼ Show 20 Lines if (symbol->ValueIsAddress()) {
case eSectionTypeDWARFDebugTuIndex: case eSectionTypeDWARFDebugTuIndex:
case eSectionTypeDWARFDebugTypes: case eSectionTypeDWARFDebugTypes:
case eSectionTypeDWARFDebugTypesDwo: case eSectionTypeDWARFDebugTypesDwo:
case eSectionTypeDWARFAppleNames: case eSectionTypeDWARFAppleNames:
case eSectionTypeDWARFAppleTypes: case eSectionTypeDWARFAppleTypes:
case eSectionTypeDWARFAppleNamespaces: case eSectionTypeDWARFAppleNamespaces:
case eSectionTypeDWARFAppleObjC: case eSectionTypeDWARFAppleObjC:
case eSectionTypeDWARFGNUDebugAltLink: case eSectionTypeDWARFGNUDebugAltLink:
case eSectionTypeCTF:
return AddressClass::eDebug; return AddressClass::eDebug;
case eSectionTypeEHFrame: case eSectionTypeEHFrame:
case eSectionTypeARMexidx: case eSectionTypeARMexidx:
case eSectionTypeARMextab: case eSectionTypeARMextab:
case eSectionTypeCompactUnwind: case eSectionTypeCompactUnwind:
return AddressClass::eRuntime; return AddressClass::eRuntime;
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Linesstatic lldb::SectionType GetSectionType(uint32_t flags,
static ConstString g_sect_name_dwarf_apple_types("__apple_types"); static ConstString g_sect_name_dwarf_apple_types("__apple_types");
static ConstString g_sect_name_dwarf_apple_namespaces("__apple_namespac"); static ConstString g_sect_name_dwarf_apple_namespaces("__apple_namespac");
static ConstString g_sect_name_dwarf_apple_objc("__apple_objc"); static ConstString g_sect_name_dwarf_apple_objc("__apple_objc");
static ConstString g_sect_name_eh_frame("__eh_frame"); static ConstString g_sect_name_eh_frame("__eh_frame");
static ConstString g_sect_name_compact_unwind("__unwind_info"); static ConstString g_sect_name_compact_unwind("__unwind_info");
static ConstString g_sect_name_text("__text"); static ConstString g_sect_name_text("__text");
static ConstString g_sect_name_data("__data"); static ConstString g_sect_name_data("__data");
static ConstString g_sect_name_go_symtab("__gosymtab"); static ConstString g_sect_name_go_symtab("__gosymtab");
static ConstString g_sect_name_ctf("__ctf");
if (section_name == g_sect_name_dwarf_debug_abbrev) if (section_name == g_sect_name_dwarf_debug_abbrev)
return eSectionTypeDWARFDebugAbbrev; return eSectionTypeDWARFDebugAbbrev;
if (section_name == g_sect_name_dwarf_debug_abbrev_dwo) if (section_name == g_sect_name_dwarf_debug_abbrev_dwo)
return eSectionTypeDWARFDebugAbbrevDwo; return eSectionTypeDWARFDebugAbbrevDwo;
if (section_name == g_sect_name_dwarf_debug_addr) if (section_name == g_sect_name_dwarf_debug_addr)
return eSectionTypeDWARFDebugAddr; return eSectionTypeDWARFDebugAddr;
if (section_name == g_sect_name_dwarf_debug_aranges) if (section_name == g_sect_name_dwarf_debug_aranges)
▲ Show 20 Lines • Show All 61 Lines • ▼ Show 20 Linesstatic lldb::SectionType GetSectionType(uint32_t flags,
if (section_name == g_sect_name_eh_frame) if (section_name == g_sect_name_eh_frame)
return eSectionTypeEHFrame; return eSectionTypeEHFrame;
if (section_name == g_sect_name_compact_unwind) if (section_name == g_sect_name_compact_unwind)
return eSectionTypeCompactUnwind; return eSectionTypeCompactUnwind;
if (section_name == g_sect_name_cfstring) if (section_name == g_sect_name_cfstring)
return eSectionTypeDataObjCCFStrings; return eSectionTypeDataObjCCFStrings;
if (section_name == g_sect_name_go_symtab) if (section_name == g_sect_name_go_symtab)
return eSectionTypeGoSymtab; return eSectionTypeGoSymtab;
if (section_name == g_sect_name_ctf)
return eSectionTypeCTF;
if (section_name == g_sect_name_objc_data || if (section_name == g_sect_name_objc_data ||
section_name == g_sect_name_objc_classrefs || section_name == g_sect_name_objc_classrefs ||
section_name == g_sect_name_objc_superrefs || section_name == g_sect_name_objc_superrefs ||
section_name == g_sect_name_objc_const || section_name == g_sect_name_objc_const ||
section_name == g_sect_name_objc_classlist) { section_name == g_sect_name_objc_classlist) {
return eSectionTypeDataPointers; return eSectionTypeDataPointers;
} }
▲ Show 20 Lines • Show All 5,432 Lines • Show Last 20 Lines

lldb/source/Symbol/ObjectFile.cpp

Show First 20 Lines • Show All 350 Lines • ▼ Show 20 Lines if (symbol) {
case eSectionTypeDWARFDebugTuIndex: case eSectionTypeDWARFDebugTuIndex:
case eSectionTypeDWARFDebugTypes: case eSectionTypeDWARFDebugTypes:
case eSectionTypeDWARFDebugTypesDwo: case eSectionTypeDWARFDebugTypesDwo:
case eSectionTypeDWARFAppleNames: case eSectionTypeDWARFAppleNames:
case eSectionTypeDWARFAppleTypes: case eSectionTypeDWARFAppleTypes:
case eSectionTypeDWARFAppleNamespaces: case eSectionTypeDWARFAppleNamespaces:
case eSectionTypeDWARFAppleObjC: case eSectionTypeDWARFAppleObjC:
case eSectionTypeDWARFGNUDebugAltLink: case eSectionTypeDWARFGNUDebugAltLink:
case eSectionTypeCTF:
return AddressClass::eDebug; return AddressClass::eDebug;
case eSectionTypeEHFrame: case eSectionTypeEHFrame:
case eSectionTypeARMexidx: case eSectionTypeARMexidx:
case eSectionTypeARMextab: case eSectionTypeARMextab:
case eSectionTypeCompactUnwind: case eSectionTypeCompactUnwind:
return AddressClass::eRuntime; return AddressClass::eRuntime;
case eSectionTypeELFSymbolTable: case eSectionTypeELFSymbolTable:
case eSectionTypeELFDynamicSymbols: case eSectionTypeELFDynamicSymbols:
▲ Show 20 Lines • Show All 428 Lines • Show Last 20 Lines