Appease clang-tidy

[tamird]

Summary

Address clang-tidy warnings, correct usage text.

[scott.linder]

There appears to be some mixed styles in llvm/tools/llvm-c-test, but it seems like the more modern additions use CamelCase for locals, so LGTM!

[tamird]

Thanks! Could you land this for me (and then https://reviews.llvm.org/D154630)? I don't have commit.

[scott.linder]

In D154661#4478957, @tamird wrote:

Thanks! Could you land this for me (and then https://reviews.llvm.org/D154630)? I don't have commit.

Yes, I will first thing tomorrow! I like to be around for any post-commit issues and I'm about to leave for the day. Thank you for the patches!

[tamird]

clang-format

[tamird]

In D154661#4478976, @scott.linder wrote:

In D154661#4478957, @tamird wrote:

Thanks! Could you land this for me (and then https://reviews.llvm.org/D154630)? I don't have commit.

Yes, I will first thing tomorrow! I like to be around for any post-commit issues and I'm about to leave for the day. Thank you for the patches!

This is ready to merge! I'll rebase the other one after this lands.

llvm/tools/llvm-c-test/debuginfo.c

 /*===-- debuginfo.c - tool for testing libLLVM and llvm-c API -------------===*\
 |*                                                                            *|
 |* Part of the LLVM Project, under the Apache License v2.0 with LLVM          *|
 |* Exceptions.                                                                *|
 |* See https://llvm.org/LICENSE.txt for license information.                  *|
 |* SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception                    *|
 |*                                                                            *|
 |*===----------------------------------------------------------------------===*|
 |*                                                                            *|
 |* Tests for the LLVM C DebugInfo API                                         *|
 |*                                                                            *|
 \*===----------------------------------------------------------------------===*/
 
 #include "llvm-c-test.h"
 #include "llvm-c/DebugInfo.h"
+
+#include <assert.h>
 #include <stdio.h>
 #include <string.h>
-#include <assert.h>
 
 static LLVMMetadataRef
 declare_objc_class(LLVMDIBuilderRef DIB, LLVMMetadataRef File) {
   LLVMMetadataRef Decl = LLVMDIBuilderCreateStructType(DIB, File, "TestClass", 9, File, 42, 64, 0, LLVMDIFlagObjcClassComplete, NULL, NULL, 0, 0, NULL, NULL, 0);
   LLVMMetadataRef SuperDecl = LLVMDIBuilderCreateStructType(DIB, File, "TestSuperClass", 14, File, 42, 64, 0, LLVMDIFlagObjcClassComplete, NULL, NULL, 0, 0, NULL, NULL, 0);
   LLVMDIBuilderCreateInheritance(DIB, Decl, SuperDecl, 0, 0, 0);
   LLVMMetadataRef TestProperty =
       LLVMDIBuilderCreateObjCProperty(DIB, "test", 4, File, 42, "getTest", 7, "setTest", 7, 0x20 /*copy*/ | 0x40 /*nonatomic*/, SuperDecl);
int llvm_test_dibuilder(void) {
 
   LLVMDisposeDIBuilder(DIB);
   LLVMDisposeModule(M);
 
   return 0;
 }
 
 int llvm_get_di_tag(void) {
-  LLVMModuleRef m = LLVMModuleCreateWithName("Mod");
-  LLVMContextRef context = LLVMGetModuleContext(m);
+  LLVMModuleRef M = LLVMModuleCreateWithName("Mod");
+  LLVMContextRef Context = LLVMGetModuleContext(M);
 
-  LLVMMetadataRef metas[] = {LLVMMDStringInContext2(context, "foo", 3)};
-  LLVMMetadataRef md = LLVMMDNodeInContext2(context, metas, 1);
-  uint16_t tag0 = LLVMGetDINodeTag(md);
-
-  assert(tag0 == 0);
-  (void)tag0;
-
-  const char *filename = "metadata.c";
-  LLVMDIBuilderRef builder = LLVMCreateDIBuilder(m);
-  LLVMMetadataRef file =
-      LLVMDIBuilderCreateFile(builder, filename, strlen(filename), ".", 1);
-  LLVMMetadataRef decl = LLVMDIBuilderCreateStructType(
-      builder, file, "TestClass", 9, file, 42, 64, 0,
+  const char String[] = "foo";
+  LLVMMetadataRef StringMD =
+      LLVMMDStringInContext2(Context, String, strlen(String));
+  LLVMMetadataRef NodeMD = LLVMMDNodeInContext2(Context, &StringMD, 1);
+  assert(LLVMGetDINodeTag(NodeMD) == 0);
+  (void)NodeMD;
+
+  LLVMDIBuilderRef Builder = LLVMCreateDIBuilder(M);
+  const char Filename[] = "metadata.c";
+  const char Directory[] = ".";
+  LLVMMetadataRef File = LLVMDIBuilderCreateFile(
+      Builder, Filename, strlen(Filename), Directory, strlen(Directory));
+  const char Name[] = "TestClass";
+  LLVMMetadataRef Struct = LLVMDIBuilderCreateStructType(
+      Builder, File, Name, strlen(Name), File, 42, 64, 0,
       LLVMDIFlagObjcClassComplete, NULL, NULL, 0, 0, NULL, NULL, 0);
-  uint16_t tag1 = LLVMGetDINodeTag(decl);
+  assert(LLVMGetDINodeTag(Struct) == 0x13);
+  (void)Struct;
 
-  assert(tag1 == 0x13);
-  (void)tag1;
-
-  LLVMDisposeDIBuilder(builder);
-  LLVMDisposeModule(m);
+  LLVMDisposeDIBuilder(Builder);
+  LLVMDisposeModule(M);
 
   return 0;
 }

llvm/tools/llvm-c-test/main.c

static void print_usage(void) {
   fprintf(stderr, "    Read object file from stdin - list sections\n\n");
   fprintf(stderr, "  * --object-list-symbols\n");
   fprintf(stderr,
           "    Read object file from stdin - list symbols (like nm)\n\n");
   fprintf(stderr, "  * --disassemble\n");
   fprintf(stderr, "    Read lines of triple, hex ascii machine code from stdin "
                   "- print disassembly\n\n");
   fprintf(stderr, "  * --calc\n");
+  fprintf(
+      stderr,
+      "    Read lines of name, rpn from stdin - print generated module\n\n");
   fprintf(stderr, "  * --get-di-tag\n");
   fprintf(stderr, "    Run test for getting MDNode dwarf tag\n");
   fprintf(stderr, "  * --replace-md-operand\n");
   fprintf(stderr, "    Run test for replacing MDNode operands\n");
   fprintf(stderr, "  * --is-a-value-as-metadata\n");
   fprintf(stderr,
           "    Run test for checking if LLVMValueRef is a ValueAsMetadata\n");
-  fprintf(
-      stderr,
-      "    Read lines of name, rpn from stdin - print generated module\n\n");
   fprintf(stderr, "  * --echo\n");
   fprintf(stderr, "    Read bitcode file from stdin - print it back out\n\n");
   fprintf(stderr, "  * --echo --opaque-pointers\n");
   fprintf(stderr, "    Read bitcode file from stdin - print it back out in "
                   "opaque pointer mode\n\n");
   fprintf(stderr, "  * --test-diagnostic-handler\n");
   fprintf(stderr,
           "    Read bitcode file from stdin with a diagnostic handler set\n\n");

llvm/tools/llvm-c-test/metadata.c

 /*===-- object.c - tool for testing libLLVM and llvm-c API ----------------===*\
 |*                                                                            *|
 |* Part of the LLVM Project, under the Apache License v2.0 with LLVM          *|
 |* Exceptions.                                                                *|
 |* See https://llvm.org/LICENSE.txt for license information.                  *|
 |* SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception                    *|
 |*                                                                            *|
 |*===----------------------------------------------------------------------===*|
 |*                                                                            *|
 |* This file implements the --add-named-metadata-operand and --set-metadata   *|
 |* commands in llvm-c-test.                                                   *|
 |*                                                                            *|
 \*===----------------------------------------------------------------------===*/
 
 #include "llvm-c-test.h"
+#include "llvm-c/Types.h"
 
 #include <assert.h>
 #include <string.h>
 
 int llvm_add_named_metadata_operand(void) {
-  LLVMModuleRef m = LLVMModuleCreateWithName("Mod");
-  LLVMValueRef values[] = { LLVMConstInt(LLVMInt32Type(), 0, 0) };
+  LLVMModuleRef M = LLVMModuleCreateWithName("Mod");
+  LLVMValueRef Int = LLVMConstInt(LLVMInt32Type(), 0, 0);
 
   // This used to trigger an assertion
-  LLVMAddNamedMetadataOperand(m, "name", LLVMMDNode(values, 1));
+  LLVMAddNamedMetadataOperand(M, "name", LLVMMDNode(&Int, 1));
 
-  LLVMDisposeModule(m);
+  LLVMDisposeModule(M);
 
   return 0;
 }
 
 int llvm_set_metadata(void) {
-  LLVMBuilderRef b = LLVMCreateBuilder();
-  LLVMValueRef values[] = { LLVMConstInt(LLVMInt32Type(), 0, 0) };
+  LLVMBuilderRef Builder = LLVMCreateBuilder();
 
   // This used to trigger an assertion
-  LLVMValueRef ret = LLVMBuildRetVoid(b);
-  LLVMSetMetadata(ret, LLVMGetMDKindID("kind", 4), LLVMMDNode(values, 1));
+  LLVMValueRef Return = LLVMBuildRetVoid(Builder);
 
-  LLVMDisposeBuilder(b);
-  LLVMDeleteInstruction(ret);
+  const char Name[] = "kind";
+  LLVMValueRef Int = LLVMConstInt(LLVMInt32Type(), 0, 0);
+  LLVMSetMetadata(Return, LLVMGetMDKindID(Name, strlen(Name)),
+                  LLVMMDNode(&Int, 1));
+
+  LLVMDisposeBuilder(Builder);
+  LLVMDeleteInstruction(Return);
 
   return 0;
 }
 
 int llvm_replace_md_operand(void) {
-  LLVMModuleRef m = LLVMModuleCreateWithName("Mod");
-  LLVMContextRef context = LLVMGetModuleContext(m);
-  unsigned int tmp = 0;
-
-  LLVMMetadataRef metas[] = {LLVMMDStringInContext2(context, "foo", 3)};
-  LLVMValueRef md =
-      LLVMMetadataAsValue(context, LLVMMDNodeInContext2(context, metas, 1));
-
-  LLVMReplaceMDNodeOperandWith(md, 0,
-                               LLVMMDStringInContext2(context, "bar", 3));
+  LLVMModuleRef M = LLVMModuleCreateWithName("Mod");
+  LLVMContextRef Context = LLVMGetModuleContext(M);
 
-  assert(!strncmp(LLVMGetMDString(LLVMGetOperand(md, 0), &tmp), "bar", 0));
-  (void)tmp;
+  const char String1[] = "foo";
+  LLVMMetadataRef String1MD =
+      LLVMMDStringInContext2(Context, String1, strlen(String1));
+  LLVMMetadataRef NodeMD = LLVMMDNodeInContext2(Context, &String1MD, 1);
+  LLVMValueRef Value = LLVMMetadataAsValue(Context, NodeMD);
+
+  const char String2[] = "bar";
+  LLVMMetadataRef String2MD =
+      LLVMMDStringInContext2(Context, String2, strlen(String2));
+  LLVMReplaceMDNodeOperandWith(Value, 0, String2MD);
+
+  LLVMValueRef Operand = LLVMGetOperand(Value, 0);
+
+  unsigned int Len;
+  const char *String = LLVMGetMDString(Operand, &Len);
+  assert(Len == strlen(String2));
+  assert(strncmp(String, String2, Len) == 0);
+  (void)String;
 
-  LLVMDisposeModule(m);
+  LLVMDisposeModule(M);
 
   return 0;
 }
 
 int llvm_is_a_value_as_metadata(void) {
-  LLVMModuleRef m = LLVMModuleCreateWithName("Mod");
-  LLVMContextRef context = LLVMGetModuleContext(m);
+  LLVMModuleRef M = LLVMModuleCreateWithName("Mod");
+  LLVMContextRef Context = LLVMGetModuleContext(M);
 
-  LLVMValueRef values[] = {LLVMConstInt(LLVMInt32Type(), 0, 0)};
-  LLVMValueRef md = LLVMMDNode(values, 1);
-  assert(LLVMIsAValueAsMetadata(md) == md);
-  (void)md;
-
-  LLVMMetadataRef metas[] = {LLVMMDStringInContext2(context, "foo", 3)};
-  LLVMValueRef md2 =
-      LLVMMetadataAsValue(context, LLVMMDNodeInContext2(context, metas, 1));
-  assert(LLVMIsAValueAsMetadata(md2) == NULL);
-  (void)md2;
+  {
+    LLVMValueRef Int = LLVMConstInt(LLVMInt32Type(), 0, 0);
+    LLVMValueRef NodeMD = LLVMMDNode(&Int, 1);
+    assert(LLVMIsAValueAsMetadata(NodeMD) == NodeMD);
+    (void)NodeMD;
+  }
+
+  {
+    const char String[] = "foo";
+    LLVMMetadataRef StringMD =
+        LLVMMDStringInContext2(Context, String, strlen(String));
+    LLVMMetadataRef NodeMD = LLVMMDNodeInContext2(Context, &StringMD, 1);
+    LLVMValueRef Value = LLVMMetadataAsValue(Context, NodeMD);
+    assert(LLVMIsAValueAsMetadata(Value) == NULL);
+    (void)Value;
+  }
 
   return 0;
 }