This is an archive of the discontinued LLVM Phabricator instance.

Differential D154573

[InstCombine] Add tests for folding `(icmp eq/ne (zext i1) (sext i1))`; NFC
ClosedPublic

Authored by goldstein.w.n on Jul 6 2023, 12:30 AM.

Details

Reviewers
nikic
RKSimon
Commits
rG83ad4cb61f4d: [InstCombine] Add tests for folding `(icmp eq/ne (zext i1) (sext i1))`; NFC

Diff Detail

Unit TestsFailed

TimeTest
60,050 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

goldstein.w.n created this revision.Jul 6 2023, 12:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2023, 12:30 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
goldstein.w.n requested review of this revision.Jul 6 2023, 12:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2023, 12:30 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a child revision: D154574: [InstCombine] Fold `(icmp eq/ne (zext i1 X) (sext i1 Y))`-> `(icmp eq/ne (or X, Y), 0)`.Jul 6 2023, 12:31 AM
nikic accepted this revision.Jul 6 2023, 12:38 AM

LGTM

This revision is now accepted and ready to land.Jul 6 2023, 12:38 AM
Harbormaster completed remote builds in B243393: Diff 537612.Jul 6 2023, 1:18 AM
This revision was landed with ongoing or failed builds.Jul 12 2023, 3:18 PM
Closed by commit rG83ad4cb61f4d: [InstCombine] Add tests for folding `(icmp eq/ne (zext i1) (sext i1))`; NFC (authored by goldstein.w.n). · Explain Why
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rG83ad4cb61f4d: [InstCombine] Add tests for folding `(icmp eq/ne (zext i1) (sext i1))`; NFC.

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
40 lines

Diff 537612

llvm/test/Transforms/InstCombine/icmp-ext-ext.ll

Show First 20 Lines • Show All 374 Lines • ▼ Show 20 Lines
; CHECK-NEXT: ret i1 [[C]] ; CHECK-NEXT: ret i1 [[C]]
; ;
%a = sext i16 %x to i32 %a = sext i16 %x to i32
%n = and i8 %y, 12 %n = and i8 %y, 12
%b = zext i8 %n to i32 %b = zext i8 %n to i32
%c = icmp uge i32 %a, %b %c = icmp uge i32 %a, %b
ret i1 %c ret i1 %c
} }
define i1 @zext_eq_sext(i1 %a, i1 %b) {
; CHECK-LABEL: @zext_eq_sext(
; CHECK-NEXT: [[CONV:%.*]] = zext i1 [[A:%.*]] to i32
; CHECK-NEXT: [[CONV3_NEG:%.*]] = sext i1 [[B:%.*]] to i32
; CHECK-NEXT: [[TOBOOL4:%.*]] = icmp eq i32 [[CONV]], [[CONV3_NEG]]
; CHECK-NEXT: ret i1 [[TOBOOL4]]
;
%conv = zext i1 %a to i32
%conv3.neg = sext i1 %b to i32
%tobool4 = icmp eq i32 %conv, %conv3.neg
ret i1 %tobool4
}
define i1 @zext_eq_sext_fail_not_i1(i1 %a, i8 %b) {
; CHECK-LABEL: @zext_eq_sext_fail_not_i1(
; CHECK-NEXT: [[CONV:%.*]] = zext i1 [[A:%.*]] to i32
; CHECK-NEXT: [[CONV3_NEG:%.*]] = sext i8 [[B:%.*]] to i32
; CHECK-NEXT: [[TOBOOL4:%.*]] = icmp eq i32 [[CONV]], [[CONV3_NEG]]
; CHECK-NEXT: ret i1 [[TOBOOL4]]
;
%conv = zext i1 %a to i32
%conv3.neg = sext i8 %b to i32
%tobool4 = icmp eq i32 %conv, %conv3.neg
ret i1 %tobool4
}
define <2 x i1> @zext_ne_sext(<2 x i1> %a, <2 x i1> %b) {
; CHECK-LABEL: @zext_ne_sext(
; CHECK-NEXT: [[CONV:%.*]] = zext <2 x i1> [[A:%.*]] to <2 x i8>
; CHECK-NEXT: [[CONV3_NEG:%.*]] = sext <2 x i1> [[B:%.*]] to <2 x i8>
; CHECK-NEXT: [[TOBOOL4:%.*]] = icmp ne <2 x i8> [[CONV3_NEG]], [[CONV]]
; CHECK-NEXT: ret <2 x i1> [[TOBOOL4]]
;
%conv = zext <2 x i1> %a to <2 x i8>
%conv3.neg = sext <2 x i1> %b to <2 x i8>
%tobool4 = icmp ne <2 x i8> %conv3.neg, %conv
ret <2 x i1> %tobool4
}