This is an archive of the discontinued LLVM Phabricator instance.

Differential D154473

[clang][Tooling] Add mapping for make_error_code
ClosedPublic

Authored by kadircet on Jul 4 2023, 11:21 PM.

Details

Reviewers
hokein
Commits
rG80c679220038: [clang][Tooling] Add mapping for make_error_code

Diff Detail

Event Timeline

kadircet created this revision.Jul 4 2023, 11:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2023, 11:21 PM
kadircet requested review of this revision.Jul 4 2023, 11:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2023, 11:21 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B243134: Diff 537226.Jul 4 2023, 11:48 PM
hokein accepted this revision.Jul 4 2023, 11:57 PM
hokein added inline comments.
clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc
353

nit: maybe add make_error_condition as well.

This revision is now accepted and ready to land.Jul 4 2023, 11:57 PM
This revision was landed with ongoing or failed builds.Jul 5 2023, 12:35 AM
Closed by commit rG80c679220038: [clang][Tooling] Add mapping for make_error_code (authored by kadircet). · Explain Why
This revision was automatically updated to reflect the committed changes.
kadircet added a commit: rG80c679220038: [clang][Tooling] Add mapping for make_error_code.

Revision Contents

PathSize
clang/
lib/
Tooling/
Inclusions/
Stdlib/
4 lines

Diff 537226

clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc

Show First 20 Lines • Show All 341 Lines • ▼ Show 20 Lines
SYMBOL(atomic_ushort, None, <stdatomic.h>) SYMBOL(atomic_ushort, None, <stdatomic.h>)
SYMBOL(atomic_wchar_t, std::, <atomic>) SYMBOL(atomic_wchar_t, std::, <atomic>)
SYMBOL(atomic_wchar_t, None, <stdatomic.h>) SYMBOL(atomic_wchar_t, None, <stdatomic.h>)
// std::get has a few variants for different types (tuple, array, pair etc) // std::get has a few variants for different types (tuple, array, pair etc)
// which is tricky to disambiguate without type information. // which is tricky to disambiguate without type information.
// Don't set any header for it, as it comes with the type header. // Don't set any header for it, as it comes with the type header.
SYMBOL(get, std::, /*no headers*/) SYMBOL(get, std::, /*no headers*/)
// Similarly make_error_code also has different overloads (errc, io_errc,
// future_errc) and each of them are provided by relevant headers providing the
// type.
SYMBOL(make_error_code, std::, /*no headers*/)
hokeinUnsubmitted
Not Done
ReplyInline Actions

nit: maybe add make_error_condition as well.

hokein: nit: maybe add `make_error_condition` as well.
// cppreference symbol index page was missing these symbols. // cppreference symbol index page was missing these symbols.
// Remove them when the cppreference offline archive catches up. // Remove them when the cppreference offline archive catches up.
SYMBOL(index_sequence, std::, <utility>) SYMBOL(index_sequence, std::, <utility>)
SYMBOL(index_sequence_for, std::, <utility>) SYMBOL(index_sequence_for, std::, <utility>)
SYMBOL(make_index_sequence, std::, <utility>) SYMBOL(make_index_sequence, std::, <utility>)
SYMBOL(make_integer_sequence, std::, <utility>) SYMBOL(make_integer_sequence, std::, <utility>)
▲ Show 20 Lines • Show All 360 Lines • Show Last 20 Lines