This is an archive of the discontinued LLVM Phabricator instance.

[Sanitizers][Darwin][Test] Mark symbolize_pc test unsupported in Darwin/LSan context
ClosedPublic

Authored by wrotki on Jul 3 2023, 1:53 PM.

Details

Summary

LSan is unsupported on Darwin anyway, and this test fals on public Darwin bots

Diff Detail

Event Timeline

wrotki created this revision.Jul 3 2023, 1:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 1:53 PM
Herald added a subscriber: Enna1. · View Herald Transcript
wrotki requested review of this revision.Jul 3 2023, 1:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 1:53 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
rsundahl accepted this revision.Jul 5 2023, 8:30 AM

LGTM. Thanks @wrotki!

This revision is now accepted and ready to land.Jul 5 2023, 8:30 AM
hans added a subscriber: hans.Jul 6 2023, 3:04 AM

Somehow this seems to have made it worse on the bot: https://green.lab.llvm.org/green/view/Clang/job/clang-stage1-RA/34927/

Now it's failing

SanitizerCommon-tsan-x86_64-Darwin.SanitizerCommon-tsan-x86_64-Darwin.symbolize_pc.cpp
SanitizerCommon-tsan-x86_64h-Darwin.SanitizerCommon-tsan-x86_64h-Darwin.symbolize_pc.cpp
SanitizerCommon-ubsan-x86_64-Darwin.SanitizerCommon-ubsan-x86_64-Darwin.symbolize_pc.cpp
SanitizerCommon-ubsan-x86_64h-Darwin.SanitizerCommon-ubsan-x86_64h-Darwin.symbolize_pc.cpp

instead.

We also saw those in Chromium after this change (http://crbug.com/1462534), but they passed on the next build, so perhaps this test is just flaky on Mac somehow?

This test was failing before w. Tsan and Ubsan, but these failures disappeared, only failures were lean. I'd guess that just disabling lean will leave things clean, but it apparently didn't.

Will look into Tsan/UBsan failures

s/lean/lsan/ above. My spell checker is driving me nuts.