[flang] Prevent lowering crash by properly updating symbol pointer

[klausler]

Summary

Kind of an edge case. When a MODULE FUNCTION or SUBROUTINE
interface is defined by a MODULE PROCEDURE in the same program
unit, ensure that the symbol table pointer in the parse tree is
updated to point to the SubprogramDetails symbol for the
interface, and not left pointing to what should soon become
a dead SubprogramNameDetails symbol.

[vzakhari]

Thank you!

flang/lib/Semantics/resolve-names.cpp

bool SubprogramVisitor::BeginMpSubprogram(const parser::Name &name) {
   if (!symbol) {
     return false;
   }
   if (symbol->owner() == currScope() && symbol->scope()) {
     // This is a MODULE PROCEDURE whose interface appears in its host.
     // Convert the module procedure's interface into a subprogram.
     SetScope(DEREF(symbol->scope()));
     symbol->get<SubprogramDetails>().set_isInterface(false);
+    name.symbol = symbol;
   } else {
     // Copy the interface into a new subprogram scope.
     EraseSymbol(name);
     Symbol &newSymbol{MakeSymbol(name, SubprogramDetails{})};
     PushScope(Scope::Kind::Subprogram, &newSymbol);
     newSymbol.get<SubprogramDetails>().set_moduleInterface(*symbol);
     newSymbol.attrs() |= symbol->attrs();
     newSymbol.set(symbol->test(Symbol::Flag::Subroutine)
             ? Symbol::Flag::Subroutine
             : Symbol::Flag::Function);
     MapSubprogramToNewSymbols(*symbol, newSymbol, currScope());
   }
   return true;
 }
 
 // A subprogram or interface declared with SUBROUTINE or FUNCTION
 bool SubprogramVisitor::BeginSubprogram(const parser::Name &name,
     Symbol::Flag subpFlag, bool hasModulePrefix,
     const parser::LanguageBindingSpec *bindingSpec,
     const ProgramTree::EntryStmtList *entryStmts) {
-  if (hasModulePrefix && currScope().IsGlobal()) { // C1547
+  if (hasModulePrefix && !currScope().IsModule() &&
+      !currScope().IsSubmodule()) { // C1547
     Say(name,
         "'%s' is a MODULE procedure which must be declared within a "
         "MODULE or SUBMODULE"_err_en_US);
     return false;
   }
   Symbol *moduleInterface{nullptr};
   if (hasModulePrefix && !inInterfaceBlock()) {
     moduleInterface = FindSeparateModuleProcedureInterface(name);

flang/test/Semantics/symbol28.f90

interface s
   !DEF: /m2/s2 MODULE, PUBLIC (Subroutine) Subprogram
   !DEF: /m2/s2/j INTENT(IN) ObjectEntity INTEGER(4)
   module subroutine s2 (j)
    !REF: /m2/s2/j
    integer, intent(in) :: j
   end subroutine
  end interface
 contains
- !DEF: /m2/s MODULE SubprogramName
+ !REF:/m2/s
  module procedure s
  end procedure
  !DEF: /m2/s2 MODULE, PUBLIC (Subroutine) Subprogram
  !DEF: /m2/s2/j INTENT(IN) ObjectEntity INTEGER(4)
  module subroutine s2 (j)
   !REF: /m2/s2/j
   integer, intent(in) :: j
  end subroutine
  !DEF: /m2/test PUBLIC (Subroutine) Subprogram
  subroutine test
   !REF: /m2/s
   call s
   !REF: /m2/s2
   call s(1)
  end subroutine
 end module