This is an archive of the discontinued LLVM Phabricator instance.

Differential D154279

[libc] Check if the hermetic test target exists
ClosedPublic

Authored by phosek on Jun 30 2023, 8:41 PM.

Details

Reviewers
michaelrj
sivachandra
Commits
rG80368a104e09: [libc] Check if the hermetic test target exists
Summary

When crt1 isn't available, which is typical on baremetal, hermetic tests
aren't created and the hermetic test target won't be available.

Diff Detail

Event Timeline

phosek created this revision.Jun 30 2023, 8:41 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 30 2023, 8:41 PM
Herald added subscribers: libc-commits, abidh. · View Herald Transcript
phosek requested review of this revision.Jun 30 2023, 8:41 PM
Harbormaster completed remote builds in B242615: Diff 536505.Jun 30 2023, 9:04 PM
sivachandra accepted this revision.Jul 5 2023, 12:49 AM
This revision is now accepted and ready to land.Jul 5 2023, 12:49 AM
This revision was landed with ongoing or failed builds.Jul 5 2023, 10:09 AM
Closed by commit rG80368a104e09: [libc] Check if the hermetic test target exists (authored by phosek). · Explain Why
This revision was automatically updated to reflect the committed changes.
phosek added a commit: rG80368a104e09: [libc] Check if the hermetic test target exists.

Revision Contents

PathSize
libc/
cmake/
modules/
2 lines

Diff 537409

libc/cmake/modules/LLVMLibCTestRules.cmake

Show First 20 Lines • Show All 741 Lines • ▼ Show 20 Lines cmake_parse_arguments(
${ARGN} ${ARGN}
) )
if(LIBC_ENABLE_UNITTESTS AND NOT LIBC_TEST_HERMETIC_TEST_ONLY) if(LIBC_ENABLE_UNITTESTS AND NOT LIBC_TEST_HERMETIC_TEST_ONLY)
add_libc_unittest(${test_name}.__unit__ ${LIBC_TEST_UNPARSED_ARGUMENTS}) add_libc_unittest(${test_name}.__unit__ ${LIBC_TEST_UNPARSED_ARGUMENTS})
endif() endif()
if(LIBC_ENABLE_HERMETIC_TESTS AND NOT LIBC_TEST_UNIT_TEST_ONLY) if(LIBC_ENABLE_HERMETIC_TESTS AND NOT LIBC_TEST_UNIT_TEST_ONLY)
add_libc_hermetic_test(${test_name}.__hermetic__ ${LIBC_TEST_UNPARSED_ARGUMENTS}) add_libc_hermetic_test(${test_name}.__hermetic__ ${LIBC_TEST_UNPARSED_ARGUMENTS})
get_fq_target_name(${test_name} fq_test_name) get_fq_target_name(${test_name} fq_test_name)
if(TARGET ${fq_test_name}.__unit__) if(TARGET ${fq_test_name}.__hermetic__ AND TARGET ${fq_test_name}.__unit__)
# Tests like the file tests perform file operations on disk file. If we # Tests like the file tests perform file operations on disk file. If we
# don't chain up the unit test and hermetic test, then those tests will # don't chain up the unit test and hermetic test, then those tests will
# step on each other's files. # step on each other's files.
add_dependencies(${fq_test_name}.__hermetic__ ${fq_test_name}.__unit__) add_dependencies(${fq_test_name}.__hermetic__ ${fq_test_name}.__unit__)
endif() endif()
endif() endif()
endfunction(add_libc_test) endfunction(add_libc_test)