This is an archive of the discontinued LLVM Phabricator instance.

[TOSA] Add level checks and remove Tensor1DTo4D
ClosedPublic

Authored by Tai78641 on Jun 30 2023, 4:31 PM.

Details

Summary

Remove Tosa_Tensor1Dto4D and Tosa_TensorUpto4D in the Tosa Dialect
and added level checks to TosaValidation pass to validate per spec.

Signed-off-by: Tai Ly <tai.ly@arm.com>
Change-Id: Icd32137e9f8051f99994cee9f388f20c1a840f4b

Diff Detail

Event Timeline

Tai78641 created this revision.Jun 30 2023, 4:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2023, 4:31 PM
Tai78641 requested review of this revision.Jun 30 2023, 4:31 PM
mgehre-amd added inline comments.Jul 4 2023, 12:33 AM
mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
79

This is missing MAX_LOG2_SIZE - on purpose? Maybe leave a comment here that a check for that part of the level is not implemented yet?

Tai78641 updated this revision to Diff 537763.Jul 6 2023, 9:18 AM

added comment per review suggestion

Tai78641 marked an inline comment as done.Jul 6 2023, 9:21 AM
Tai78641 added inline comments.
mlir/lib/Dialect/Tosa/Transforms/TosaValidation.cpp
79

thanks for the review. will add MAX_LOG2_SIZE in follow on patch.

eric-k256 accepted this revision.Jul 7 2023, 1:44 PM

Looks good to me.

This revision is now accepted and ready to land.Jul 7 2023, 1:44 PM
This revision was automatically updated to reflect the committed changes.