This is an archive of the discontinued LLVM Phabricator instance.

Differential D154256

[libc] Add missing cast in x86 big_endian_cmp_mask
ClosedPublic

Authored by mcgrathr on Jun 30 2023, 1:29 PM.

Details

Reviewers
gchatelet
Caslyn
michaelrj
Commits
rGdbd38b121920: [libc] Add missing cast in x86 big_endian_cmp_mask
Summary

Implicit narrowing conversions from int to uint16_t
get a compiler warning with the warning settings used
in the Fuchsia build.

Diff Detail

Event Timeline

mcgrathr created this revision.Jun 30 2023, 1:29 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 30 2023, 1:29 PM
Herald added a subscriber: libc-commits. · View Herald Transcript
mcgrathr requested review of this revision.Jun 30 2023, 1:29 PM
Harbormaster completed remote builds in B242535: Diff 536397.Jun 30 2023, 1:36 PM
michaelrj accepted this revision.Jun 30 2023, 1:39 PM

LGTM

This revision is now accepted and ready to land.Jun 30 2023, 1:39 PM
This revision was landed with ongoing or failed builds.Jun 30 2023, 2:16 PM
Closed by commit rGdbd38b121920: [libc] Add missing cast in x86 big_endian_cmp_mask (authored by mcgrathr). · Explain Why
This revision was automatically updated to reflect the committed changes.
mcgrathr added a commit: rGdbd38b121920: [libc] Add missing cast in x86 big_endian_cmp_mask.

Revision Contents

PathSize
libc/
src/
string/
memory_utils/
2 lines

Diff 536425

libc/src/string/memory_utils/op_x86.h

Show First 20 Lines • Show All 123 Lines • ▼ Show 20 Lines
LIBC_INLINE __m128i bytewise_max(__m128i a, __m128i b) { LIBC_INLINE __m128i bytewise_max(__m128i a, __m128i b) {
return _mm_max_epu8(a, b); return _mm_max_epu8(a, b);
} }
LIBC_INLINE __m128i bytewise_reverse(__m128i value) { LIBC_INLINE __m128i bytewise_reverse(__m128i value) {
return _mm_shuffle_epi8(value, _mm_set_epi8(0, 1, 2, 3, 4, 5, 6, 7, // return _mm_shuffle_epi8(value, _mm_set_epi8(0, 1, 2, 3, 4, 5, 6, 7, //
8, 9, 10, 11, 12, 13, 14, 15)); 8, 9, 10, 11, 12, 13, 14, 15));
} }
LIBC_INLINE uint16_t big_endian_cmp_mask(__m128i max, __m128i value) { LIBC_INLINE uint16_t big_endian_cmp_mask(__m128i max, __m128i value) {
return _mm_movemask_epi8(bytewise_reverse(_mm_cmpeq_epi8(max, value))); return static_cast<uint16_t>(_mm_movemask_epi8(bytewise_reverse(_mm_cmpeq_epi8(max, value))));
} }
template <> LIBC_INLINE bool eq<__m128i>(CPtr p1, CPtr p2, size_t offset) { template <> LIBC_INLINE bool eq<__m128i>(CPtr p1, CPtr p2, size_t offset) {
const auto a = load<__m128i>(p1, offset); const auto a = load<__m128i>(p1, offset);
const auto b = load<__m128i>(p2, offset); const auto b = load<__m128i>(p2, offset);
const auto xored = _mm_xor_si128(a, b); const auto xored = _mm_xor_si128(a, b);
return _mm_testz_si128(xored, xored) == 1; // 1 iff xored == 0 return _mm_testz_si128(xored, xored) == 1; // 1 iff xored == 0
} }
template <> LIBC_INLINE uint32_t neq<__m128i>(CPtr p1, CPtr p2, size_t offset) { template <> LIBC_INLINE uint32_t neq<__m128i>(CPtr p1, CPtr p2, size_t offset) {
▲ Show 20 Lines • Show All 114 Lines • Show Last 20 Lines