This is a follow-up to r252385.
For some reason, I missed a lot of cases when the visibility attribute was applied to the definition, but not to an earlier declaration.
Details
Details
- Reviewers
mclow.lists EricWF
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
I've updated the diff so it merges and also fixed <ostream>, <istream>, <sstream> and <streambuf>. It can be found here: https://gist.github.com/EricWF/487e5b1de2bb320e93fbb3c9c758b013
Comment Actions
It seems my changes to the IO headers removes a bunch of symbols from the dylib. I'll look into it. I'm assuming it's because clang was already ignoring the "_LIBCPP_INLINE_VISIBILITY" attribute when instantiating extern templates. The symbols get removed even if we don't build with "internal_linkage".
Comment Actions
So you pointed out that my changes to the streams is not ABI compatible. Obviously that cannot be a part of this patch then.
Comment Actions
Updates with Eric's patch from
https://gist.github.com/EricWF/487e5b1de2bb320e93fbb3c9c758b013
without the iostream changes.