This is an archive of the discontinued LLVM Phabricator instance.

Differential D154005

[InstCombine] Add tests for folding `@llvm.ptrmask` with itself; NFC
ClosedPublic

Authored by goldstein.w.n on Jun 28 2023, 2:17 PM.

Details

Reviewers
nikic
RKSimon
Commits
rGaa88df8521e3: [InstCombine] Add tests for folding `@llvm.ptrmask` with itself; NFC

Diff Detail

Event Timeline

goldstein.w.n created this revision.Jun 28 2023, 2:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2023, 2:17 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
goldstein.w.n requested review of this revision.Jun 28 2023, 2:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2023, 2:17 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a child revision: D154006: [InstCombine] Folding `@llvm.ptrmask` with itself.Jun 28 2023, 2:17 PM
Harbormaster completed remote builds in B241893: Diff 535526.Jun 28 2023, 4:02 PM
goldstein.w.n updated this revision to Diff 535557.Jun 28 2023, 4:12 PM

Rebase

Harbormaster completed remote builds in B241916: Diff 535557.Jun 28 2023, 5:17 PM
nikic added inline comments.Jun 29 2023, 12:12 AM
llvm/test/Transforms/InstCombine/consecutive-ptrmask.ll
5

This should be @llvm.ptrmask.p0.i64.

goldstein.w.n marked an inline comment as done.Jun 29 2023, 12:36 AM
goldstein.w.n updated this revision to Diff 535657.Jun 29 2023, 12:36 AM

declare exact function for i64

nikic accepted this revision.Jun 29 2023, 12:38 AM

LGTM

This revision is now accepted and ready to land.Jun 29 2023, 12:38 AM
Harbormaster completed remote builds in B241993: Diff 535657.Jun 29 2023, 1:39 AM
Closed by commit rGaa88df8521e3: [InstCombine] Add tests for folding `@llvm.ptrmask` with itself; NFC (authored by goldstein.w.n). · Explain WhyJul 27 2023, 3:43 PM
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rGaa88df8521e3: [InstCombine] Add tests for folding `@llvm.ptrmask` with itself; NFC.

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
67 lines

Diff 535657

llvm/test/Transforms/InstCombine/consecutive-ptrmask.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 2
; RUN: opt < %s -passes=instcombine -S | FileCheck %s
declare ptr @llvm.ptrmask.p0.i64(ptr, i64)
declare ptr @llvm.ptrmask.p0.i32(ptr, i32)
nikicUnsubmitted
Done
ReplyInline Actions

This should be @llvm.ptrmask.p0.i64.

nikic: This should be `@llvm.ptrmask.p0.i64`.
declare void @use.ptr(ptr)
define ptr @fold_2x(ptr %p, i64 %m0, i64 %m1) {
; CHECK-LABEL: define ptr @fold_2x
; CHECK-SAME: (ptr [[P:%.*]], i64 [[M0:%.*]], i64 [[M1:%.*]]) {
; CHECK-NEXT: [[P0:%.*]] = call ptr @llvm.ptrmask.p0.i64(ptr [[P]], i64 [[M0]])
; CHECK-NEXT: [[P1:%.*]] = call ptr @llvm.ptrmask.p0.i64(ptr [[P0]], i64 [[M1]])
; CHECK-NEXT: ret ptr [[P1]]
;
%p0 = call ptr @llvm.ptrmask.p0.i64(ptr %p, i64 %m0)
%p1 = call ptr @llvm.ptrmask.p0.i64(ptr %p0, i64 %m1)
ret ptr %p1
}
define ptr @fold_2x_i32(ptr %p, i32 %m0, i32 %m1) {
; CHECK-LABEL: define ptr @fold_2x_i32
; CHECK-SAME: (ptr [[P:%.*]], i32 [[M0:%.*]], i32 [[M1:%.*]]) {
; CHECK-NEXT: [[P0:%.*]] = call ptr @llvm.ptrmask.p0.i32(ptr [[P]], i32 [[M0]])
; CHECK-NEXT: [[P1:%.*]] = call ptr @llvm.ptrmask.p0.i32(ptr [[P0]], i32 [[M1]])
; CHECK-NEXT: ret ptr [[P1]]
;
%p0 = call ptr @llvm.ptrmask.p0.i32(ptr %p, i32 %m0)
%p1 = call ptr @llvm.ptrmask.p0.i32(ptr %p0, i32 %m1)
ret ptr %p1
}
define ptr @fold_2x_fail_multiuse(ptr %p, i64 %m0, i64 %m1) {
; CHECK-LABEL: define ptr @fold_2x_fail_multiuse
; CHECK-SAME: (ptr [[P:%.*]], i64 [[M0:%.*]], i64 [[M1:%.*]]) {
; CHECK-NEXT: [[P0:%.*]] = call ptr @llvm.ptrmask.p0.i64(ptr [[P]], i64 [[M0]])
; CHECK-NEXT: call void @use.ptr(ptr [[P0]])
; CHECK-NEXT: [[P1:%.*]] = call ptr @llvm.ptrmask.p0.i64(ptr [[P0]], i64 [[M1]])
; CHECK-NEXT: ret ptr [[P1]]
;
%p0 = call ptr @llvm.ptrmask.p0.i64(ptr %p, i64 %m0)
call void @use.ptr(ptr %p0)
%p1 = call ptr @llvm.ptrmask.p0.i64(ptr %p0, i64 %m1)
ret ptr %p1
}
define ptr @fold_2x_fail_type_mismatch(ptr %p, i32 %m0, i64 %m1) {
; CHECK-LABEL: define ptr @fold_2x_fail_type_mismatch
; CHECK-SAME: (ptr [[P:%.*]], i32 [[M0:%.*]], i64 [[M1:%.*]]) {
; CHECK-NEXT: [[P0:%.*]] = call ptr @llvm.ptrmask.p0.i32(ptr [[P]], i32 [[M0]])
; CHECK-NEXT: [[P1:%.*]] = call ptr @llvm.ptrmask.p0.i64(ptr [[P0]], i64 [[M1]])
; CHECK-NEXT: ret ptr [[P1]]
;
%p0 = call ptr @llvm.ptrmask.p0.i32(ptr %p, i32 %m0)
%p1 = call ptr @llvm.ptrmask.p0.i64(ptr %p0, i64 %m1)
ret ptr %p1
}
define ptr @fold_2x_fail_type_mismatch2(ptr %p, i64 %m0, i32 %m1) {
; CHECK-LABEL: define ptr @fold_2x_fail_type_mismatch2
; CHECK-SAME: (ptr [[P:%.*]], i64 [[M0:%.*]], i32 [[M1:%.*]]) {
; CHECK-NEXT: [[P0:%.*]] = call ptr @llvm.ptrmask.p0.i64(ptr [[P]], i64 [[M0]])
; CHECK-NEXT: [[P1:%.*]] = call ptr @llvm.ptrmask.p0.i32(ptr [[P0]], i32 [[M1]])
; CHECK-NEXT: ret ptr [[P1]]
;
%p0 = call ptr @llvm.ptrmask.p0.i64(ptr %p, i64 %m0)
%p1 = call ptr @llvm.ptrmask.p0.i32(ptr %p0, i32 %m1)
ret ptr %p1
}