Those were found while trying to enable configurations like no-threads
and no-localization with Clang modules enabled.
Details
- Reviewers
Mordante - Group Reviewers
Restricted Project - Commits
- rG60a6a0d17ad5: [libc++] Add missing includes
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Can you update the commit message by specifying which modules, I assume the clang ones, but the changes to libcxx/test/std/utilities/format/types.compile.pass.cpp suggest the std module.
LGTM when the CI passes.
libcxx/include/regex | ||
---|---|---|
801 | According the the CI at least this header is not in alphabetic order. | |
libcxx/test/std/input.output/file.streams/fstreams/ifstream.cons/path.pass.cpp | ||
23–27 | This is now in alphabetic order, in .clang-format we explicitly disable that for the tests. Any objections when I make a patch to remove that from that file. Then new tests are automatically formatted with headers sorted. |
This was for Clang modules. I updated the commit message!
libcxx/include/regex | ||
---|---|---|
801 | Thanks -- apparently VS Code disagrees with every other tool about what it means to be sorted. | |
libcxx/test/std/input.output/file.streams/fstreams/ifstream.cons/path.pass.cpp | ||
23–27 | I don't think I'd have an objection, however I think you might hit some actual blockers while trying to do that? We probably have tests where the order of includes is important? In that case I guess we could always use // clang-format on/off around the #includes. |
Thanks for updating the message!
libcxx/include/regex | ||
---|---|---|
801 | Maybe is uses locales ;-) | |
libcxx/test/std/input.output/file.streams/fstreams/ifstream.cons/path.pass.cpp | ||
23–27 | Actually I think that is a good reason *not* to do it. Then formatting in the future may accidentally "break" a test. It still would be good when test call out the order is important. |
Nit, this is definitely not NFC, because why else would we do it?
I think we should use NFC less because it's rarely true.
According the the CI at least this header is not in alphabetic order.