These are the cases when an out-of-class definition of a method is marked _LIBCPP_INLINE_VISIBILITY, but the in-class declaration is not. This will start failing when (or if) we switch to attribute((internal_linkage)).
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
LGTM. For clang this patch should have no functionality change because clang allows attributes to appear only in the declaration. GCC however was previously ignoring the attributes and only now will it mark those functions as hidden. I don't think this will be an issue though. Do you agree?