This is an archive of the discontinued LLVM Phabricator instance.

Differential D153730

[NFC] Generalize llvm-profgen message to cover both AutoFDO and CSSPGO
ClosedPublic

Authored by wenlei on Jun 25 2023, 4:40 PM.

Details

Reviewers
hoy
wlei
Commits
rG1a0d23efe157: [NFC] Generalize llvm-profgen message to cover both AutoFDO and CSSPGO
Summary

Update llvm-profgen profile density message to cover both AutoFDO and CSSPGO.

Diff Detail

Event Timeline

wenlei created this revision.Jun 25 2023, 4:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 25 2023, 4:40 PM
Herald added a subscriber: modimo. · View Herald Transcript
wenlei requested review of this revision.Jun 25 2023, 4:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 25 2023, 4:40 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B241059: Diff 534382.Jun 25 2023, 5:26 PM
wlei accepted this revision.Jun 26 2023, 9:06 AM

LGTM, thanks.

This revision is now accepted and ready to land.Jun 26 2023, 9:06 AM
This revision was landed with ongoing or failed builds.Jun 26 2023, 9:48 AM
Closed by commit rG1a0d23efe157: [NFC] Generalize llvm-profgen message to cover both AutoFDO and CSSPGO (authored by wenlei). · Explain Why
This revision was automatically updated to reflect the committed changes.
wenlei added a commit: rG1a0d23efe157: [NFC] Generalize llvm-profgen message to cover both AutoFDO and CSSPGO.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-profgen/
2 lines
tools/
llvm-profgen/
2 lines

Diff 534619

llvm/test/tools/llvm-profgen/profile-density.test

; RUN: llvm-profgen --format=text --unsymbolized-profile=%S/Inputs/profile-density.raw.prof --binary=%S/Inputs/inline-noprobe2.perfbin --output=%t1 --use-offset=0 --show-density -hot-function-density-threshold=10 --trim-cold-profile=0 &> %t2 ; RUN: llvm-profgen --format=text --unsymbolized-profile=%S/Inputs/profile-density.raw.prof --binary=%S/Inputs/inline-noprobe2.perfbin --output=%t1 --use-offset=0 --show-density -hot-function-density-threshold=10 --trim-cold-profile=0 &> %t2
; RUN: FileCheck %s --input-file %t2 --check-prefix=CHECK-DENSITY ; RUN: FileCheck %s --input-file %t2 --check-prefix=CHECK-DENSITY
; RUN: llvm-profgen --format=text --unsymbolized-profile=%S/Inputs/profile-density-cs.raw.prof --binary=%S/Inputs/inline-noprobe2.perfbin --output=%t3 --show-density -hot-function-density-threshold=1 &> %t4 ; RUN: llvm-profgen --format=text --unsymbolized-profile=%S/Inputs/profile-density-cs.raw.prof --binary=%S/Inputs/inline-noprobe2.perfbin --output=%t3 --show-density -hot-function-density-threshold=1 &> %t4
; RUN: FileCheck %s --input-file %t4 --check-prefix=CHECK-DENSITY-CS ; RUN: FileCheck %s --input-file %t4 --check-prefix=CHECK-DENSITY-CS
;CHECK-DENSITY: AutoFDO is estimated to optimize better with 3.1x more samples. Please consider increasing sampling rate or profiling for longer duration to get more samples. ;CHECK-DENSITY: Sample PGO is estimated to optimize better with 3.1x more samples. Please consider increasing sampling rate or profiling for longer duration to get more samples.
;CHECK-DENSITY: Minimum profile density for hot functions with top 99.00% total samples: 3.2 ;CHECK-DENSITY: Minimum profile density for hot functions with top 99.00% total samples: 3.2
;CHECK-DENSITY-CS: Minimum profile density for hot functions with top 99.00% total samples: 128.3 ;CHECK-DENSITY-CS: Minimum profile density for hot functions with top 99.00% total samples: 128.3
; original code: ; original code:
; clang -O3 -g -fno-optimize-sibling-calls -fdebug-info-for-profiling qsort.c -o a.out ; clang -O3 -g -fno-optimize-sibling-calls -fdebug-info-for-profiling qsort.c -o a.out
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines

llvm/tools/llvm-profgen/ProfileGenerator.cpp

Show First 20 Lines • Show All 177 Lines • ▼ Show 20 Lines
} }
void ProfileGeneratorBase::showDensitySuggestion(double Density) { void ProfileGeneratorBase::showDensitySuggestion(double Density) {
if (Density == 0.0) if (Density == 0.0)
WithColor::warning() << "The --profile-summary-cutoff-hot option may be " WithColor::warning() << "The --profile-summary-cutoff-hot option may be "
"set too low. Please check your command.\n"; "set too low. Please check your command.\n";
else if (Density < HotFunctionDensityThreshold) else if (Density < HotFunctionDensityThreshold)
WithColor::warning() WithColor::warning()
<< "AutoFDO is estimated to optimize better with " << "Sample PGO is estimated to optimize better with "
<< format("%.1f", HotFunctionDensityThreshold / Density) << format("%.1f", HotFunctionDensityThreshold / Density)
<< "x more samples. Please consider increasing sampling rate or " << "x more samples. Please consider increasing sampling rate or "
"profiling for longer duration to get more samples.\n"; "profiling for longer duration to get more samples.\n";
if (ShowDensity) if (ShowDensity)
outs() << "Minimum profile density for hot functions with top " outs() << "Minimum profile density for hot functions with top "
<< format("%.2f", << format("%.2f",
static_cast<double>(ProfileSummaryCutoffHot.getValue()) / static_cast<double>(ProfileSummaryCutoffHot.getValue()) /
▲ Show 20 Lines • Show All 1,080 Lines • Show Last 20 Lines