[scudo] Fix data leak in wrappers_c_test.cpp

[Riley-Roberts]

Summary

In SmallAlign implemented deallocation for the pointers

[cryptoad]

compiler-rt/lib/scudo/standalone/tests/wrappers_c_test.cpp

124

File probably could use some clang-format'ing

[cferris]

compiler-rt/lib/scudo/standalone/tests/wrappers_c_test.cpp

120–128

As we discussed offline, you need to update this comment and the one below.

Adding this to give you experience about how to resolve comment in phabricator.

[Riley-Roberts]

In SmallAlign implemented deallocation for the pointers

Test: m scudo_wrappers_unit_tests

[cferris]

compiler-rt/lib/scudo/standalone/tests/wrappers_c_test.cpp

121

This looks like an error, possibly pulled the line below into the comment.

123

I think "during" is a better word to use here. That describes that you don't want any allocations to happen while the test is running.

[Riley-Roberts]

In SmallAlign implemented deallocation for the pointers

Test: m scudo_wrappers_unit_tests

[Riley-Roberts]

In SmallAlign implemented deallocation for the pointers

Test: m scudo_wrappers_unit_tests

[cferris]

compiler-rt/lib/scudo/standalone/tests/wrappers_c_test.cpp

122

This can fit on the line above.

Also, it might be better to say something about hitting many sizes in the primary and also to allocate out of the secondary.

I said this would hit every size class in the primary, but that's not true, doing every power of 2 is not guaranteed to do that.

[Riley-Roberts]

In SmallAlign implemented deallocation for the pointers

Test: m scudo_wrappers_unit_tests

[Chia-hungDuan]

Please remove the line

Test: m scudo_wrappers_unit_tests

in the commit message and update the summary here.

Other than that, LGTM! Please wait for @cferris 's approval.

[cferris]

I'll take of landing this.

compiler-rt/lib/scudo/standalone/tests/wrappers_c_test.cpp

 //===-- wrappers_c_test.cpp -------------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
+#include "common.h"
 #include "memtag.h"
 #include "scudo/interface.h"
 #include "tests/scudo_unit_test.h"
 
 #include <errno.h>
 #include <limits.h>
 #include <malloc.h>
 #include <stdlib.h>
 #include <unistd.h>
+#include <vector>
 
 #ifndef __GLIBC_PREREQ
 #define __GLIBC_PREREQ(x, y) 0
 #endif
 
 #if SCUDO_FUCHSIA
 // Fuchsia only has valloc
 #define HAVE_VALLOC 1
TEST(ScudoWrappersCTest, Calloc) {
   if (SCUDO_ANDROID)
     EXPECT_EQ(errno, ENOMEM);
   errno = 0;
   EXPECT_EQ(calloc(SIZE_MAX, SIZE_MAX), nullptr);
   EXPECT_EQ(errno, ENOMEM);
 }
 
 TEST(ScudoWrappersCTest, SmallAlign) {
-  void *P;
-  for (size_t Size = 1; Size <= 0x10000; Size <<= 1) {
-    for (size_t Align = 1; Align <= 0x10000; Align <<= 1) {
+  // Allocating pointers by the powers of 2 from 1 to 0x10000
+  // Using powers of 2 due to memalign using powers of 2 and test more sizes
+  constexpr size_t MaxSize = 0x10000;
+  std::vector<void *> ptrs;
+  // Reserving space to prevent further allocation during the test
+  ptrs.reserve((scudo::getLeastSignificantSetBitIndex(MaxSize) + 1) *
+               (scudo::getLeastSignificantSetBitIndex(MaxSize) + 1) * 3);
+  for (size_t Size = 1; Size <= MaxSize; Size <<= 1) {
+    for (size_t Align = 1; Align <= MaxSize; Align <<= 1) {
       for (size_t Count = 0; Count < 3; ++Count) {
-        P = memalign(Align, Size);
+        void *P = memalign(Align, Size);
         EXPECT_TRUE(reinterpret_cast<uintptr_t>(P) % Align == 0);
+        ptrs.push_back(P);
       }
     }
   }
+  for (void *ptr : ptrs)
+    free(ptr);
 }
 
 TEST(ScudoWrappersCTest, Memalign) {
   void *P;
   for (size_t I = FIRST_32_SECOND_64(2U, 3U); I <= 18U; I++) {
     const size_t Alignment = 1U << I;
 
     P = memalign(Alignment, Size);