This is an archive of the discontinued LLVM Phabricator instance.

Differential D153440

Fix a memory leak in the Python implementation of bytecode writer
ClosedPublic

Authored by apaszke on Jun 21 2023, 9:37 AM.

Details

Reviewers
jpienaar
Commits
rG9816cc916f56: Fix a memory leak in the Python implementation of bytecode writer
Summary

The bytecode writer config was heap-allocated, but was never freed, causing ASAN errors.

Diff Detail

Event Timeline

apaszke created this revision.Jun 21 2023, 9:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2023, 9:37 AM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 21 others. · View Herald Transcript
apaszke requested review of this revision.Jun 21 2023, 9:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2023, 9:38 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
jpienaar accepted this revision.Jun 21 2023, 9:38 AM
This revision is now accepted and ready to land.Jun 21 2023, 9:38 AM
This revision was landed with ongoing or failed builds.Jun 21 2023, 9:41 AM
Closed by commit rG9816cc916f56: Fix a memory leak in the Python implementation of bytecode writer (authored by apaszke, committed by jpienaar). · Explain Why
This revision was automatically updated to reflect the committed changes.
jpienaar added a commit: rG9816cc916f56: Fix a memory leak in the Python implementation of bytecode writer.
Harbormaster completed remote builds in B240275: Diff 533301.Jun 21 2023, 9:59 AM

Revision Contents

PathSize
mlir/
lib/
Bindings/
Python/
1 line

Diff 533303

mlir/lib/Bindings/Python/IRCore.cpp

Show First 20 Lines • Show All 1,165 Lines • ▼ Show 20 Linesvoid PyOperationBase::writeBytecode(const py::object &fileObject,
if (!bytecodeVersion.has_value()) if (!bytecodeVersion.has_value())
return mlirOperationWriteBytecode(operation, accum.getCallback(), return mlirOperationWriteBytecode(operation, accum.getCallback(),
accum.getUserData()); accum.getUserData());
MlirBytecodeWriterConfig config = mlirBytecodeWriterConfigCreate(); MlirBytecodeWriterConfig config = mlirBytecodeWriterConfigCreate();
mlirBytecodeWriterConfigDesiredEmitVersion(config, *bytecodeVersion); mlirBytecodeWriterConfigDesiredEmitVersion(config, *bytecodeVersion);
MlirLogicalResult res = mlirOperationWriteBytecodeWithConfig( MlirLogicalResult res = mlirOperationWriteBytecodeWithConfig(
operation, config, accum.getCallback(), accum.getUserData()); operation, config, accum.getCallback(), accum.getUserData());
mlirBytecodeWriterConfigDestroy(config);
if (mlirLogicalResultIsFailure(res)) if (mlirLogicalResultIsFailure(res))
throw py::value_error((Twine("Unable to honor desired bytecode version ") + throw py::value_error((Twine("Unable to honor desired bytecode version ") +
Twine(*bytecodeVersion)) Twine(*bytecodeVersion))
.str()); .str());
} }
py::object PyOperationBase::getAsm(bool binary, py::object PyOperationBase::getAsm(bool binary,
std::optional<int64_t> largeElementsLimit, std::optional<int64_t> largeElementsLimit,
▲ Show 20 Lines • Show All 2,302 Lines • Show Last 20 Lines