This is an archive of the discontinued LLVM Phabricator instance.

[lldb][MachO] Fix section type recognition for new DWARF 5 sections
ClosedPublic

Authored by fdeazeve on Jun 21 2023, 8:31 AM.

Details

Summary

When LLDB needs to access a debug section, it generally calls
SectionList::FindSectionByType with the corresponding type (we have one type for
each DWARF section). However, the missing entries made some sections be
classified as "eSectionTypeOther", which makes all calls to FindSectionByType
fail.

With this patch, a check-lldb build with
-DLLDB_TEST_USER_ARGS=--dwarf-version=5 reports a much lower number of
failures:

Unsupported      :  327
Passed           : 2423
Expectedly Failed:   16
Unresolved       :    2
Failed           :   52

This is down from previously 400~ failures.

Diff Detail

Event Timeline

fdeazeve created this revision.Jun 21 2023, 8:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2023, 8:31 AM
fdeazeve requested review of this revision.Jun 21 2023, 8:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 21 2023, 8:31 AM
fdeazeve updated this revision to Diff 533281.Jun 21 2023, 8:40 AM

Add missing debug_cu_index and debug_tu_index sections

This revision is now accepted and ready to land.Jun 21 2023, 9:09 AM
fdeazeve updated this revision to Diff 533320.Jun 21 2023, 10:15 AM

Add missing dwo sections