This is an archive of the discontinued LLVM Phabricator instance.

[NFC][libc++] Addresses LWG3935.
ClosedPublic

Authored by Mordante on Jun 19 2023, 8:16 AM.

Details

Reviewers
philnik
ldionne
Group Reviewers
Restricted Project
Commits
rG946116fc05e6: [NFC][libc++] Addresses LWG3935.
Summary

Note libc++ implemented this in its initial version.

Implements

  • LWG3935 template<class X> constexpr complex& operator=(const complex<X>&) has no specification

Diff Detail

Event Timeline

Mordante created this revision.Jun 19 2023, 8:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2023, 8:16 AM
Mordante requested review of this revision.Jun 19 2023, 8:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2023, 8:16 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.Jun 19 2023, 8:27 AM
This revision is now accepted and ready to land.Jun 19 2023, 8:27 AM
ldionne accepted this revision.Jun 19 2023, 12:18 PM
ldionne added a subscriber: ldionne.

Do we have a test for this? LGTM if we do, otherwise let's add one.

Do we have a test for this? LGTM if we do, otherwise let's add one.

Yes in libcxx/test/std/numerics/complex.number/complex.member.ops/assignment_complex.pass.cpp

This revision was automatically updated to reflect the committed changes.