This is an archive of the discontinued LLVM Phabricator instance.

Differential D152806

[lldb][test] Re-XFAIL prefer-debug-over-eh-frame.test
ClosedPublic

Authored by Michael137 on Jun 13 2023, 5:36 AM.

Details

Reviewers
fdeazeve
jasonmolenda
oontvoo
Commits
rGfae704bad900: [lldb][test] Re-XFAIL prefer-debug-over-eh-frame.test
Summary

This was un-XFAILed in 83cb2123be487302070562c45e6eb4955b22c2b4
due to D144999. Since then, D152540 fixed emission of eh_frame's
on Darwin, causing this test to fail again.

Diff Detail

Event Timeline

Michael137 created this revision.Jun 13 2023, 5:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2023, 5:36 AM
Michael137 requested review of this revision.Jun 13 2023, 5:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2023, 5:36 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Michael137 added reviewers: fdeazeve, jasonmolenda, oontvoo.Jun 13 2023, 5:37 AM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptJun 13 2023, 5:37 AM
Michael137 edited the summary of this revision. (Show Details)Jun 13 2023, 5:37 AM
Harbormaster completed remote builds in B238466: Diff 530873.Jun 13 2023, 5:40 AM
oontvoo accepted this revision.Jun 13 2023, 6:52 AM

Thank you!

This revision is now accepted and ready to land.Jun 13 2023, 6:52 AM
Closed by commit rGfae704bad900: [lldb][test] Re-XFAIL prefer-debug-over-eh-frame.test (authored by Michael137). · Explain WhyJun 13 2023, 7:08 AM
This revision was automatically updated to reflect the committed changes.
Michael137 added a commit: rGfae704bad900: [lldb][test] Re-XFAIL prefer-debug-over-eh-frame.test.

Revision Contents

PathSize
lldb/
test/
Shell/
Unwind/
1 line

Diff 530873

lldb/test/Shell/Unwind/prefer-debug-over-eh-frame.test

# Test that we prefer debug_frame over eh_frame unwind plans. They usually # Test that we prefer debug_frame over eh_frame unwind plans. They usually
# contain the same information, and we rarely have both kinds of entries for a # contain the same information, and we rarely have both kinds of entries for a
# single function. However, in theory the debug_frame plan can be more complete, # single function. However, in theory the debug_frame plan can be more complete,
# whereas eh_frame is only required to be correct at places where exceptions can # whereas eh_frame is only required to be correct at places where exceptions can
# be thrown. # be thrown.
# UNSUPPORTED: system-windows # UNSUPPORTED: system-windows
# XFAIL: system-darwin
# REQUIRES: target-x86_64, native # REQUIRES: target-x86_64, native
# RUN: %clang_host -g %p/Inputs/call-asm.c %p/Inputs/prefer-debug-over-eh-frame.s -o %t # RUN: %clang_host -g %p/Inputs/call-asm.c %p/Inputs/prefer-debug-over-eh-frame.s -o %t
# RUN: %lldb %t -s %s -o exit | FileCheck %s # RUN: %lldb %t -s %s -o exit | FileCheck %s
breakpoint set -n bar breakpoint set -n bar
# CHECK: Breakpoint 1: where = {{.*}}`bar # CHECK: Breakpoint 1: where = {{.*}}`bar
process launch process launch
# CHECK: stop reason = breakpoint 1.1 # CHECK: stop reason = breakpoint 1.1
target modules show-unwind -n foo target modules show-unwind -n foo
# CHECK: Asynchronous (not restricted to call-sites) UnwindPlan is 'DWARF CFI plus augmentation from assembly parsing' # CHECK: Asynchronous (not restricted to call-sites) UnwindPlan is 'DWARF CFI plus augmentation from assembly parsing'
# CHECK: Synchronous (restricted to call-sites) UnwindPlan is 'DWARF CFI' # CHECK: Synchronous (restricted to call-sites) UnwindPlan is 'DWARF CFI'
# CHECK: eh_frame UnwindPlan: # CHECK: eh_frame UnwindPlan:
# CHECK: debug_frame UnwindPlan: # CHECK: debug_frame UnwindPlan: