[LoongArch] Ignore warnings when there is no environment in triple

[hev]

Summary

In Rust bare-metal targets, there is no environment component in triple name. This patch ignores warnings that look like:

warning: triple-implied ABI conflicts with provided target-abi ‘lp64s', using target-abi

[SixWeining]

The change makes sense to me.

[xen0n]

Thanks! A test case would be appreciated though.

[hev]

Add test cases.

[xen0n]

llvm/test/CodeGen/LoongArch/target-abi-from-triple-edge-cases.ll

19

grammatical nit: "for there are" -> "when there is"

26–27

Since the intent here is just making sure no warning is emitted, and that the warning's exact form is already checked above, maybe we could coalesce the two into one as simple as NO-WARNING-NOT: warning?

[hev]

Update test case.

[xen0n]

Thanks!

llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchBaseInfo.cpp

case LoongArchABI::ABI_LP64D:
     if (!Is64Bit) {
       errs() << "64-bit ABIs are not supported for 32-bit targets, ignoring "
                 "target-abi and using triple-implied ABI\n";
       return TripleABI;
     }
     break;
   }
 
-  if (!ABIName.empty() && ArgProvidedABI != TripleABI)
+  if (!ABIName.empty() && TT.hasEnvironment() && ArgProvidedABI != TripleABI)
     errs() << "warning: triple-implied ABI conflicts with provided target-abi '"
            << ABIName << "', using target-abi\n";
 
   return ArgProvidedABI;
 }
 
 ABI getTargetABI(StringRef ABIName) {
   auto TargetABI = StringSwitch<ABI>(ABIName)

llvm/test/CodeGen/LoongArch/target-abi-from-triple-edge-cases.ll

 ; RUN: llc --mtriple=loongarch32-linux-gnusf --target-abi=ilp32d --mattr=+d < %s 2>&1 \
 ; RUN:   | FileCheck %s --check-prefixes=ILP32D,CONFLICT-ILP32D
 ; RUN: llc --mtriple=loongarch64-linux-gnusf --target-abi=lp64d --mattr=+d < %s 2>&1 \
 ; RUN:   | FileCheck %s --check-prefixes=LP64D,CONFLICT-LP64D
 
 ; CONFLICT-ILP32D: warning: triple-implied ABI conflicts with provided target-abi 'ilp32d', using target-abi
 ; CONFLICT-LP64D:  warning: triple-implied ABI conflicts with provided target-abi 'lp64d', using target-abi
 
+;; Check that no warning is reported when there is no environment component in
+;; triple-supplied ABI modifiers and --target-abi is used.
+; RUN: llc --mtriple=loongarch64-linux --target-abi=lp64d --mattr=+d < %s 2>&1 \
+; RUN:   | FileCheck %s --check-prefixes=LP64D,NO-WARNING
+
+; NO-WARNING-NOT:  warning: triple-implied ABI conflicts with provided target-abi 'lp64d', using target-abi
+
 ;; Check that ILP32-on-LA64 and LP64-on-LA32 combinations are handled properly.
 ; RUN: llc --mtriple=loongarch64 --target-abi=ilp32d --mattr=+d < %s 2>&1 \
 ; RUN:   | FileCheck %s --check-prefixes=LP64D,32ON64
 ; RUN: llc --mtriple=loongarch32 --target-abi=lp64d --mattr=+d < %s 2>&1 \
 ; RUN:   | FileCheck %s --check-prefixes=ILP32D,64ON32
 
 ; 32ON64: 32-bit ABIs are not supported for 64-bit targets, ignoring target-abi and using triple-implied ABI
 ; 64ON32: 64-bit ABIs are not supported for 32-bit targets, ignoring target-abi and using triple-implied ABI
 
 define float @f(float %a) {