This is an archive of the discontinued LLVM Phabricator instance.

[libc++][spaceship][NFC] P1614R2: Status page - mark header synopsis sections as "Complete"
ClosedPublic

Authored by H-G-Hristov on Jun 12 2023, 10:05 PM.

Details

Summary

Header synospis sections of P1614R2 are implemented by other items usually. For completeness, let's mark some of them as "Complete".

Diff Detail

Event Timeline

H-G-Hristov created this revision.Jun 12 2023, 10:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 10:05 PM
Herald added a subscriber: yaxunl. · View Herald Transcript
H-G-Hristov retitled this revision from [libc++][spaceship][NFC] P1614R2: Mark header synopsis sections as "Complete" to [libc++][spaceship][NFC] P1614R2: Status page - mark header synopsis sections as "Complete".Jun 12 2023, 10:13 PM
H-G-Hristov published this revision for review.EditedJun 13 2023, 12:18 AM
H-G-Hristov added a subscriber: Mordante.

@Mordante
There are a couple of items in the list: https://libcxx.llvm.org/Status/Spaceship.html which I am not sure about if there is anything to do about or just mark them as "Complete" or "Nothing to Do".

I think this patch completes my part of P1614R2. IMO There is nothing to do about ranges library. I'll double check and submit the patch to mark them as complete. Please let me know if there is anything else to do about P1614R2.

Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2023, 12:18 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante accepted this revision.Jun 14 2023, 8:37 AM

@Mordante
There are a couple of items in the list: https://libcxx.llvm.org/Status/Spaceship.html which I am not sure about if there is anything to do about or just mark them as "Complete" or "Nothing to Do".

Nothing to do, means there is no (hypothetical) change needed in the library. For example when I implement the TZDB parts of the library I will directly use the operators as defined in P1614, not what's in the TZDB paper. Had we implemented the TZDB change first we would have needed make changes, like we did for the calendar changes. So then it's not Nothing to do.

Some papers update the wording of the Standard to a new style, without changing the meaning for the wording. These changes are nothing to do. I hope that makes it clearer for you.

For these changes in the status table I probably wouldn't have listed the synopsis at all. This page is temporary and used for the libc++ developers to track the status. It will be removed in the future. So I don't feel to strong about Complete/Nothing to do here; I feel Complete is slightly better.

LGTM!

This revision is now accepted and ready to land.Jun 14 2023, 8:37 AM

@Mordante
There are a couple of items in the list: https://libcxx.llvm.org/Status/Spaceship.html which I am not sure about if there is anything to do about or just mark them as "Complete" or "Nothing to Do".

Nothing to do, means there is no (hypothetical) change needed in the library. For example when I implement the TZDB parts of the library I will directly use the operators as defined in P1614, not what's in the TZDB paper. Had we implemented the TZDB change first we would have needed make changes, like we did for the calendar changes. So then it's not Nothing to do.

Some papers update the wording of the Standard to a new style, without changing the meaning for the wording. These changes are nothing to do. I hope that makes it clearer for you.

For these changes in the status table I probably wouldn't have listed the synopsis at all. This page is temporary and used for the libc++ developers to track the status. It will be removed in the future. So I don't feel to strong about Complete/Nothing to do here; I feel Complete is slightly better.

LGTM!

Thank you for explaining.