This is an archive of the discontinued LLVM Phabricator instance.

[Clang][BFloat16] Upgrade __bf16 by supporting increment/decrement operations
ClosedPublic

Authored by joshua-arch1 on Jun 12 2023, 7:21 PM.

Details

Summary

Since __bf16 has been upgraded from a storage-only type to an arithmetic type in https://reviews.llvm.org/rGe62175736551abf40a3410bc246f58e650eb8158, it should support all the basic arithmetic operations like other float types, including increment and decrement.

Diff Detail

Event Timeline

joshua-arch1 created this revision.Jun 12 2023, 7:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 7:21 PM
joshua-arch1 requested review of this revision.Jun 12 2023, 7:21 PM
pengfei accepted this revision.Jun 12 2023, 8:48 PM

LGTM.

clang/lib/CodeGen/CGExprScalar.cpp
2766–2767

Update the comment here.

This revision is now accepted and ready to land.Jun 12 2023, 8:48 PM

LGTM. After fixing the comment that @pengfei mentions.

Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2023, 1:21 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript