This file was reformatted using the Black tool, which led to entirely
unreadable code due to how lines are broken. Formatting tools are fine,
but not when they lead to code that humans have trouble reading. In the
case of features.py, a lot of it was meant to be aligned in a repetitive
but consistent way to make the structure of the code stand out.
Reformatting with the tool lost that property.
Details
- Reviewers
Mordante - Group Reviewers
Restricted Project - Commits
- rG52310ce9c167: [libc++][NFC] Reformat features.py
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
No objection, but can you provide feedback regarding this issue on Discourse. I expect somebody will suggest enforcing Python formatting on commits; actually quite surprised that wasn't done in this project.
I consider most changes by black not a real improvement.
libcxx/utils/libcxx/test/features.py | ||
---|---|---|
26 | ||
236 | FYI I don't feel these changes by black are bad. |
Will do. Almost all of the changes I've seen so far have made code much less readable than it used to be. I missed the original discussion but if I had seen it and the result of the reformatting patch, I would have been an over-my-dead-body objection.
I'm in favour of automated formatting in the general case -- we didn't have clang-format and we do now. But when automated formatting makes the code really hard to read for arbitrary restrictions like 89 column width, then I'm not on board anymore.