Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D152704

[libc++][spaceship] P1614R2: Removed `operator!=` from `functional`
ClosedPublic
Actions

Authored by H-G-Hristov on Jun 12 2023, 5:19 AM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Commits
rG9a6ca67397eb: [libc++][spaceship] P1614R2: Removed `operator!=` from `functional`
Summary

Implements parts of P1614R2:

  • Removed operator!= from functional

Diff Detail

Event Timeline

H-G-Hristov created this revision.Jun 12 2023, 5:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 5:19 AM
Herald added a subscriber: yaxunl. · View Herald Transcript
Harbormaster completed remote builds in B238159: Diff 530468.Jun 12 2023, 8:58 AM
H-G-Hristov published this revision for review.Jun 12 2023, 9:19 AM

The CI error seems unrelated. I'll rebase and try again later.

Herald added a project: Restricted Project. · View Herald TranscriptJun 12 2023, 9:19 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Mordante accepted this revision.Jun 12 2023, 9:30 AM
Mordante added a subscriber: Mordante.
In D152704#4414204, @H-G-Hristov wrote:

The CI error seems unrelated. I'll rebase and try again later.

The CI is indeed unrelated, not need to rerun the CI.

LGTM!

This revision is now accepted and ready to land.Jun 12 2023, 9:30 AM
This revision was landed with ongoing or failed builds.Jun 12 2023, 9:48 AM
Closed by commit rG9a6ca67397eb: [libc++][spaceship] P1614R2: Removed `operator!=` from `functional` (authored by Zingam). · Explain Why
This revision was automatically updated to reflect the committed changes.
Zingam added a commit: rG9a6ca67397eb: [libc++][spaceship] P1614R2: Removed `operator!=` from `functional`.

Revision Contents
Changeset List

PathSize
libcxx/
docs/
Status/
2 lines
include/
__functional/
6 lines
6 lines

Diff 530557

View Options

libcxx/docs/Status/SpaceshipProjects.csv

Loading...
View Options

libcxx/include/__functional/function.h

Loading...
View Options

libcxx/include/functional

Loading...